Bug 394295 - TabBar tabs don't connect with the line below them
Summary: TabBar tabs don't connect with the line below them
Status: RESOLVED FIXED
Alias: None
Product: frameworks-qqc2-desktop-style
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: 5.46.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Marco Martin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-15 21:39 UTC by Nate Graham
Modified: 2019-01-27 16:36 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Kirigami tab widget in Gallery - inactive tabs don't connect (61.56 KB, image/png)
2018-05-15 21:39 UTC, Nate Graham 		Details
New screenshot (21.88 KB, image/png)
2019-01-26 23:26 UTC, David Edmundson 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2018-05-15 21:39:39 UTC 
Created attachment 112676 [details]
Kirigami tab widget in Gallery - inactive tabs don't connect

in Kirigami gallery, the inactive tabs don't connect with the line underneath them. This is either a bug, or a design choice that *looks* like a bug. :) See attached screenshot.
Comment 1 Kai Uwe Broulik 2018-05-16 08:45:32 UTC 
Bug in qqc2-desktop-style:

//Some QStyles seem to not return sensible pixelmetrics here
    implicitHeight: Math.max(Kirigami.Units.gridUnit * 2, contentItem.implicitHeight)

That causes the TabBar's height to be too large so the tab buttons don't align with/overlap the bottom line of the TabBar. Removing that line fixes it for Breeze but the comment is probably there for a reason.
Comment 2 David Edmundson 2019-01-26 23:26:14 UTC 
Created attachment 117667 [details]
New screenshot

Is it still an issue?
Comment 3 Nate Graham 2019-01-27 16:36:37 UTC 
Hmm, can no longer reproduce in any context. Looks like this is fixed!