Created attachment 112670 [details] Screenshot of the bug. Overview: When dolphin enters or reloads a folder that contains a password-protected .docx file, it will prompt the user for the document's password. Steps to reproduce: 1. Create and save a password-protected .docx file with LibreOffice or MS Word. 2. With dolphin, enter the folder where the document is stored. Actual Results: Dolphin will prompt the user for a password for the document. If there were multiple password-protected documents in the folder, multiple prompts will appear. Expected Results: Dolphin should not ask for a password until the user has explicitly opened the document. Version & Platform: Dolphin version 18.04.1 running on KDE Neon User Edition 5.12 (Linux x86_64 4.13.0-41-generic) Additional Info.: This does not seem to happen on password-protected .odt or .doc files.
Hmm, I cannot reproduce this behavior. I do also run KDE Neon User Edition 5.12.5 with Dolphin 18.04.1, but for me the password dialog only pops up when I try to open the file (which is the expected behavior). Maybe you could upload a document that triggers the bug for you just to rule out the possibility that I did not create the .docx file the same way you did? Thanks for reporting this bug & have a nice day :)
(In reply to Julian Schraner from comment #1) > Hmm, I cannot reproduce this behavior. I do also run KDE Neon User Edition > 5.12.5 with Dolphin 18.04.1, but for me the password dialog only pops up > when I try to open the file (which is the expected behavior). Maybe you > could upload a document that triggers the bug for you just to rule out the > possibility that I did not create the .docx file the same way you did? > Thanks for reporting this bug & have a nice day :) After reading your reply, I experimented around a bit more... And it looks like Calligra Suite is somehow related to this behavior. The bug disappears after running [apt remove calligra --autoremove] and reappears after running [apt install calligra]. So yeah, I think installing calligra may help you reproduce the bug. ...and just in case the bug still can't be reproduced, I'll add an attachment of a .docx file that cause the bug on my system.
Created attachment 112673 [details] A password-protected .docx file that causes the bug.
(In reply to chansol98s from comment #2) > (In reply to Julian Schraner from comment #1) > > Hmm, I cannot reproduce this behavior. I do also run KDE Neon User Edition > > 5.12.5 with Dolphin 18.04.1, but for me the password dialog only pops up > > when I try to open the file (which is the expected behavior). Maybe you > > could upload a document that triggers the bug for you just to rule out the > > possibility that I did not create the .docx file the same way you did? > > Thanks for reporting this bug & have a nice day :) > > > After reading your reply, I experimented around a bit more... > And it looks like Calligra Suite is somehow related to this behavior. > > The bug disappears after running [apt remove calligra --autoremove] and > reappears after running [apt install calligra]. > > So yeah, I think installing calligra may help you reproduce the bug. > > > ...and just in case the bug still can't be reproduced, I'll add an > attachment of a .docx file that cause the bug on my system. The Calligra suite has the thumbnailer for the docx. If the Calligra suite is installed and the thumbnailer is enabled for the .docx then there is the 'Enter password' query when the thumbnailer is trying to make the thumbnail. The 'Untitled 1.docx' is Microsoft Word 2007 Dcocument - so the Dolphin 'Show previews for': https://imgur.com/ZZJOluJ
An opinion: This is an example why the current Dolphin 'preview everything' is not good idea. Change was made with: https://cgit.kde.org/dolphin.git/commit/?id=bebcf035d264410c943e7bad861628c1b14dd1f2
Thanks a lot for investigating this bug! I can now also reproduce this behavior after installing Calligra. This is of course quite annoying, so we should try to not generate a preview for files which are password-protected.
This is a bug in the thumbnailer itself: for password-protected files, it shouldn't even try to generate a preview (the contents are secret for a reason, so a preview makes no sense). Also, the thumbnailer for this file type should really be moved into kio-extras so everyone can benefit from it: Bug 398813 (so if and when that bug gets addressed, we should move this bug to kio-extras).