Bug 394235 - Threshholdfilter applies to original, but not the actual picture
Summary: Threshholdfilter applies to original, but not the actual picture
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Filters (show other bugs)
Version: git master (please specify the git hash!)
Platform: Fedora RPMs Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-14 08:21 UTC by BenderIRC
Modified: 2018-06-05 14:12 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description BenderIRC 2018-05-14 08:21:04 UTC
I have a picture, where i erased 90% of the picture content. 

I erased the background with "Freehand Brush Tool" + "Set eraser mode".
When i now apply the "Threshold" filter to the picture, it does it's filtering to the original picture content, and not the actual shown one.

Means, i need to safe my erased picture first, and reload it later, before i can make use of that filter. 

This WORKS as long, as the saved picture isn't saved with an alpha channel. If it's a png + alpha channel, it prevails the original content somehow and when appling the threshold filter, the once erased parts are back :D 

How did you do that :D

Note: 

I would add the artwork, if it wasn't a picture of myself, which should not be found in a bugreport :D
Comment 1 Halla Rempt 2018-05-14 08:27:05 UTC
Hi,

While I strongly recommend updating to Krita 4.0.2 -- 3.3.2 is too old, and usually I would close reports against 3.x as unmaintained -- I can still reproduce this issue with the threshold filter in git master, so I can confirm the bug. But do update.
Comment 2 BenderIRC 2018-05-14 09:09:42 UTC
(In reply to Boudewijn Rempt from comment #1)
> Hi,
> 
> While I strongly recommend updating to Krita 4.0.2 -- 3.3.2 is too old, and

Fedora does not supply a newer version for Fedora 26. Fedora 27 will update it to 4.0.3 , and as EOL for F26 is only 3 weeks away, they won't change it :)
Comment 3 Halla Rempt 2018-05-14 09:26:04 UTC
That's why we supply appimages, to work around distributions not providing the latest version.
Comment 4 Halla Rempt 2018-06-05 14:12:13 UTC
Git commit ef8d6b5aab0d88a0a8520560c4ae7f1f466ef14f by Boudewijn Rempt.
Committed on 05/06/2018 at 14:11.
Pushed by rempt into branch 'master'.

Keep the alpha channel when applying the threshold filter

Erasing in Krita means setting alpha to transparent, not
removing actual pixel data.
(cherry picked from commit 12a72b3479e4d249aedbc506bdcbf2eb5a12ae99)

M  +2    -0    plugins/filters/threshold/threshold.cpp

https://commits.kde.org/krita/ef8d6b5aab0d88a0a8520560c4ae7f1f466ef14f
Comment 5 Halla Rempt 2018-06-05 14:12:20 UTC
Git commit 12a72b3479e4d249aedbc506bdcbf2eb5a12ae99 by Boudewijn Rempt.
Committed on 05/06/2018 at 14:10.
Pushed by rempt into branch 'krita/4.0'.

Keep the alpha channel when applying the threshold filter

Erasing in Krita means setting alpha to transparent, not
removing actual pixel data.

M  +2    -0    plugins/filters/threshold/threshold.cpp

https://commits.kde.org/krita/12a72b3479e4d249aedbc506bdcbf2eb5a12ae99