Bug 394184 - DoxygenLua syntax highlighting for block comments is broken
Summary: DoxygenLua syntax highlighting for block comments is broken
Status: RESOLVED FIXED
Alias: None
Product: frameworks-syntax-highlighting
Classification: Frameworks and Libraries
Component: syntax (show other bugs)
Version: 5.46.0
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: KWrite Developers
URL: https://phabricator.kde.org/D12860
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-13 02:43 UTC by Alex Castro
Modified: 2018-05-29 20:39 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 5.47
Sentry Crash Report:


Attachments
left - after update; right - before update (4.01 KB, image/png)
2018-05-13 02:43 UTC, Alex Castro
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Castro 2018-05-13 02:43:37 UTC
Created attachment 112608 [details]
left - after update; right - before update

Placing --[[ will result in all subsequent text being highlighted and counted as part of the block comment, even if the text is placed after ]].

Looking at the GitHub commits for syntax-highlighting, it appears to begin happening after the syntax files were updated for Lua 5.3 (commit 9f11b4f).
Using the highlighting file for doxygenlua from before the update results in correct highlighting.

Attached is a screenshot showing the issue while in Lua syntax highlighting and how it looked before.
Comment 1 Dominik Haumann 2018-05-29 20:31:52 UTC
Proposed patch: https://phabricator.kde.org/D12860
Comment 2 Dominik Haumann 2018-05-29 20:38:41 UTC
Git commit b136c9fd1c4901d9716148e6299a45955a60c506 by Dominik Haumann.
Committed on 29/05/2018 at 20:38.
Pushed by dhaumann into branch 'master'.

DoxygenLua: fix closing comment blocks

Summary:
Kate-editor needs the context to be marked dynamic to use a placeholder in a dynamic rule.

Test Plan:
Open Kate with the code lua below:

```
--[[
commented out
]]
local test
```

An equivalent is already in autotests/input/highlight.lua

Reviewers: #framework_syntax_highlighting, dhaumann

Reviewed By: #framework_syntax_highlighting, dhaumann

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D12860

M  +9    -9    data/syntax/doxygenlua.xml

https://commits.kde.org/syntax-highlighting/b136c9fd1c4901d9716148e6299a45955a60c506