Bug 394126 - Blacklist site from integrating with Media Player
Summary: Blacklist site from integrating with Media Player
Status: RESOLVED FIXED
Alias: None
Product: plasma-browser-integration
Classification: Plasma
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Kai Uwe Broulik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-11 13:00 UTC by Dennis
Modified: 2019-12-06 11:05 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dennis 2018-05-11 13:00:48 UTC
I have been using Firefox with Plasma Integration for some time and I really like for the Media Player integration with Plasma, but one problem there keeps annoying me and will probably also annoy other people. Is that when I receive a message on a page like Facebook Messenger and I hit play on Media Player it will just play the notification sound from Facebook Messenger because it was the last sound played in the browser, but I never want that sound replayed.
So I was thinking if it wound be possible to have the option to blacklist some websites from interacting with Plasma Integration?

Best Regards
/Dennis
Comment 1 Kai Uwe Broulik 2018-05-14 08:54:07 UTC
I experienced the same and made it ignore short sounds [1] and I haven't seen this bug since. Are you running the latest version of the browser extension?

[1] https://cgit.kde.org/plasma-browser-integration.git/commit/?id=f6f24a7b83aa8a30ca6438a436e2cfb99984304d
Comment 2 Dennis 2018-05-16 15:06:23 UTC
Just checked today and it is still a problem, but it seems to only be a problem with facebook. I have version 0.9 of the plugin Plasma Integration.
Comment 3 Kai Uwe Broulik 2018-05-20 09:07:39 UTC
Ok thanks for your feedback. I'll investigate further. I think adding a checkbox to the toolbar to disable integration on a per-domain basis would make sense.
Comment 4 Dennis 2018-05-20 09:12:56 UTC
Thanks, I will be looking forward to it :D
Comment 5 azrdev 2018-06-18 15:17:19 UTC
I see this problem with <web.skype.com>: Its notification sounds are not played when a message comes in, and/but I can click "play" on the firefox tray icon as often as I want to playback that notification sound.

software:
archlinux
extra/plasma-browser-integration 5.13.0-1
extra/firefox 60.0.2-1
browser plugin from amo, version 1.0 (updated 2018-06-14)

maybe related / duplicate:
https://bugs.kde.org/show_bug.cgi?id=395521
https://bugs.kde.org/show_bug.cgi?id=395563
Comment 6 zjeffer 2018-12-09 14:05:00 UTC
I'd also like the ability to blacklist sites. In my case sometimes reddit is annoying so I'd like to blacklist it. I think the best way to implement this option would be in the add-on settings in the browser.
Comment 7 Matthias Mueller 2019-09-10 10:38:20 UTC
I'm adding my vote for a blacklisting-option - in my case it's mainly 9gag thats showing up all the time once a single video is played until the tab is closed.
Comment 8 Kai Uwe Broulik 2019-09-24 14:53:16 UTC
Here's a WIP patch: https://phabricator.kde.org/D24194
Comment 9 Kai Uwe Broulik 2019-10-14 09:50:18 UTC
Git commit ca085f5001839127885f6ba6a7fdfe38ef005e76 by Kai Uwe Broulik.
Committed on 14/10/2019 at 09:50.
Pushed by broulik into branch 'master'.

Add per-origin media controls blacklist

Allows disabling them for a specific origin in case it causes trouble or unwanted media controls.

Differential Revision: https://phabricator.kde.org/D24194

M  +9    -0    extension/_locales/en/messages.json
M  +24   -1    extension/action_popup.css
M  +11   -1    extension/action_popup.html
M  +213  -0    extension/action_popup.js
M  +7    -1    extension/constants.js
M  +17   -3    extension/content-script.js
M  +8    -0    extension/extension-mpris.js
M  +0    -9    extension/extension.js

https://commits.kde.org/plasma-browser-integration/ca085f5001839127885f6ba6a7fdfe38ef005e76
Comment 10 zjeffer 2019-12-06 10:28:28 UTC
I got the new version with the blacklisting feature, but when I try to blacklist reddit, things like youtube videos still get played because their domain is of course youtube.com, not reddit.com, even though they get played in a reddit tab.

The reason I want to block reddit is because it's so damn buggy: even after closing the reddit tab after playing a video in it, plasma browser integration still thinks the video is playing. I have to close all Firefox tabs for it to go away.
Comment 11 Kai Uwe Broulik 2019-12-06 11:05:48 UTC
I've seen people mention that issue where it doesn't remove the player but I failed to reproduce it.

Unfortunately from within the content-script I can't really tell what parent frame the website is displayed in due to cross origin restrictions.