Bug 394067 - Various issues with the current palette docker
Summary: Various issues with the current palette docker
Status: RESOLVED LATER
Alias: None
Product: krita
Classification: Applications
Component: Dockers (show other bugs)
Version: 4.0
Platform: Microsoft Windows Microsoft Windows
: NOR crash
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-09 23:42 UTC by Kenneth Evans
Modified: 2018-06-27 18:54 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Evans 2018-05-09 23:42:36 UTC
I am having trouble using the Palette docker at all.

Some examples:

I save a new palette, say Test, then select it, then press + to add a color: Nothing happens
The added colors seem to appear if I choose another palette, then re-choose Test.

Having some colors showing, I then press delete (Circle with slash):
Nothing happens.
Again, if I choose another palette, then re-choose Test, the color is not there.

These two seem reproducible.  At other times:

Pressing delete: Krita crashes.
Sometimes the added colors have appeared but in narrow boxes, not squares.
Cannot drag the colors.
Sometimes can drag the colors but only to the left.
Creating a new Group fills it with ten colors of the last selected color.
Can't delete groups.
So far have been able to drag a color from one group to another.

I haven't quantified all these.  I also haven't redone all the tests I made with selecting another palette, then re-selecting Test after doing an operation.  The fact that it doesn't refresh is undoubtedly compounding the problems.  At a minimum, not refreshing is an issue.

I have started and restarted Krita numerous times and cleaned out the bad palettes in AppData/Roaming/krita/Palettes.  It has crashed maybe five times in the last couple of hours.

I also notice Save does not save the current palette with a new name, but creates a new, empty one.  I'm not sure if this is the correct behavior, but it is not what I would expect.
Comment 1 amyspark 2018-05-10 00:05:38 UTC
(In reply to Kenneth Evans from comment #0)
> I am having trouble using the Palette docker at all.
> 
> Some examples:
> 
> I save a new palette, say Test, then select it, then press + to add a color:
> Nothing happens
> The added colors seem to appear if I choose another palette, then re-choose
> Test.
> 
> Having some colors showing, I then press delete (Circle with slash):
> Nothing happens.
> Again, if I choose another palette, then re-choose Test, the color is not
> there.

I can confirm the above happens in 4.0.2 (MacOS Sierra).

> 
> These two seem reproducible.  At other times:
> 
> Pressing delete: Krita crashes.
> Sometimes the added colors have appeared but in narrow boxes, not squares.
> Cannot drag the colors.
> Sometimes can drag the colors but only to the left.
> Creating a new Group fills it with ten colors of the last selected color.
> Can't delete groups.
> So far have been able to drag a color from one group to another.

I couldn't get these.

> 
> (snip)
> 
> I also notice Save does not save the current palette with a new name, but
> creates a new, empty one.  I'm not sure if this is the correct behavior, but
> it is not what I would expect.

This is essentially correct as well.
Comment 2 Halla Rempt 2018-05-10 10:59:46 UTC
Well, one of our current gsoc projects is all about creating a new palette docker.
Comment 3 Kenneth Evans 2018-06-21 21:16:18 UTC
There was some indication this was worked on in 4.0.4.  It does seem to be better, but still flakey.  In particular I notice:

1. Adding a color gives a narrow rectangle rather than a square one.

2. Selecting a color in the palette as often as not brings up the properties for the color instead of setting the color.  I assume the latter is supposed to happen on a double click.

3. I have had good luck with an added color appearing (subject to item 1) but deleting a color often doesn't remove it from the palette as displayed.

All of these can be fixed by selecting another palette then going back to the one I am using (a real nuisance to do).  It thus seems as if the refresh that is being performed after actions like the above is not as full a refresh as is needed.
Comment 4 Antti Savolainen 2018-06-27 18:54:57 UTC
Boud is working on replacing the palette docker entirely. Closing this one.