Bug 394010 - Alt+D is being overwritten by the tab which has a title starting with D
Summary: Alt+D is being overwritten by the tab which has a title starting with D
Status: RESOLVED DUPLICATE of bug 337491
Alias: None
Product: Falkon
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: David Rosca
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-08 15:43 UTC by Cristian Adam
Modified: 2018-05-11 15:35 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Alt+D should not be taken (631.12 KB, video/mp4)
2018-05-08 15:43 UTC, Cristian Adam
Details
Falkon Fusion (800.31 KB, video/mp4)
2018-05-08 16:18 UTC, Cristian Adam
Details
setTabText debug (436 bytes, patch)
2018-05-11 14:37 UTC, David Rosca
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Cristian Adam 2018-05-08 15:43:01 UTC
Created attachment 112507 [details]
Alt+D should not be taken

Falkon is assigning shortcuts based on the name of the tab.

Alt+D is the shortcut to go to the address bar, which in my case is also the search bar.

I have attached a recording showing how Alt+D doesn't work when a tab for "Dropbox" is loaded.

Alt+D should have priority!
Comment 1 David Rosca 2018-05-08 16:09:00 UTC
It shouldn't work like that, it even tries to strip the accelerators (& character) from title to prevent interpreting it as such and resulting in this behavior.
However, it seems like something else is doing this, maybe breeze style or platform theme.

Can you try with "falkon -style fusion" ?
Comment 2 Cristian Adam 2018-05-08 16:18:09 UTC
Created attachment 112509 [details]
Falkon Fusion

I have attached a screen cast with -style fusion.

The first time it worked, then it didn't.

I have tested it before the screen cast and it was behaving as with breeze.

You cannot see in the video that actually the first Alt+D nothing happens, and the second one switches to the tab. This is common for both Fusion and Breeze.
Comment 3 Anmol Gautam 2018-05-10 14:20:38 UTC
Alt+D does focus the address bar (Plasma 5.5.5, Falkon 3.0.99 (master))
There is probably something else doing this.
Comment 4 Cristian Adam 2018-05-11 13:00:07 UTC
Just tested with Falkon 3.0.1 on KDE Neon. But still there.

I wish I could disable the ability to switch tabs with Alt+<first symbol from the page name>.

For example, I have now three tabs opened, this tab is the second and it starts with "3", I cannot switch to the third tab with Alt+3 because this tab is the second and it starts with... 3.
Comment 5 David Rosca 2018-05-11 13:02:52 UTC
> I wish I could disable the ability to switch tabs with Alt+<first symbol from the page name>.
Well, it's not feature in Falkon itself. Something else is doing this, but I have no idea what, sorry.

Does it also happen with tabs in other Qt apps?
Comment 6 Cristian Adam 2018-05-11 13:09:16 UTC
Krusader also adds keyboard shortcuts to its tabs. I tried changing the system themes, the "feature" is still there.

So it seems is a Qt 5.10 "feature".
Comment 7 Cristian Adam 2018-05-11 13:25:03 UTC
It seems there is a bug report for Qt: https://bugreports.qt.io/browse/QTBUG-46291
Comment 8 David Rosca 2018-05-11 14:37:27 UTC
Created attachment 112579 [details]
setTabText debug

It's not Qt doing this. Can you please apply this patch and post terminal output?
Comment 9 Cristian Adam 2018-05-11 15:13:31 UTC
setTabText "Empty Page"
setTabText "Empty Page"
setTabText "dropbox.com"
setTabText "dropbox.com"
setTabText "www.dropbox.com"
setTabText "https://www.dropbox.com"
setTabText "Dropbox"
setTabText "Dropbox"
setTabText "Dropbox"

No & in the text.
Comment 10 David Rosca 2018-05-11 15:23:28 UTC
Try adding 

[Development]
AutoCheckAccelerators=false

to ~/.config/kdeglobals as suggested in bug 337491
Comment 11 Cristian Adam 2018-05-11 15:33:00 UTC
> Try adding 
> 
> [Development]
> AutoCheckAccelerators=false
> 
> to ~/.config/kdeglobals as suggested in bug 337491

This fixes it! Thank you!

Why would you have this set as default?!
Comment 12 David Rosca 2018-05-11 15:35:56 UTC
> Why would you have this set as default?!
No idea, but I agree that this should not be enabled by default. In any case, it's not Falkon, but KDE platform plugin doing this.

*** This bug has been marked as a duplicate of bug 337491 ***