Bug 394007 - Redundant title in grouping plasmoid + folder view
Summary: Redundant title in grouping plasmoid + folder view
Alias: None
Product: plasmashell
Classification: Plasma
Component: Folder (show other bugs)
Version: master
Platform: Other Linux
: NOR minor
Target Milestone: 1.0
Assignee: Eike Hein
Depends on:
Reported: 2018-05-08 15:22 UTC by Alex L
Modified: 2020-01-23 19:21 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:

redundant "home" title (38.88 KB, image/png)
2018-05-08 15:22 UTC, Alex L
In Plasma 5.13 (52.22 KB, image/png)
2018-06-20 14:07 UTC, Alex L

Note You need to log in before you can comment on or make changes to this bug.
Description Alex L 2018-05-08 15:22:28 UTC
Created attachment 112504 [details]
redundant "home" title

As the title says, look at the attached image
Comment 1 Eike Hein 2018-05-09 06:19:56 UTC
You can hide the Folder View label in its settings.
Comment 2 Alex L 2018-05-09 08:17:53 UTC
(In reply to Eike Hein from comment #1)
> You can hide the Folder View label in its settings.

Of course, but then the label in tab bar disappear too, replaced by a generic "folder view".
Comment 3 Eike Hein 2018-05-09 08:28:02 UTC
Right. Good point.

Patch under review: https://phabricator.kde.org/D12775
Comment 4 Alex L 2018-05-09 08:30:33 UTC
Incredibly fast, thanks!
Comment 5 Eike Hein 2018-05-11 08:51:22 UTC
Git commit 28dc6b88538ebb9606db8678c40a2040d9d870f9 by Eike Hein.
Committed on 11/05/2018 at 08:51.
Pushed by hein into branch 'Plasma/5.12'.

Always set applet title, even when label is disabled

Except when we're a containment.

This way Folder View applets always have a nice tab title in
the grouping applet.

Reviewers: #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D12775

M  +15   -15   containments/desktop/package/contents/ui/FolderViewLayer.qml

Comment 6 Alex L 2018-06-20 14:07:04 UTC
Created attachment 113462 [details]
In Plasma 5.13
Comment 7 Alex L 2018-06-20 14:17:24 UTC
I'm reopening because:

> Of course, but then the label in tab bar disappear too, replaced by a generic "folder view".

while now instead of "folder view" there is a path (so it's even worse). See the attachment "Plasma 5.13".


Anyway I think that the expected behavior is not avoiding redundant title by disabling it in Folder View settings, but the label in grouping plasmoid should display:

* "Folder View" if Folder View has disabled the title
* else default/custom/path label

Folder View plasmoid shouldn't display any title when placed in a grouping plasmoid.
Comment 8 Eike Hein 2018-06-20 16:33:14 UTC
OK, I'll try to revamp the settings a bit for 5.14. It's a bit sad though - it'll make it look a lot more complex. Right now it's a single combo box, then it needs to be a combobox and an awkward "Show Label" checkbox. All for the grouping plasmoid ...
Comment 9 Jonathan Riddell 2018-07-18 14:36:13 UTC