Bug 393999 - breeze-icons >=5.46.0 fails its scalable test
Summary: breeze-icons >=5.46.0 fails its scalable test
Status: RESOLVED FIXED
Alias: None
Product: Breeze
Classification: Plasma
Component: Icons (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: andreas
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-08 13:03 UTC by Heiko Becker
Modified: 2019-05-16 08:50 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.49


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Christoph Feck 2018-05-30 22:11:15 UTC
Andreas, any idea how to resolve this issue?

Additionally, are systray icons part of the icon theme or the workspace theme?
Comment 2 andreas_k 2018-05-30 22:20:19 UTC
kai want's the system tray icon in breeze-icons and it look that there is no larger app icon needed, so I'm not interested in draw one when it's not needed.
Comment 3 Christoph Feck 2018-05-30 23:09:59 UTC
So if I understand the issue correctly, we would need to make a whitelist for icons that do not need to be scalable to arbitrary sizes, and exclude them from the tests that check scalability?
Comment 4 David Faure 2018-08-08 09:49:37 UTC
Git commit e7330e352bb17e7320c0b16f9aa32fe70384788e by David Faure, on behalf of Maximiliano Curia.
Committed on 08/08/2018 at 09:44.
Pushed by dfaure into branch 'master'.

ScalableTest, add "scalable" plasma-browser-integration

With the introduction of the plasma-browser-integration icon (Add
plasma-browser-integration system tray icon, 47b8e71a) the ScalableTest started
failing [1]. The test seems to expect a "larger" icon (greater than 48)
available to consider that there is a scalable icon. I'm not
sure if this test is still useful, as all the icons are now in svg format, and
while they might be designed for a low resolution, they are "scalable".

This patch simply adds symlinks to the 48 and 64 res, in order to make the
test pass.

[1]: https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/81/
FIXED-IN: 5.49

A  +1    -0    icons-dark/apps/48/plasma-browser-integration.svg
A  +1    -0    icons-dark/apps/64/plasma-browser-integration.svg
A  +1    -0    icons/apps/48/plasma-browser-integration.svg
A  +1    -0    icons/apps/64/plasma-browser-integration.svg

https://commits.kde.org/breeze-icons/e7330e352bb17e7320c0b16f9aa32fe70384788e