This recently improved a bit but icons continue to be very blurry. Icon smoothing seems to severely blur the icon previews. I am attaching two screenshots. One with smoothing the other without, this should highlight the blur caused by the smoothing. It looks really bad. Do we usually smooth icons? If so, are we requesting too large preview sizes to cause the smoothing? I'd think that if we request 32x32 (e.g.) and get 32x32 smoothing wouldn't even kick in since we don't scale, so something must definitely be wrong there. CCing kbroulik as he worked on this
Needz moar attachments
Created attachment 112635 [details] smooth=false screenshot
Created attachment 112636 [details] smooth=true screenshot
I think I fell asleep while reporting this bug lol
(screenshots are the other way around from what they are labeled as)
Previews are still blury. Operating System: Arch Linux KDE Plasma Version: 5.14.1 Qt Version: 5.11.2 KDE Frameworks Version: 5.51.0
Based on the research in https://phabricator.kde.org/D19467 it seems that all previews are blurry and that is a general issue with GridViewKCM.
FWIW and concerning the Icons KCM, the previews become sharp with view.implicitCellWidth = Kirigami.Units.gridUnit * 16 Proof: https://i.ibb.co/CzSs5xp/Screenshot-20190304-224455.png
Try this: https://phabricator.kde.org/D19530
Created attachment 120140 [details] Plasma 5.16 beta Previews look blurry when I set 1.2 as scale factor on Plasma 5.16 beta. Operating System: Arch Linux KDE Plasma Version: 5.15.90 KDE Frameworks Version: 5.58.0 Qt Version: 5.13.0 beta3
Since these are pixmaps, there is no way for them to not be blurry with fractional scaling, I'm afraid. It's just a fact of life with fractional scaling: you lose out on the ability for things to be "pixel-perfect".
Nate, an application can create pixmaps with the same scale factor as the screen, and thus can of course be pixel-perfect. It has to be adapted, though.
But the pixmap's contents may not be able to scale cleanly without being blurry. My point was that something that's pixel-perfect at 1x or 2x may not be able to be pixel-perfect at 1.2x.
The pixmaps are not pre-rendered images, but created on the fly from SVG graphics, so the contents can be made pixel-perfect according to the scaling ratio of the screen the pixmap is displayed on. Anyway, does this need to be reopened, or is it actually already fixed?
This bug was tracking integer scaling blurriness which is now fixed, so it should remain closed. I can reproduce factional scale factor blurriness though. Since it seems that this should theoretically be fixable, please file a new bug for it. Thanks!