Bug 393976 - [Vertical Tabs] Last closed tab is not reopened in correct position with Ctrl+Shift+T
Summary: [Vertical Tabs] Last closed tab is not reopened in correct position with Ctrl...
Status: RESOLVED FIXED
Alias: None
Product: Falkon
Classification: Applications
Component: extensions (other bugs)
Version First Reported In: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: David Rosca
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-07 21:56 UTC by Theo
Modified: 2018-05-08 09:39 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed/Implemented In: 3.0.1
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Theo 2018-05-07 21:56:18 UTC
When reopening the last closed tab with Ctrl+Shift+T, the tab appears at the end of the tab tree, not at the position in the tree where it was closed.
Comment 1 David Rosca 2018-05-08 08:54:29 UTC
At most it could be returned to the correct parent, but returning it to correct place (index) in the tree would require to keep track of two trees (with and without closed tabs).
Comment 2 David Rosca 2018-05-08 09:39:23 UTC
Git commit 6e3da02d7dc19d537ab24dc11a2a8d27204fc403 by David Rosca.
Committed on 08/05/2018 at 09:26.
Pushed by drosca into branch 'Falkon/3.0'.

ClosedTabsManager: Save and restore parent tab
FIXED-IN: 3.0.1

M  +2    -0    src/lib/tabwidget/tabwidget.cpp
M  +1    -0    src/lib/tools/closedtabsmanager.cpp
M  +2    -0    src/lib/tools/closedtabsmanager.h

https://commits.kde.org/falkon/6e3da02d7dc19d537ab24dc11a2a8d27204fc403