Bug 393948 - When opening history sidebar, cursor should be in the history search text box
Summary: When opening history sidebar, cursor should be in the history search text box
Status: RESOLVED FIXED
Alias: None
Product: Falkon
Classification: Applications
Component: general (other bugs)
Version First Reported In: unspecified
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: David Rosca
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-07 10:52 UTC by Kishore Gopalakrishnan
Modified: 2019-04-10 15:13 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kishore Gopalakrishnan 2018-05-07 10:52:05 UTC
I often find myself pressing ctrl+h to open history, then start typing to filter history entries, only to realise I have to click on the text box on top of the history sidebar, in order to put the cursor there first. I think you should consider making the cursor focus be there when the sidebar is newly opened.
Comment 1 David Rosca 2019-04-10 15:13:24 UTC
Git commit e66835b4bfd3f175a01a4ac08b24214b49a953d3 by David Rosca, on behalf of Saish Mhatre.
Committed on 10/04/2019 at 15:11.
Pushed by drosca into branch 'master'.

Added focus for searchbar in history sidebar & bookmark sidebar

Summary:
After Adding Focus , user can directly search after pressing ctrl+h in history sidebar
& ctrl+shift+b in bookmark sidebar

Reviewers: #falkon, drosca

Reviewed By: #falkon, drosca

Subscribers: SGOrava, falkon, #falkon

Tags: #falkon

Differential Revision: https://phabricator.kde.org/D20022

M  +6    -0    src/lib/sidebar/bookmarkssidebar.cpp
M  +2    -0    src/lib/sidebar/bookmarkssidebar.h
M  +6    -0    src/lib/sidebar/historysidebar.cpp
M  +2    -0    src/lib/sidebar/historysidebar.h

https://commits.kde.org/falkon/e66835b4bfd3f175a01a4ac08b24214b49a953d3