Bug 393923 - Grammar in readme and idle.xml specification
Summary: Grammar in readme and idle.xml specification
Status: RESOLVED WORKSFORME
Alias: None
Product: kwayland
Classification: Frameworks and Libraries
Component: client (show other bugs)
Version: unspecified
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Martin Flöser
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-06 19:17 UTC by gmendoza678+kde
Modified: 2022-12-26 05:20 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
patch file for grammar errors (5.18 KB, patch)
2018-05-06 19:17 UTC, gmendoza678+kde
Details

Note You need to log in before you can comment on or make changes to this bug.
Description gmendoza678+kde 2018-05-06 19:17:05 UTC
Created attachment 112449 [details]
patch file for grammar errors

First off, apologies if I marked this as the wrong product - I could not find an exact match for this github repo. I noticed in a commit to the sway window manager which pulled in your description of the idle protocol (https://github.com/KDE/kwayland/blob/98628f9387ff9628b3c7c3fa66b0db4b01ef67c8/src/client/protocols/idle.xml) that there were some grammar errors. I was going to file a pull request on github, but it appears no one checks that repository. A lot of the errors I fixed were also tackled in https://github.com/KDE/kwayland/pull/1.
Would appreciate if these were fixed. I've attached my diff as well. Thanks!
Comment 1 gmendoza678+kde 2018-05-06 19:18:11 UTC
Also, a discussion of the construction "allows to" can be found at https://english.stackexchange.com/questions/85069.
Comment 2 Christoph Feck 2018-05-31 18:28:02 UTC
Thanks for the patch! Developers will review patches if you add them to https://phabricator.kde.org/differential/diff/create/
Comment 3 Christoph Feck 2018-06-15 00:44:54 UTC
Any sucess with link from comment #2?
Comment 4 Justin Zobel 2022-11-26 00:14:04 UTC
Thank you for reporting this issue in KDE software. As it has been a while since this issue was reported, can we please ask you to see if you can reproduce the issue with a recent software version?

If you can reproduce the issue, please change the status to "REPORTED" when replying. Thank you!
Comment 5 Bug Janitor Service 2022-12-11 05:07:00 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 6 Bug Janitor Service 2022-12-26 05:20:51 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!