Bug 393846 - chromium manifest installed to Ubuntu-specific path
Summary: chromium manifest installed to Ubuntu-specific path
Status: RESOLVED FIXED
Alias: None
Product: plasma-browser-integration
Classification: Plasma
Component: Chrome (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Bhushan Shah
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-04 14:14 UTC by Antonio Rojas
Modified: 2018-05-16 08:36 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Antonio Rojas 2018-05-04 14:14:04 UTC
The /usr/share/chromium-browser/extensions path for Chromium extensions is specific to Ubuntu (not even Debian uses it).
As long as this path is hardcoded in p-b-i (which otherwise makes sense, since it is also hardcoded in Chromium itself) it should be hardcoded to the upstream path /usr/share/chromium/extensions, not to the Ubuntu specific one:

https://github.com/chromium/chromium/blob/master/chrome/common/chrome_paths.cc#L62
Comment 1 Bhushan Shah 2018-05-16 08:36:12 UTC
Git commit 9d6056c5e6ca531869cbd924b0b3d89a184ad3ca by Bhushan Shah.
Committed on 16/05/2018 at 08:35.
Pushed by bshah into branch 'master'.

cmake: Don't install chrome manifest to ubuntu specific location

Ubuntu patches their chromium to have extension path to be
chromium-browser/extensions instead of chromium/extensions for whatever
reasons. This doesn't work with anything !ubuntu.

So code here is adjusted to match what upstream does for now, ubuntu
needs to manually patch this out OR devise a packaging level solution as
we can't keep packaging workarounds in upstream repository.

Reviewed-by: kbroulik

CCMAIL: distributions@kde.org
CCMAIL: kde-distro-packagers@kde.org

M  +4    -1    CMakeLists.txt

https://commits.kde.org/plasma-browser-integration/9d6056c5e6ca531869cbd924b0b3d89a184ad3ca