Bug 393834 - Address bar doesn't update when going back if it has focus
Summary: Address bar doesn't update when going back if it has focus
Status: RESOLVED FIXED
Alias: None
Product: Falkon
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: David Rosca
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-04 08:48 UTC by Antonio Rojas
Modified: 2018-05-08 09:39 UTC (History)
2 users (show)

See Also:
Latest Commit: https://commits.kde.org/falkon/4454ac714c99c5b10f24040f5fb0ad7b7edd4141
Version Fixed In: 3.0.1
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Antonio Rojas 2018-05-04 08:48:36 UTC 
- Navigate to some website in an already opened tab
- Click on the address bar so that it gets focus
- Press the back button

-> Address bar still shows the address of the previous site instead of the new one
Comment 1 Anmol Gautam 2018-05-06 15:13:38 UTC 
IMHO this doesnt qualify as a bug, falkon is designed to work this way only. For cases when you are typing in addressbar (address bar is focussed), then its not good to change the url in address bar
Comment 2 Christian 2018-05-06 16:09:42 UTC 
Behaviour confirmed in Falkon 3.0.0.
I agree with Comment 1 that this is not a bug, but supposed to behave this way. If the address bar has focus, this means that someone is editing it - then its contents should not change in the case of navigation events.
The address bar does show the correct address of the "back" page when you leave it by e.g. typing Esc.
Comment 3 Antonio Rojas 2018-05-06 17:24:03 UTC 
(In reply to Christian from comment #2) 
> The address bar does show the correct address of the "back" page when you
> leave it by e.g. typing Esc.

It does if you press Esc, it doesn't if you leave the address bar by clicking on the web page.
Comment 4 David Rosca 2018-05-08 09:31:59 UTC 
It's intended to work like this, but in this case it's wrong. It should only ignore url changes that are not user-initiated (eg. page redirects).
Comment 5 David Rosca 2018-05-08 09:39:23 UTC 
Git commit 4454ac714c99c5b10f24040f5fb0ad7b7edd4141 by David Rosca.
Committed on 08/05/2018 at 09:35.
Pushed by drosca into branch 'Falkon/3.0'.

NavigationBar: Focus webview when navigating back/forward
FIXED-IN: 3.0.1

M  +6    -4    src/lib/navigation/navigationbar.cpp

https://commits.kde.org/falkon/4454ac714c99c5b10f24040f5fb0ad7b7edd4141