Bug 393821 - Horizontal spacing is inconsistent for different icon sizes
Summary: Horizontal spacing is inconsistent for different icon sizes
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: view-engine: icons mode (show other bugs)
Version: 18.04.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2018-05-03 20:58 UTC by Eugene G.
Modified: 2020-11-13 02:46 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:

Attachments
calculate item width relative to icon size (853 bytes, patch)
2018-05-03 20:58 UTC, Eugene G. 		Details
large_32px (313.50 KB, image/jpeg)
2018-05-03 20:59 UTC, Eugene G. 		Details
large_64px (360.82 KB, image/jpeg)
2018-05-03 21:00 UTC, Eugene G. 		Details
medium_32 (304.54 KB, image/jpeg)
2018-05-03 21:00 UTC, Eugene G. 		Details
medium_64 (351.18 KB, image/jpeg)
2018-05-03 21:01 UTC, Eugene G. 		Details
patch v2 (854 bytes, patch)
2018-05-19 19:46 UTC, Eugene G. 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Eugene G. 2018-05-03 20:58:29 UTC 
Created attachment 112398 [details]
calculate item width relative to icon size

Currently dolphin's icon view calculates item width in fixed increments (48px + [0 | 64 | 128])
This causes some weird things. For example:

1. Set icon size to 112px.
2. Set width to "small".
3. Set width to "medium". Nothing visually changes.
4. Set width to "large". Now there are suddenly a big spaces between the icons.

The proposed patch instead calculates the item's width from the current icon size.
It may need some tweaks to feel right; please test
Comment 1 Eugene G. 2018-05-03 20:59:52 UTC 
Created attachment 112399 [details]
large_32px
Comment 2 Eugene G. 2018-05-03 21:00:09 UTC 
Created attachment 112400 [details]
large_64px
Comment 3 Eugene G. 2018-05-03 21:00:59 UTC 
Created attachment 112401 [details]
medium_32
Comment 4 Eugene G. 2018-05-03 21:01:19 UTC 
Created attachment 112402 [details]
medium_64
Comment 5 Julian Steinmann 2018-05-05 17:57:33 UTC 
Looks great! Consider submitting this patch to phabricator.kde.org, where other developers can review the patch and give you feedback for it. Thanks for not only reporting this bug but also providing a patch for it, that is truly amazing :)
Comment 6 Eugene G. 2018-05-19 19:46:35 UTC 
So i've tested it for a few days, doesn't seem to look weird.
Here is a review request: https://phabricator.kde.org/D12983
Comment 7 Eugene G. 2018-05-19 19:46:52 UTC 
Created attachment 112753 [details]
patch v2
Comment 8 Justin Zobel 2020-10-26 02:54:08 UTC 
Requested on phab to see if we can move the patch to Gitlab and continue the work on it.
Comment 9 Justin Zobel 2020-11-13 02:46:47 UTC 
Fixed with: https://invent.kde.org/system/dolphin/-/merge_requests/89