Bug 393749 - Applets using ExpandableListItem component are hard to use with a touch screen
Summary: Applets using ExpandableListItem component are hard to use with a touch screen
Status: RESOLVED FIXED
Alias: None
Product: libplasma
Classification: Frameworks and Libraries
Component: components (show other bugs)
Version: 5.69.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Nate Graham
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2018-05-01 23:12 UTC by Aleix Pol
Modified: 2020-04-18 05:45 UTC (History)
3 users (show)

See Also:
Latest Commit: https://commits.kde.org/plasma-framework/52c0a136f9fff59db30210a788e9f904ea594fa4
Version Fixed In: 5.70

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Aleix Pol 2018-05-01 23:12:57 UTC 
To press the "Connect" button it expects a hover event we can't grant by touching.
Comment 1 David Edmundson 2018-05-01 23:31:58 UTC 
What connect button?
Comment 2 Aleix Pol 2018-05-01 23:48:27 UTC 
Oops wrong component.
Comment 3 Nate Graham 2020-04-13 19:44:50 UTC 
Confirmed. I'll fix this for everything all at once in the ExpandableListItem component.
Comment 4 Nate Graham 2020-04-13 21:02:57 UTC 
Working on a patch...
Comment 5 Nate Graham 2020-04-13 23:12:55 UTC 
Patch: https://phabricator.kde.org/D28808
Comment 6 Nate Graham 2020-04-18 05:45:40 UTC 
Git commit 52c0a136f9fff59db30210a788e9f904ea594fa4 by Nate Graham.
Committed on 18/04/2020 at 05:45.
Pushed by ngraham into branch 'master'.

[ExpandableListItem] make it touch-friendly

Summary:
Right now ExpandableListItem is not very touch-friendly due to use of a mousearea
hover effect for choosing the selected item. This patch fixes that by using a `TapHandler`
to handle left-clicks and  touch input. We still need a MouseArea inside it to handle
non-touch hover and right-click behaviors.
FIXED-IN: 5.70

Test Plan: Click behavior is identical to how it was before, but now touch works too: {F8234452}

Reviewers: #plasma, apol, #vdg, niccolove

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D28808

M  +124  -113  src/declarativeimports/plasmaextracomponents/qml/ExpandableListItem.qml

https://commits.kde.org/plasma-framework/52c0a136f9fff59db30210a788e9f904ea594fa4