Bug 393745 - Build is broken with trunk LLVM/Clang
Summary: Build is broken with trunk LLVM/Clang
Status: RESOLVED FIXED
Alias: None
Product: clazy
Classification: Developer tools
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Sergio Martins
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-01 22:10 UTC by Eugene Zelenko
Modified: 2018-05-08 17:52 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eugene Zelenko 2018-05-01 22:10:23 UTC
Build with with trunk LLVM/Clang become broken yesterday:

Clazy/src/checks/level2/old-style-connect.cpp:232:52: error: no member named 'first' in 'clang::CharSourceRange'
    SourceRange range = SourceRange(expansionRange.first, expansionRange.second);
                                    ~~~~~~~~~~~~~~ ^
Clazy/src/checks/level2/old-style-connect.cpp:232:74: error: no member named 'second' in 'clang::CharSourceRange';
      did you mean 'setEnd'?
    SourceRange range = SourceRange(expansionRange.first, expansionRange.second);
                                                                         ^~~~~~
                                                                         setEnd
llvm-svn.src/tools/clang/include/clang/Basic/SourceLocation.h:267:8: note: 'setEnd' declared here
  void setEnd(SourceLocation e) { Range.setEnd(e); }
       ^
Clazy/src/checks/level2/old-style-connect.cpp:397:60: error: no member named 'first' in 'clang::CharSourceRange'
            SourceRange range = SourceRange(expansionRange.first, expansionRange.second);
                                            ~~~~~~~~~~~~~~ ^
Clazy/src/checks/level2/old-style-connect.cpp:397:82: error: no member named 'second' in 'clang::CharSourceRange';
      did you mean 'setEnd'?
            SourceRange range = SourceRange(expansionRange.first, expansionRange.second);
                                                                                 ^~~~~~
                                                                                 setEnd
llvm-svn.src/tools/clang/include/clang/Basic/SourceLocation.h:267:8: note: 'setEnd' declared here
  void setEnd(SourceLocation e) { Range.setEnd(e); }
       ^
Comment 1 Sergio Martins 2018-05-06 18:15:57 UTC
Git commit 06edd15fdda9155b54366d3887a4fbf25cf1d911 by Sergio Martins.
Committed on 06/05/2018 at 18:14.
Pushed by smartins into branch 'master'.

Fix build with clang 8.0

M  +14   -4    src/checks/level2/old-style-connect.cpp

https://commits.kde.org/clazy/06edd15fdda9155b54366d3887a4fbf25cf1d911
Comment 2 Eugene Zelenko 2018-05-07 23:51:25 UTC
Actually trunk LLVM/Clang version is 7.
Comment 3 Sergio Martins 2018-05-08 17:52:58 UTC
indeed, thanks!

commit fa6f5d8e206eca0823cfa5030abb5c824f7685ac (HEAD -> master, origin/master, origin/HEAD)
Author: Sergio Martins <iamsergio@gmail.com>
Date:   Tue May 8 15:52:06 2018 +0100

    Actually fix build with clang 7.0

    Trunk is 7.0, not 8.0

    BUG: 393745