Bug 393668 - Add keyframes to effects
Summary: Add keyframes to effects
Status: CONFIRMED
Alias: None
Product: kdenlive
Classification: Applications
Component: Video Effects & Transitions (show other bugs)
Version: Appimage - Refactoring
Platform: Ubuntu Linux
: NOR wishlist
Target Milestone: ---
Assignee: Vincent PINON
URL:
Keywords: triaged
Depends on:
Blocks:
 
Reported: 2018-04-30 10:14 UTC by hellocatfood
Modified: 2024-10-26 13:39 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:
fritzibaby: Brainstorm+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description hellocatfood 2018-04-30 10:14:53 UTC
Currently for keyframes you add and edit them on a linear timeline. For better control and editing it would be very useful to have a curve editor for keyframes, similar to what Blender has.
Comment 1 emohr 2018-12-29 13:26:08 UTC
On most effect you can change to “smooth” to have keyframe as curve. More details see here: https://kdenlive.org/en/project/the-smooth-keyframe-interpolation/.

We closed this bug. If it still appears in the latest version, please feel free to re-open it and update the affected version number.
Comment 2 hellocatfood 2018-12-31 13:43:48 UTC
I'm on Ubuntu 18.10 and running kdenlive 19.03.70 (4:19.03.70+git201812181728~ubuntu18.10.1)

I've gone through the video effects and have found that the following do not have a way to add keyframes:

Binarize
Charcoal
Dust
Grain
Old Film
Scratch Lines
Auto Mask
Obscure
Chroma Hold
Greyscale (may not be needed)
Invert (may not be needed)
LumaLiftGainGamma
Sepia (may not be needed)
Technicolor
Apply LUT (may not be needed)
Brightness
Brightness (keyframeable) (Cant see any way to add keyframes)
CMYK adjust
Lift/gamma/gain
Edge Crop
Rotate and Shear
Transform
Mirror (may not be needed)
Every effect under Misc

As mentioned perhaps not all of those need keyframes but for effects like Speed I feel adding keyframes should be available.
Comment 3 emohr 2019-01-01 15:31:39 UTC
Thank you for the investigation. I changed the title the version and change it to “whislist”.
Comment 4 farid 2021-04-16 01:36:09 UTC
Also missing Glitch0r effect
Comment 5 farid 2021-04-16 01:46:08 UTC
Also missing Gaussian Blur effect
Comment 6 Julius Künzel 2021-05-18 13:21:25 UTC
Git commit e02dec093867bda48bbe60159aece6bf84cbf314 by Julius Künzel.
Committed on 18/05/2021 at 13:19.
Pushed by jlskuz into branch 'release/21.04'.

Make glitch0r effect keyframable

M  +1    -0    data/effects/CMakeLists.txt
A  +18   -0    data/effects/frei0r_glitch0r.xml

https://invent.kde.org/multimedia/kdenlive/commit/e02dec093867bda48bbe60159aece6bf84cbf314
Comment 7 Julius Künzel 2021-05-18 14:25:18 UTC
Git commit 0c838d06b00bd705ccd7f0d6542d63a7b6d95b76 by Julius Künzel.
Committed on 18/05/2021 at 14:25.
Pushed by jlskuz into branch 'release/21.04'.

Make effects keyframable: charcoal, dust, oldfilm, threshold.xml

M  +4    -4    data/effects/charcoal.xml
M  +2    -2    data/effects/dust.xml
M  +8    -8    data/effects/oldfilm.xml
M  +1    -1    data/effects/threshold.xml

https://invent.kde.org/multimedia/kdenlive/commit/0c838d06b00bd705ccd7f0d6542d63a7b6d95b76
Comment 8 Julius Künzel 2021-05-18 15:45:07 UTC
Git commit a93b4c33384f8c25c6f0b02ed301765832ef6b77 by Julius Künzel.
Committed on 18/05/2021 at 15:44.
Pushed by jlskuz into branch 'release/21.04'.

Make effects keyframable: scratchlines, tcolor, lumaliftgaingamma

M  +1    -0    data/effects/CMakeLists.txt
A  +15   -0    data/effects/lumaliftgaingamma.xml
M  +4    -4    data/effects/scratchlines.xml
M  +2    -2    data/effects/tcolor.xml

https://invent.kde.org/multimedia/kdenlive/commit/a93b4c33384f8c25c6f0b02ed301765832ef6b77
Comment 9 Julius Künzel 2021-05-18 15:47:19 UTC
Update on the list (haven't searched for new ones, just toke the effects mentioned here in to account):

** TODO (more complex or needs checking) **
Chroma Hold
CMYK adjust
Edge Crop
Rotate and Shear
Gaussian Blur
Lift/gamma/gain
Obscure

** NOT NEEDED **
Greyscale
Invert
Sepia
Mirror
Apply LUT

** DEPRECATED **
Grain
Auto Mask
Comment 10 Julius Künzel 2021-09-29 23:59:35 UTC
Git commit 285c1cdf9130fa089d72104d07f702304d6ba4c0 by Julius Künzel.
Committed on 29/09/2021 at 23:59.
Pushed by jlskuz into branch 'master'.

Make color wheel ("lift/gamma/gain" effect) keyframable

M  +6    -6    src/assets/keyframes/model/keyframemodel.cpp
M  +4    -4    src/assets/model/assetparametermodel.cpp
M  +31   -43   src/assets/view/assetparameterview.cpp
M  +1    -3    src/assets/view/widgets/abstractparamwidget.cpp
M  +1    -2    src/assets/view/widgets/abstractparamwidget.hpp
M  +31   -0    src/assets/view/widgets/keyframewidget.cpp
M  +11   -5    src/assets/view/widgets/lumaliftgainparam.cpp
M  +7    -6    src/assets/view/widgets/lumaliftgainparam.hpp

https://invent.kde.org/multimedia/kdenlive/commit/285c1cdf9130fa089d72104d07f702304d6ba4c0