Bug 393608 - dialog-ok-apply.svg (32) is different compared to other sizes
Summary: dialog-ok-apply.svg (32) is different compared to other sizes
Status: RESOLVED FIXED
Alias: None
Product: Breeze
Classification: Plasma
Component: Icons (other bugs)
Version First Reported In: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: visual-design
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-28 13:42 UTC by Alex Nemeth
Modified: 2018-11-22 20:11 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 5.53
Sentry Crash Report:


Attachments
Different sizes (1.56 KB, image/png)
2018-04-28 13:42 UTC, Alex Nemeth
Details
Octopi at 2x scaling (65.38 KB, image/png)
2018-04-28 13:43 UTC, Alex Nemeth
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Nemeth 2018-04-28 13:42:29 UTC
Created attachment 112296 [details]
Different sizes

The 32 size looks wonky compared to the other sizes.
Every other size looks like the dialog-ok.svg except this at 32.
Also this icon is used in HiDPI mode so it is more apparent.
Comment 1 Alex Nemeth 2018-04-28 13:43:57 UTC
Created attachment 112297 [details]
Octopi at 2x scaling

Here is an example. Octopi at 2x scale with HiDPI icons.
Top is how it looks currently, looks wonky.
Bottom is how it should look like.
Comment 2 Noah Davis 2018-11-22 20:11:12 UTC
Git commit e1375f0efcdf6589344ce52cefe98b401caf4402 by Noah Davis, on behalf of Rafael Brandmaier.
Committed on 22/11/2018 at 20:10.
Pushed by ndavis into branch 'master'.

Fix angle and margin of 32px dialog-ok-apply

Summary:

FIXED-IN: 5.53

Fix the off-angle of the checkmark and apply new `2px` margins. Create symlinks from `dialog-ok.svg` and `gtk-ok.svg` to `dialog-ok-apply.svg`, as these are the for smaller sizes, but not `32px`.

Test Plan:
Before:
{F6434307}

After:
{F6434308}

Reviewers: #vdg, #breeze, ndavis

Reviewed By: #vdg, #breeze, ndavis

Subscribers: ndavis, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D17062

M  +1    -13   icons-dark/actions/32/dialog-ok-apply.svg
A  +1    -0    icons-dark/actions/32/dialog-ok.svg
A  +1    -0    icons-dark/actions/32/gtk-ok.svg
M  +1    -13   icons/actions/32/dialog-ok-apply.svg
A  +1    -0    icons/actions/32/dialog-ok.svg
A  +1    -0    icons/actions/32/gtk-ok.svg

https://commits.kde.org/breeze-icons/e1375f0efcdf6589344ce52cefe98b401caf4402