Falkon should integrate with KRunner the same as Plasma Browser Integration does for Chome and Firefox. It lists tabs you have open which you can select. Screenshot at https://twitter.com/KdeNeon/status/989504172637741056
See KAbstractRunner says d_ed
> See KAbstractRunner says d_ed What about implementing org.kde.plasma.browser_integration.TabsRunner instead?
I think we should port the tab runner in p-b-i to use the new fancy KF5::DBusRunner and unify the namespaces, so we have org.kde.runners.browsertabs.1234 and have both p-b-i and Falkon use it, so we only need one installed tabs runner that magically works with all of them.
FWIW, I meant: D10078 KDBusRunner::AbstractRunner which should be a 10 line patch. I can do it.
@David,you plan to do it?
Sure.
@David is this done. If not, I would like to work on it.
No news for almost 2 years, which I guess you are free to work on it.
I have been trying to figure out how to make krunner search for bookmarks and found out that the bookmarks in falkon are being saved in a JSON file in '.config/falkon/profile/default' now what I should do is, make krunner search for the content in this file. Is this correct? Also, I came across https://techbase.kde.org/Development/Tutorials/D-Bus/Introduction, can someone please confirm if this is what I have to work on.
The bookmarks are independent of the browser integration. If you plan on adding an integration for it https://invent.kde.org/plasma/plasma-workspace/-/tree/master/runners/bookmarks is the place. Considering that it is just a JSON file the implementation should be relatively easy.
*** Bug 387427 has been marked as a duplicate of this bug. ***
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/94
Git commit bbed524a2cec1508522ee5a903cab504b9c0d5a6 by Alexander Lohnau. Committed on 15/07/2020 at 16:49. Pushed by alex into branch 'master'. Add bookmarksrunner integration for Falkon M +1 -0 runners/bookmarks/CMakeLists.txt M +1 -1 runners/bookmarks/bookmarksrunner.cpp M +4 -1 runners/bookmarks/browserfactory.cpp R +37 -0 runners/bookmarks/browsers/browser.h [from: runners/bookmarks/browser.h - 060% similarity] M +4 -30 runners/bookmarks/browsers/chrome.cpp A +67 -0 runners/bookmarks/browsers/falkon.cpp [License: LGPL (v2+)] A +45 -0 runners/bookmarks/browsers/falkon.h [License: LGPL (v2+)] M +7 -0 runners/bookmarks/faviconfromblob.cpp M +1 -0 runners/bookmarks/faviconfromblob.h https://invent.kde.org/plasma/plasma-workspace/commit/bbed524a2cec1508522ee5a903cab504b9c0d5a6
Nice work Alexander!
(In reply to Alexander Lohnau from comment #13) > Git commit bbed524a2cec1508522ee5a903cab504b9c0d5a6 by Alexander Lohnau. > Committed on 15/07/2020 at 16:49. > Pushed by alex into branch 'master'. > > Add bookmarksrunner integration for Falkon > > M +1 -0 runners/bookmarks/CMakeLists.txt > M +1 -1 runners/bookmarks/bookmarksrunner.cpp > M +4 -1 runners/bookmarks/browserfactory.cpp > R +37 -0 runners/bookmarks/browsers/browser.h [from: > runners/bookmarks/browser.h - 060% similarity] > M +4 -30 runners/bookmarks/browsers/chrome.cpp > A +67 -0 runners/bookmarks/browsers/falkon.cpp [License: LGPL > (v2+)] > A +45 -0 runners/bookmarks/browsers/falkon.h [License: LGPL (v2+)] > M +7 -0 runners/bookmarks/faviconfromblob.cpp > M +1 -0 runners/bookmarks/faviconfromblob.h > > https://invent.kde.org/plasma/plasma-workspace/commit/ > bbed524a2cec1508522ee5a903cab504b9c0d5a6 Can this now be resolved?
It is done for the Bookmarks, but not for the Browser Tabs.