Bug 393527 - Speed Dial custom wallpaper doesn't get saved
Summary: Speed Dial custom wallpaper doesn't get saved
Status: RESOLVED FIXED
Alias: None
Product: Falkon
Classification: Applications
Component: general (other bugs)
Version First Reported In: unspecified
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: David Rosca
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-26 06:14 UTC by Korvin
Modified: 2018-04-26 08:45 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Korvin 2018-04-26 06:14:45 UTC
When I set a custom wallpaper in speed dial, it only stays there until I close the browser. When I start it up again, the speed dial has its default blue image. I tried JPG and PNG files, with and without non-letter characters, and also in various places in the file system.
I noticed that in the settings.ini file there's this part:

[FileDialogPaths]
SpeedDial-GetOpenFileName=

When I change the wallpaper, it changes to the folder where the picture's in. I don't know if that's the desired value or if it should hold the filename as well, but I did try inputting the filename after the path, but although it won't get replaced by Falkon, it doesn't work either.

The bug can be reproduced with a clean install on Windows 10 with version 3.0.0-62, and also on Arch Linux with its package in the extra repo. The onl difference is that in Arch, the wallpaper can sometimes be saved once for the first time, but it can't be modified after that.
Comment 1 Anmol Gautam 2018-04-26 08:12:29 UTC
Do you have dials on speed dial page, or its empty. If yes then this is fixed in 30f5cd2 https://cgit.kde.org/falkon.git/commit/?id=30f5cd2d7e406ec6aaea82dfdc44f3f52ea760c1
Comment 2 Anmol Gautam 2018-04-26 08:15:27 UTC
(In reply to Anmol Gautam from comment #1)
> Do you have dials on speed dial page, or its empty. If yes then this is
> fixed in 30f5cd2
> https://cgit.kde.org/falkon.git/commit/
> ?id=30f5cd2d7e406ec6aaea82dfdc44f3f52ea760c1

I mean if no dials, then it may be related to 30f5cd2
Comment 3 Korvin 2018-04-26 08:44:13 UTC
(In reply to Anmol Gautam from comment #2)
> (In reply to Anmol Gautam from comment #1)
> > Do you have dials on speed dial page, or its empty. If yes then this is
> > fixed in 30f5cd2
> > https://cgit.kde.org/falkon.git/commit/
> > ?id=30f5cd2d7e406ec6aaea82dfdc44f3f52ea760c1
> 
> I mean if no dials, then it may be related to 30f5cd2

Yep, that was the problem, I didn't have any pages yet. After I added one and closed the browser, the wallpaper still wasn't saved, but then I applied it again and closed the browser from the menu and now it remembers.