Bug 393424 - Proceed automatically to another cell after entering a value in a spreedsheet
Summary: Proceed automatically to another cell after entering a value in a spreedsheet
Status: RESOLVED FIXED
Alias: None
Product: LabPlot2
Classification: Applications
Component: general (other bugs)
Version First Reported In: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Alexander Semke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-23 12:29 UTC by urcindalo
Modified: 2018-05-07 10:18 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed/Implemented In: 2.5
Sentry Crash Report:


Attachments
cell focus change (133.05 KB, video/mp4)
2018-04-24 20:49 UTC, Alexander Semke
Details
Screen record (579.16 KB, video/x-matroska)
2018-05-06 08:58 UTC, urcindalo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description urcindalo 2018-04-23 12:29:55 UTC
I don't know if this is a bug or a feature request, but it would be really helpful if, after entering a value in a spreedsheet, the focus were put on the next cell (either down from it in the same column or to its right in the next column).
The current behavior forces the user to press an additional key or reach for the mouse to access it.
Comment 1 Alexander Semke 2018-04-23 16:10:17 UTC
This was fixed in the current code. In LabPlot 2.5 which will be released soon the focus is set to the next cell right to the current cell. You can compile from source if you want to try it out until the release is done.
Comment 2 urcindalo 2018-04-24 14:02:28 UTC
(In reply to Alexander Semke from comment #1)
> This was fixed in the current code. In LabPlot 2.5 which will be released
> soon the focus is set to the next cell right to the current cell. You can
> compile from source if you want to try it out until the release is done.

I just sync'ed and compiled five minutes ago, but I don't see the fix. Focus remains in the same cell after entering a value.

=====
...
 * Fetching https://anongit.kde.org/labplot ...
git fetch https://anongit.kde.org/labplot +HEAD:refs/git-r3/HEAD
remote: Counting objects: 6, done.
remote: Compressing objects: 100% (6/6), done.
remote: Total 6 (delta 5), reused 0 (delta 0)
Unpacking objects: 100% (6/6), done.
From https://anongit.kde.org/labplot
   f34c8840..a23a99c1             -> refs/git-r3/HEAD
git symbolic-ref refs/git-r3/sci-visualization/labplot/5/__main__ refs/git-r3/HEAD
 * Checking out https://anongit.kde.org/labplot to /var/tmp/portage/sci-visualization/labplot-9999/work/labplot-9999 ...
git checkout --quiet refs/git-r3/HEAD
GIT update -->
   repository:               https://anongit.kde.org/labplot
   updating from commit:     f34c8840218fd59b41e6dbc4ca6d5753aa8565c7
   to commit:                a23a99c14446e8ac615215e8ee60aabe9fc86f52
 src/kdefrontend/widgets/ResizableTextEdit.cpp | 1 +
 1 file changed, 1 insertion(+)
...
=====
Comment 3 Alexander Semke 2018-04-24 20:47:58 UTC
(In reply to urcindalo from comment #2)
> I just sync'ed and compiled five minutes ago, but I don't see the fix. Focus
> remains in the same cell after entering a value.
Do you really used the binary you compiled or do you maybe still use the executable that was previously installed? I attached a small video showing the current behavior in LabPlot. Can you please check once more on your side?
Comment 4 Alexander Semke 2018-04-24 20:49:44 UTC
Created attachment 112223 [details]
cell focus change
Comment 5 urcindalo 2018-04-25 08:17:45 UTC
(In reply to Alexander Semke from comment #3)
> (In reply to urcindalo from comment #2)
> > I just sync'ed and compiled five minutes ago, but I don't see the fix. Focus
> > remains in the same cell after entering a value.
> Do you really used the binary you compiled or do you maybe still use the
> executable that was previously installed? I attached a small video showing
> the current behavior in LabPlot. Can you please check once more on your side?

Thanks for your efforts.
In order to be sure, I completely uninstalled labplot from my box, which also removed its dependencies (Gentoo Linux here). Then, I reinstalled it (from source, this is Gentoo). Alas, I still get no focus on next cell.

Let me remind you in other bugs it was only a matter of reinstalling labplot to see if fixed.

Might it is locale related? I use commas for decimal separators and my system language is set to Spanish.

Maybe the commit does not appear on the server?
Comment 6 Alexander Semke 2018-05-05 16:41:28 UTC
(In reply to urcindalo from comment #5)
> (In reply to Alexander Semke from comment #3)
> > (In reply to urcindalo from comment #2)
> > > I just sync'ed and compiled five minutes ago, but I don't see the fix. Focus
> > > remains in the same cell after entering a value.
> > Do you really used the binary you compiled or do you maybe still use the
> > executable that was previously installed? I attached a small video showing
> > the current behavior in LabPlot. Can you please check once more on your side?
> 
> Thanks for your efforts.
> In order to be sure, I completely uninstalled labplot from my box, which
> also removed its dependencies (Gentoo Linux here). Then, I reinstalled it
> (from source, this is Gentoo). Alas, I still get no focus on next cell.
> 
> Let me remind you in other bugs it was only a matter of reinstalling labplot
> to see if fixed.
> 
> Might it is locale related? I use commas for decimal separators and my
> system language is set to Spanish.
> 
> Maybe the commit does not appear on the server?
The code you compiled must have the fix for this. Setting of the focus is not related to the locale - I also use comma as the separator (German settings). 

Just to make sure you're really using the current code, you compiled the commit    23a99c14446e8ac615215e8ee60aabe9fc86f52 which has a change on ResizableTextEdit.cpp. If you start LabPlot and select a spreadsheet, is the comment text box in the properties dock widget resizable for your? There must be a small grab bar at the bottom of the text field. Do you have this? If yes, then you're using the current code. In this case, would it be feasible for you to record a small video ( SimpleScreenRecorder does the job very well) showing this problem on your side?
Can you do a small video of
Comment 7 urcindalo 2018-05-06 08:58:58 UTC
Created attachment 112435 [details]
Screen record

Thanks again.
I just sync'ed again a few minutes ago (in the next message I'll show the beginning of the compilation). As you can see, according to the resizable comment field I'm using the proper code, but I still get no focusing in the next cell.
Comment 8 urcindalo 2018-05-06 09:00:20 UTC
Begenning of today's compilation:
====
[ebuild   R   *] sci-visualization/labplot-9999:5::gentoo  USE="cantor fftw fits handbook hdf5 netcdf -debug" 0 KiB

Total: 1 package (1 reinstall), Size of downloads: 0 KiB

Would you like to merge these packages? [Yes/No] Y

>>> Verifying ebuild manifests

>>> Emerging (1 of 1) sci-visualization/labplot-9999::gentoo
>>> Unpacking source...
 * Fetching https://anongit.kde.org/labplot ...
git fetch https://anongit.kde.org/labplot +HEAD:refs/git-r3/HEAD
remote: Counting objects: 339, done.
remote: Compressing objects: 100% (339/339), done.
Receiving objects: 100% (339/339), 55.40 KiB | 2.05 MiB/s, done.
remote: Total 339 (delta 304), reused 0 (delta 0)
Resolving deltas: 100% (304/304), completed with 123 local objects.
From https://anongit.kde.org/labplot
   7d5087ae..1eef2517             -> refs/git-r3/HEAD
git symbolic-ref refs/git-r3/sci-visualization/labplot/5/__main__ refs/git-r3/HEAD
 * Checking out https://anongit.kde.org/labplot to /var/tmp/portage/sci-visualization/labplot-9999/work/labplot-9999 ...
git checkout --quiet refs/git-r3/HEAD
GIT update -->
   repository:               https://anongit.kde.org/labplot
   updating from commit:     7d5087ae1da051eabe4de00e5811e4f6b9cf223c
   to commit:                1eef2517ccf603a61d0c3198425c3d46503fb06a
 compile_macos                                                           |  11 ++++--
 compile_macos_debug                                                     |  11 ++++--
 create-dmg.sh                                                           |  89 +++++++++++++++++++++++++++++++++++++++++++++++
 liborigin/OriginAnyParser.cpp                                           |   5 ++-
 liborigin/OriginObj.h                                                   |  92 +++++++++++++++++++++++++++++++++++++++++++++----
 org.kde.labplot2.appdata.xml                                            |   2 +-
 src/backend/core/AbstractColumn.cpp                                     |  12 +++----
 src/backend/core/AbstractColumn.h                                       |  16 ++++-----
 src/backend/core/AbstractSimpleFilter.cpp                               |   2 +-                                                                     
 src/backend/core/AbstractSimpleFilter.h                                 |   2 +-                                                                     
 src/backend/core/column/Column.cpp                                      |   8 ++---                                                                  
 src/backend/core/column/Column.h                                        |   8 ++---                                                                  
 src/backend/core/column/ColumnPrivate.cpp                               |   8 +++--                                                                  
 src/backend/core/column/ColumnPrivate.h                                 |   6 ++--                                                                   
 src/backend/core/column/columncommands.cpp                              |  21 +++++++-----                                                           
 src/backend/core/column/columncommands.h                                |   2 +-                                                                     
 src/backend/core/datatypes/DateTime2StringFilter.h                      |   2 +-                                                                     
 src/backend/core/datatypes/String2DateTimeFilter.h                      |   2 +-                                                                     
 src/backend/core/datatypes/String2DoubleFilter.h                        |   2 +-                                                                     
 src/backend/core/datatypes/String2IntegerFilter.h                       |   2 +-                                                                     
 src/backend/datapicker/Datapicker.cpp                                   |   1 +                                                                      
 src/backend/datapicker/DatapickerCurve.cpp                              |   4 +--                                                                    
 src/backend/datapicker/DatapickerCurve.h                                |   4 +--                                                                    
 src/backend/datapicker/DatapickerPoint.h                                |  10 +++---                                                                 
 src/backend/datasources/filters/AsciiFilter.cpp                         |   2 +-                                                                     
 src/backend/datasources/filters/AsciiFilter.h                           |   2 +-                                                                     
 src/backend/datasources/filters/FITSFilter.cpp                          |   2 +-
 src/backend/datasources/filters/HDF5Filter.cpp                          |   4 +--
 src/backend/datasources/filters/HDF5Filter.h                            |   2 +-
 src/backend/datasources/filters/HDF5FilterPrivate.h                     |   2 +-
 src/backend/datasources/filters/NetCDFFilter.cpp                        |   4 +--
 src/backend/datasources/filters/NetCDFFilter.h                          |   2 +-
 src/backend/datasources/filters/NetCDFFilterPrivate.h                   |   2 +-
 src/backend/datasources/projects/OriginProjectParser.cpp                |  21 +++++-------
 src/backend/datasources/projects/OriginProjectParser.h                  |  22 ++++++------
 src/backend/lib/IntervalAttribute.h                                     |   6 ++--
 src/backend/lib/PropertyChangeCommand.h                                 |  51 ++++++++++++++++++---------
 src/backend/worksheet/TextLabel.cpp                                     |   4 +--
 src/backend/worksheet/TextLabel.h                                       |   2 +-
 src/backend/worksheet/TextLabelPrivate.h                                |   2 +-
 src/backend/worksheet/WorksheetElementContainer.cpp                     |   7 ++--
 src/backend/worksheet/plots/AbstractCoordinateSystem.h                  |  10 +++---
 src/backend/worksheet/plots/cartesian/Axis.cpp                          |   2 +-
 src/backend/worksheet/plots/cartesian/AxisPrivate.h                     |   2 +-
 src/backend/worksheet/plots/cartesian/CartesianCoordinateSystem.cpp     |  14 ++++----
 src/backend/worksheet/plots/cartesian/CartesianCoordinateSystem.h       |  14 ++++----
 src/backend/worksheet/plots/cartesian/XYCurve.cpp                       |   4 +--
 src/backend/worksheet/plots/cartesian/XYFitCurve.cpp                    | 131 +++++++++++++++++++++++++++++++++++++---------------------------------
 src/backend/worksheet/plots/cartesian/XYFitCurve.h                      |  15 ++++----
 src/commonfrontend/datapicker/DatapickerView.cpp                        |   2 +-
 src/commonfrontend/datapicker/DatapickerView.h                          |   2 +-
 src/commonfrontend/note/NoteView.cpp                                    |   6 ++--
 src/commonfrontend/note/NoteView.h                                      |  29 ++++++++--------
 src/commonfrontend/workbook/WorkbookView.cpp                            |   2 +-
 src/commonfrontend/workbook/WorkbookView.h                              |   2 +-
 src/commonfrontend/worksheet/WorksheetView.cpp                          |   4 +--
 src/commonfrontend/worksheet/WorksheetView.h                            |   4 +--
 src/kdefrontend/GuiObserver.cpp                                         |   2 +-
 src/kdefrontend/GuiObserver.h                                           |   4 ---
 src/kdefrontend/MainWin.cpp                                             |   2 +-
 src/kdefrontend/TemplateHandler.cpp                                     |   8 ++---
 src/kdefrontend/ThemeHandler.cpp                                        |   6 ++--
 src/kdefrontend/ThemeHandler.h                                          |   2 +-
 src/kdefrontend/datasources/FileInfoDialog.cpp                          |   2 +-
 src/kdefrontend/dockwidgets/AxisDock.cpp                                |   4 +--
 src/kdefrontend/dockwidgets/CantorWorksheetDock.cpp                     |   4 +--
 src/kdefrontend/dockwidgets/CartesianPlotDock.cpp                       |   4 +--
 src/kdefrontend/dockwidgets/CartesianPlotLegendDock.cpp                 |   4 +--
 src/kdefrontend/dockwidgets/ColumnDock.cpp                              |   4 +--
 src/kdefrontend/dockwidgets/CustomPointDock.cpp                         |   8 ++---
 src/kdefrontend/dockwidgets/CustomPointDock.h                           |   4 +--
 src/kdefrontend/dockwidgets/HistogramDock.cpp                           |  10 +++---
 src/kdefrontend/dockwidgets/HistogramDock.h                             |   6 ++--
 src/kdefrontend/dockwidgets/LiveDataDock.cpp                            |   2 +-
 src/kdefrontend/dockwidgets/LiveDataDock.h                              |   2 +-
 src/kdefrontend/dockwidgets/MatrixDock.cpp                              |   4 +--
 src/kdefrontend/dockwidgets/NoteDock.cpp                                |   4 +--
 src/kdefrontend/dockwidgets/SpreadsheetDock.cpp                         |   2 +-
 src/kdefrontend/dockwidgets/WorksheetDock.cpp                           |   4 +--
 src/kdefrontend/dockwidgets/XYCurveDock.cpp                             |  12 +++----
 src/kdefrontend/dockwidgets/XYCurveDock.h                               |   8 ++---
 src/kdefrontend/dockwidgets/XYDataReductionCurveDock.cpp                |   9 +++--
 src/kdefrontend/dockwidgets/XYDifferentiationCurveDock.cpp              |   7 ++--
 src/kdefrontend/dockwidgets/XYEquationCurveDock.cpp                     |   4 +--
 src/kdefrontend/dockwidgets/XYFitCurveDock.cpp                          |  26 +++++++-------
 src/kdefrontend/dockwidgets/XYFitCurveDock.h                            |   6 ++--
 src/kdefrontend/dockwidgets/XYFourierFilterCurveDock.cpp                |   7 ++--
 src/kdefrontend/dockwidgets/XYFourierTransformCurveDock.cpp             |   7 ++--
 src/kdefrontend/dockwidgets/XYIntegrationCurveDock.cpp                  |   7 ++--
 src/kdefrontend/dockwidgets/XYInterpolationCurveDock.cpp                |   7 ++--
 src/kdefrontend/dockwidgets/XYSmoothCurveDock.cpp                       |   7 ++--
 src/kdefrontend/spreadsheet/EquidistantValuesDialog.cpp                 |   2 +-
 src/kdefrontend/spreadsheet/EquidistantValuesDialog.h                   |   2 +-
 src/kdefrontend/ui/datapickerimagewidget.ui                             |  48 +++++++++++++-------------
 src/kdefrontend/ui/dockwidgets/xydatareductioncurvedockgeneraltab.ui    |  18 ----------
 src/kdefrontend/ui/dockwidgets/xydifferentiationcurvedockgeneraltab.ui  |  12 -------
 src/kdefrontend/ui/dockwidgets/xyfourierfiltercurvedockgeneraltab.ui    |   9 -----
 src/kdefrontend/ui/dockwidgets/xyfouriertransformcurvedockgeneraltab.ui |  12 -------
 src/kdefrontend/ui/dockwidgets/xyintegrationcurvedockgeneraltab.ui      |  12 -------
 src/kdefrontend/ui/dockwidgets/xyinterpolationcurvedockgeneraltab.ui    |  12 -------
 src/kdefrontend/ui/dockwidgets/xysmoothcurvedockgeneraltab.ui           |  12 -------
 src/kdefrontend/ui/fitoptionswidget.ui                                  | 131 +++++++++++++++++++++++++++++++++++++++++++---------------------------
 src/kdefrontend/widgets/DatapickerCurveWidget.cpp                       |   8 ++---
 src/kdefrontend/widgets/DatapickerCurveWidget.h                         |   4 +--
 src/kdefrontend/widgets/DatapickerImageWidget.cpp                       | 126 +++++++++++++++++++++++++++++++++----------------------------------
 src/kdefrontend/widgets/DatapickerImageWidget.h                         |   2 +-
 src/kdefrontend/widgets/FitOptionsWidget.cpp                            |  75 +++++++++++++++++++++++++++++++++-------
 src/kdefrontend/widgets/FitOptionsWidget.h                              |   9 +++--
 src/kdefrontend/widgets/ResizableTextEdit.cpp                           |   2 +-
 src/kdefrontend/widgets/ResizableTextEdit.h                             |   6 ++--
 src/tools/ImageTools.cpp                                                |   2 +-
 src/tools/ImageTools.h                                                  |   2 +-
 112 files changed, 820 insertions(+), 587 deletions(-)
>>> Source unpacked in /var/tmp/portage/sci-visualization/labplot-9999/work
>>> Preparing source in /var/tmp/portage/sci-visualization/labplot-9999/work/labplot-9999 ...
>>> Source prepared.
=====
Comment 9 urcindalo 2018-05-06 09:02:23 UTC
Also, I launched labplot from the command line and exited with Control+Q. No issues found:
=====
~ $ labplot2
dir:  "/usr/lib64/kde4/plugins/cantor/backends"
dir:  "/usr/lib64/qt5/plugins/cantor/backends"
Creating MaximaBackend
Creating NullBackend
Creating SageBackend
Creating ScilabBackend
dir:  "/usr/bin/cantor/backends"
~ $
Comment 10 Alexander Semke 2018-05-06 18:04:17 UTC
(In reply to urcindalo from comment #7)
> I just sync'ed again a few minutes ago (in the next message I'll show the
> beginning of the compilation). As you can see, according to the resizable
> comment field I'm using the proper code, but I still get no focusing in the
> next cell.

I just pushed a small fix. Can you please fetch the current code and try again?
Comment 11 urcindalo 2018-05-07 06:47:28 UTC
(In reply to Alexander Semke from comment #10)
> (In reply to urcindalo from comment #7)
> > I just sync'ed again a few minutes ago (in the next message I'll show the
> > beginning of the compilation). As you can see, according to the resizable
> > comment field I'm using the proper code, but I still get no focusing in the
> > next cell.
> 
> I just pushed a small fix. Can you please fetch the current code and try
> again?

IT WORKS!
Thanks again. I really appreciate your hard and excellent work.
Comment 12 Alexander Semke 2018-05-07 10:18:16 UTC
(In reply to urcindalo from comment #11)
> IT WORKS!
> Thanks again. I really appreciate your hard and excellent work.
Thanks for the confirmation and for the kind words :-)