Bug 393412 - Dolphin fails to build with disabled support for Baloo
Summary: Dolphin fails to build with disabled support for Baloo
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: panels: information (show other bugs)
Version: unspecified
Platform: Gentoo Packages All
: NOR normal
Target Milestone: ---
Assignee: Michael Heidelbach
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-22 23:42 UTC by Arfrever Frehtes Taifersar Arahesis
Modified: 2018-05-13 20:29 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis 2018-04-22 23:42:27 UTC
Since https://cgit.kde.org/dolphin.git/commit/?id=7d463ddd04bf052650843ff8523b36789c48733b Dolphin fails to build with disabled support for Baloo.

src/panels/information/informationpanelcontent.cpp contains some '#ifndef HAVE_BALOO' checks.
More checks need to be added to fix compilation.

Output of compiler:

/var/tmp/portage/kde-apps/dolphin-9999/work/dolphin-9999/src/panels/information/informationpanelcontent.cpp: In constructor ‘InformationPanelContent::InformationPanelContent(QWidget*)’:
/var/tmp/portage/kde-apps/dolphin-9999/work/dolphin-9999/src/panels/information/informationpanelcontent.cpp:110:28: warning: ‘KFileMetaDataWidget’ is deprecated [-Wdeprecated-declarations]
     m_metaDataWidget = new KFileMetaDataWidget(parent);
                            ^~~~~~~~~~~~~~~~~~~
In file included from /usr/include/KF5/KDELibs4Support/KDE/KFileMetaDataWidget:1:0,
                 from /var/tmp/portage/kde-apps/dolphin-9999/work/dolphin-9999/src/panels/information/informationpanelcontent.cpp:36:
/usr/include/KF5/KDELibs4Support/kfilemetadatawidget.h:44:41: note: declared here
 class KDELIBS4SUPPORT_DEPRECATED_EXPORT KFileMetaDataWidget : public QWidget
                                         ^~~~~~~~~~~~~~~~~~~
/var/tmp/portage/kde-apps/dolphin-9999/work/dolphin-9999/src/panels/information/informationpanelcontent.cpp:110:54: warning: ‘KFileMetaDataWidget::KFileMetaDataWidget(QWidget*)’ is deprecated [-Wdeprecated-declarations]
     m_metaDataWidget = new KFileMetaDataWidget(parent);
                                                      ^
In file included from /usr/include/KF5/KDELibs4Support/KDE/KFileMetaDataWidget:1:0,
                 from /var/tmp/portage/kde-apps/dolphin-9999/work/dolphin-9999/src/panels/information/informationpanelcontent.cpp:36:
/usr/include/KF5/KDELibs4Support/kfilemetadatawidget.h:50:41: note: declared here
     KDELIBS4SUPPORT_DEPRECATED explicit KFileMetaDataWidget(QWidget *parent = nullptr);
                                         ^~~~~~~~~~~~~~~~~~~
/var/tmp/portage/kde-apps/dolphin-9999/work/dolphin-9999/src/panels/information/informationpanelcontent.cpp:120:23: error: ‘class KFileMetaDataWidget’ has no member named ‘setDateFormat’
     m_metaDataWidget->setDateFormat(static_cast<Baloo::DateFormats>(InformationPanelSettings::dateFormat()));
                       ^~~~~~~~~~~~~
/var/tmp/portage/kde-apps/dolphin-9999/work/dolphin-9999/src/panels/information/informationpanelcontent.cpp:120:49: error: ‘Baloo’ does not name a type; did you mean ‘valloc’?
     m_metaDataWidget->setDateFormat(static_cast<Baloo::DateFormats>(InformationPanelSettings::dateFormat()));
                                                 ^~~~~
                                                 valloc
/var/tmp/portage/kde-apps/dolphin-9999/work/dolphin-9999/src/panels/information/informationpanelcontent.cpp:120:54: error: expected ‘>’ before ‘::’ token
     m_metaDataWidget->setDateFormat(static_cast<Baloo::DateFormats>(InformationPanelSettings::dateFormat()));
                                                      ^~
/var/tmp/portage/kde-apps/dolphin-9999/work/dolphin-9999/src/panels/information/informationpanelcontent.cpp:120:54: error: expected ‘(’ before ‘::’ token
/var/tmp/portage/kde-apps/dolphin-9999/work/dolphin-9999/src/panels/information/informationpanelcontent.cpp:120:56: error: ‘::DateFormats’ has not been declared
     m_metaDataWidget->setDateFormat(static_cast<Baloo::DateFormats>(InformationPanelSettings::dateFormat()));
                                                        ^~~~~~~~~~~
/var/tmp/portage/kde-apps/dolphin-9999/work/dolphin-9999/src/panels/information/informationpanelcontent.cpp:120:56: note: suggested alternative: ‘QPixelFormat’
     m_metaDataWidget->setDateFormat(static_cast<Baloo::DateFormats>(InformationPanelSettings::dateFormat()));
                                                        ^~~~~~~~~~~
                                                        QPixelFormat
/var/tmp/portage/kde-apps/dolphin-9999/work/dolphin-9999/src/panels/information/informationpanelcontent.cpp: In member function ‘void InformationPanelContent::showItem(const KFileItem&)’:
/var/tmp/portage/kde-apps/dolphin-9999/work/dolphin-9999/src/panels/information/informationpanelcontent.cpp:197:27: error: ‘class KFileMetaDataWidget’ has no member named ‘setDateFormat’
         m_metaDataWidget->setDateFormat(static_cast<Baloo::DateFormats>(InformationPanelSettings::dateFormat()));
                           ^~~~~~~~~~~~~
/var/tmp/portage/kde-apps/dolphin-9999/work/dolphin-9999/src/panels/information/informationpanelcontent.cpp:197:53: error: ‘Baloo’ does not name a type; did you mean ‘valloc’?
         m_metaDataWidget->setDateFormat(static_cast<Baloo::DateFormats>(InformationPanelSettings::dateFormat()));
                                                     ^~~~~
                                                     valloc
/var/tmp/portage/kde-apps/dolphin-9999/work/dolphin-9999/src/panels/information/informationpanelcontent.cpp:197:58: error: expected ‘>’ before ‘::’ token
         m_metaDataWidget->setDateFormat(static_cast<Baloo::DateFormats>(InformationPanelSettings::dateFormat()));
                                                          ^~
/var/tmp/portage/kde-apps/dolphin-9999/work/dolphin-9999/src/panels/information/informationpanelcontent.cpp:197:58: error: expected ‘(’ before ‘::’ token
/var/tmp/portage/kde-apps/dolphin-9999/work/dolphin-9999/src/panels/information/informationpanelcontent.cpp:197:60: error: ‘::DateFormats’ has not been declared
         m_metaDataWidget->setDateFormat(static_cast<Baloo::DateFormats>(InformationPanelSettings::dateFormat()));
                                                            ^~~~~~~~~~~
/var/tmp/portage/kde-apps/dolphin-9999/work/dolphin-9999/src/panels/information/informationpanelcontent.cpp:197:60: note: suggested alternative: ‘QPixelFormat’
         m_metaDataWidget->setDateFormat(static_cast<Baloo::DateFormats>(InformationPanelSettings::dateFormat()));
                                                            ^~~~~~~~~~~
                                                            QPixelFormat
/var/tmp/portage/kde-apps/dolphin-9999/work/dolphin-9999/src/panels/information/informationpanelcontent.cpp: In member function ‘void InformationPanelContent::configureSettings(const QList<QAction*>&)’:
/var/tmp/portage/kde-apps/dolphin-9999/work/dolphin-9999/src/panels/information/informationpanelcontent.cpp:289:93: error: ‘Baloo’ has not been declared
     dateformatAction->setChecked(InformationPanelSettings::dateFormat() == static_cast<int>(Baloo::DateFormats::ShortFormat));
                                                                                             ^~~~~
/var/tmp/portage/kde-apps/dolphin-9999/work/dolphin-9999/src/panels/information/informationpanelcontent.cpp:307:55: error: ‘Baloo’ has not been declared
         int dateFormat = static_cast<int>(isChecked ? Baloo::DateFormats::ShortFormat : Baloo::DateFormats::LongFormat);
                                                       ^~~~~
/var/tmp/portage/kde-apps/dolphin-9999/work/dolphin-9999/src/panels/information/informationpanelcontent.cpp:307:89: error: ‘Baloo’ has not been declared
         int dateFormat = static_cast<int>(isChecked ? Baloo::DateFormats::ShortFormat : Baloo::DateFormats::LongFormat);
                                                                                         ^~~~~
Comment 1 Kai Uwe Broulik 2018-04-23 10:30:12 UTC
Michael, can you have a look at this?
Comment 2 Shivang Saxena 2018-05-11 15:58:29 UTC
Just wanted to add that I can reproduce this bug on my Arch Linux machine as well (the bug is listed under "Gentoo Packages").

I will try to see if I can resolve this on my machine and then perhaps post a patch? It will be my first commit so I"m not sure if I will be able to resolve it on my own but I will try!
Comment 3 Shivang Saxena 2018-05-11 16:37:35 UTC
(In reply to Shivang Saxena from comment #2)
> Just wanted to add that I can reproduce this bug on my Arch Linux machine as
> well (the bug is listed under "Gentoo Packages").
> 
> I will try to see if I can resolve this on my machine and then perhaps post
> a patch? It will be my first commit so I"m not sure if I will be able to
> resolve it on my own but I will try!

In addition, I have Baloo installed and enabled on my machine and I still cannot build:

[shivang@shivang build]$ cmake -DCMAKE_INSTALL_PREFIX=/opt/kde/ ..
-- Found KF5: success (found suitable version "5.45.0", minimum required is "5.43.0") found components:  DocTools Init KCMUtils NewStuff CoreAddons I18n DBusAddons Bookmarks Config KIO Parts Solid IconThemes Completion TextWidgets Notifications Crash 
-- Found KF5: success (found suitable version "5.45.0", minimum required is "5.43.0") found components:  Activities 
-- Baloo packages are found
-- The following OPTIONAL packages have been found:

 * KF5Activities (required version >= 5.43.0)
 * KF5Baloo (required version >= 4.97), Baloo Core libraries, <http://www.kde.org>
   For adding desktop-wide search and tagging support to dolphin
 * KF5BalooWidgets (required version >= 4.97), Baloos Widgets, <http://www.kde.org>
 * KF5FileMetaData (required version >= 5.19.0), <https://projects.kde.org/kfilemetadata>
   For accessing file metadata labels
Comment 4 Christoph Feck 2018-05-11 17:59:47 UTC
Comment #3 does not show any error; we would need the full cmake and make log to spot the first error, but I suggest to use a developer mailing list to discuss build issues.
Comment 5 Shivang Saxena 2018-05-11 18:33:21 UTC
Comment #4, I don't believe this is a build issue on my machine, here is why:

It passes all the cmake checks and confirms that baloo-widgets >= 4.97 is installed (so it sets 'HAVE_BALOO' to 'true'). But after calling `make`, you can see in the build log below that it cannot compile because:

error: class Baloo::FileMetaDataWidget' has no member named 'setDateFormat'


After checking baloo-widgets.git I can see setDateFormat it was added in this commit:

https://cgit.kde.org/baloo-widgets.git/commit/?id=63965a70dee80b22b95661e8b0145c93f0849acc

So I believe the issue, as OP was saying, is that line 120 in informationpanelcontent.cpp is calling ->setDateFormat() which doesn't exist in older version of baloo-widgets. So it should wrap that around in an ifndef check like it does right before it? And then perhaps bump up the minimum baloo-widgets version?

I'm not knowledgeable enough to modify this, but this is what I discovered through my research. I would love to help in any other way that I can.



[shivang@shivang build]$ cmake -DCMAKE_INSTALL_PREFIX=/opt/kde/ ..
-- The C compiler identification is GNU 7.3.1
-- The CXX compiler identification is GNU 7.3.1
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Looking for __GLIBC__
-- Looking for __GLIBC__ - found
-- Performing Test _OFFT_IS_64BIT
-- Performing Test _OFFT_IS_64BIT - Success
-- Performing Test HAVE_DATE_TIME
-- Performing Test HAVE_DATE_TIME - Success
-- Found KF5DocTools: /usr/lib64/cmake/KF5DocTools/KF5DocToolsConfig.cmake (found version "5.45.0") 
-- Found KF5Init: /usr/lib64/cmake/KF5Init/KF5InitConfig.cmake (found version "5.45.0") 
-- Found KF5KCMUtils: /usr/lib64/cmake/KF5KCMUtils/KF5KCMUtilsConfig.cmake (found version "5.45.0") 
-- Found KF5NewStuff: /usr/lib64/cmake/KF5NewStuff/KF5NewStuffConfig.cmake (found version "5.45.0") 
-- Found KF5CoreAddons: /usr/lib64/cmake/KF5CoreAddons/KF5CoreAddonsConfig.cmake (found version "5.45.0") 
-- Found Gettext: /usr/bin/msgmerge (found version "0.19.8.1") 
-- Found KF5I18n: /usr/lib64/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.45.0") 
-- Found KF5DBusAddons: /usr/lib64/cmake/KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version "5.45.0") 
-- Found KF5Bookmarks: /usr/lib64/cmake/KF5Bookmarks/KF5BookmarksConfig.cmake (found version "5.45.0") 
-- Found KF5Config: /usr/lib64/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.45.0") 
-- Found KF5KIO: /usr/lib64/cmake/KF5KIO/KF5KIOConfig.cmake (found version "5.45.0") 
-- Found KF5Parts: /usr/lib64/cmake/KF5Parts/KF5PartsConfig.cmake (found version "5.45.0") 
-- Found KF5Solid: /usr/lib64/cmake/KF5Solid/KF5SolidConfig.cmake (found version "5.45.0") 
-- Found KF5IconThemes: /usr/lib64/cmake/KF5IconThemes/KF5IconThemesConfig.cmake (found version "5.45.0") 
-- Found KF5Completion: /usr/lib64/cmake/KF5Completion/KF5CompletionConfig.cmake (found version "5.45.0") 
-- Found KF5TextWidgets: /usr/lib64/cmake/KF5TextWidgets/KF5TextWidgetsConfig.cmake (found version "5.45.0") 
-- Found KF5Notifications: /usr/lib64/cmake/KF5Notifications/KF5NotificationsConfig.cmake (found version "5.45.0") 
-- Found KF5Crash: /usr/lib64/cmake/KF5Crash/KF5CrashConfig.cmake (found version "5.45.0") 
-- Found KF5: success (found suitable version "5.45.0", minimum required is "5.43.0") found components:  DocTools Init KCMUtils NewStuff CoreAddons I18n DBusAddons Bookmarks Config KIO Parts Solid IconThemes Completion TextWidgets Notifications Crash 
-- Found KF5Activities: /usr/lib64/cmake/KF5Activities/KF5ActivitiesConfig.cmake (found version "5.45.0") 
-- Found KF5: success (found suitable version "5.45.0", minimum required is "5.43.0") found components:  Activities 
-- Baloo packages are found
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success
-- The following OPTIONAL packages have been found:

 * KF5Activities (required version >= 5.43.0)
 * KF5Baloo (required version >= 4.97), Baloo Core libraries, <http://www.kde.org>
   For adding desktop-wide search and tagging support to dolphin
 * KF5BalooWidgets (required version >= 4.97), Baloos Widgets, <http://www.kde.org>
 * KF5FileMetaData (required version >= 5.19.0), <https://projects.kde.org/kfilemetadata>
   For accessing file metadata labels

-- The following REQUIRED packages have been found:

 * ECM (required version >= 5.43.0)
 * Qt5Core
 * Qt5Concurrent
 * Qt5Widgets
 * Qt5Gui
 * Qt5DBus
 * Qt5 (required version >= 5.8.0)
 * KF5DocTools (required version >= 5.43.0)
 * KF5Init (required version >= 5.43.0)
 * KF5KCMUtils (required version >= 5.43.0)
 * KF5NewStuff (required version >= 5.43.0)
 * KF5CoreAddons (required version >= 5.43.0)
 * Gettext
 * KF5I18n (required version >= 5.43.0)
 * KF5DBusAddons (required version >= 5.43.0)
 * KF5Bookmarks (required version >= 5.43.0)
 * KF5Config (required version >= 5.43.0)
 * KF5KIO (required version >= 5.43.0)
 * KF5Parts (required version >= 5.43.0)
 * KF5Solid (required version >= 5.43.0)
 * KF5IconThemes (required version >= 5.43.0)
 * KF5Completion (required version >= 5.43.0)
 * KF5TextWidgets (required version >= 5.43.0)
 * KF5Notifications (required version >= 5.43.0)
 * KF5Crash (required version >= 5.43.0)
 * KF5 (required version >= 5.43.0)
 * Phonon4Qt5
 * Qt5Test

-- Configuring done
-- Generating done
-- Build files have been written to: /home/shivang/oss/kde/dolphin/build
[shivang@shivang build]$ build
bash: build: command not found
[shivang@shivang build]$ make
Scanning dependencies of target dolphinvcs_autogen
[  0%] Automatic MOC for target dolphinvcs
[  0%] Built target dolphinvcs_autogen
Scanning dependencies of target dolphinvcs
[  0%] Building CXX object src/CMakeFiles/dolphinvcs.dir/views/versioncontrol/kversioncontrolplugin.cpp.o
[  0%] Building CXX object src/CMakeFiles/dolphinvcs.dir/dolphinvcs_autogen/mocs_compilation.cpp.o
[  1%] Linking CXX shared library ../bin/libdolphinvcs.so
[  1%] Built target dolphinvcs
Scanning dependencies of target dolphinprivate_autogen
[  2%] Automatic MOC for target dolphinprivate
[  2%] Built target dolphinprivate_autogen
[  2%] Generating dolphin_versioncontrolsettings.h, dolphin_versioncontrolsettings.cpp
[  2%] Generating dolphin_compactmodesettings.h, dolphin_compactmodesettings.cpp
[  3%] Generating dolphin_compactmodesettings.moc
/home/shivang/oss/kde/dolphin/build/src/dolphin_compactmodesettings.h:0: Note: No relevant classes found. No output generated.
[  4%] Generating dolphin_directoryviewpropertysettings.h, dolphin_directoryviewpropertysettings.cpp
[  4%] Generating dolphin_directoryviewpropertysettings.moc
/home/shivang/oss/kde/dolphin/build/src/dolphin_directoryviewpropertysettings.h:0: Note: No relevant classes found. No output generated.
[  4%] Generating dolphin_detailsmodesettings.h, dolphin_detailsmodesettings.cpp
[  4%] Generating dolphin_detailsmodesettings.moc
/home/shivang/oss/kde/dolphin/build/src/dolphin_detailsmodesettings.h:0: Note: No relevant classes found. No output generated.
[  4%] Generating dolphin_iconsmodesettings.h, dolphin_iconsmodesettings.cpp
[  5%] Generating dolphin_iconsmodesettings.moc
/home/shivang/oss/kde/dolphin/build/src/dolphin_iconsmodesettings.h:0: Note: No relevant classes found. No output generated.
[  6%] Generating dolphin_generalsettings.h, dolphin_generalsettings.cpp
[  6%] Generating dolphin_generalsettings.moc
[  6%] Generating dolphin_versioncontrolsettings.moc
/home/shivang/oss/kde/dolphin/build/src/dolphin_versioncontrolsettings.h:0: Note: No relevant classes found. No output generated.
Scanning dependencies of target dolphinprivate
[  6%] Building CXX object src/CMakeFiles/dolphinprivate.dir/kitemviews/kfileitemlistview.cpp.o
[  7%] Building CXX object src/CMakeFiles/dolphinprivate.dir/kitemviews/kfileitemlistwidget.cpp.o
[  7%] Building CXX object src/CMakeFiles/dolphinprivate.dir/kitemviews/kfileitemmodel.cpp.o
[  7%] Building CXX object src/CMakeFiles/dolphinprivate.dir/kitemviews/kfileitemmodelrolesupdater.cpp.o
[  8%] Building CXX object src/CMakeFiles/dolphinprivate.dir/kitemviews/kitemlistcontainer.cpp.o
[  8%] Building CXX object src/CMakeFiles/dolphinprivate.dir/kitemviews/kitemlistcontroller.cpp.o
[  8%] Building CXX object src/CMakeFiles/dolphinprivate.dir/kitemviews/kitemlistgroupheader.cpp.o
[  9%] Building CXX object src/CMakeFiles/dolphinprivate.dir/kitemviews/kitemlistheader.cpp.o
[  9%] Building CXX object src/CMakeFiles/dolphinprivate.dir/kitemviews/kitemlistselectionmanager.cpp.o
[  9%] Building CXX object src/CMakeFiles/dolphinprivate.dir/kitemviews/kitemliststyleoption.cpp.o
[ 10%] Building CXX object src/CMakeFiles/dolphinprivate.dir/kitemviews/kitemlistview.cpp.o
[ 10%] Building CXX object src/CMakeFiles/dolphinprivate.dir/kitemviews/kitemlistviewaccessible.cpp.o
[ 10%] Building CXX object src/CMakeFiles/dolphinprivate.dir/kitemviews/kitemlistwidget.cpp.o
[ 10%] Building CXX object src/CMakeFiles/dolphinprivate.dir/kitemviews/kitemmodelbase.cpp.o
[ 11%] Building CXX object src/CMakeFiles/dolphinprivate.dir/kitemviews/kitemset.cpp.o
[ 11%] Building CXX object src/CMakeFiles/dolphinprivate.dir/kitemviews/kstandarditem.cpp.o
[ 11%] Building CXX object src/CMakeFiles/dolphinprivate.dir/kitemviews/kstandarditemlistgroupheader.cpp.o
[ 12%] Building CXX object src/CMakeFiles/dolphinprivate.dir/kitemviews/kstandarditemlistwidget.cpp.o
[ 12%] Building CXX object src/CMakeFiles/dolphinprivate.dir/kitemviews/kstandarditemlistview.cpp.o
[ 12%] Building CXX object src/CMakeFiles/dolphinprivate.dir/kitemviews/kstandarditemmodel.cpp.o
[ 13%] Building CXX object src/CMakeFiles/dolphinprivate.dir/kitemviews/private/kdirectorycontentscounter.cpp.o
[ 13%] Building CXX object src/CMakeFiles/dolphinprivate.dir/kitemviews/private/kdirectorycontentscounterworker.cpp.o
[ 13%] Building CXX object src/CMakeFiles/dolphinprivate.dir/kitemviews/private/kfileitemclipboard.cpp.o
[ 14%] Building CXX object src/CMakeFiles/dolphinprivate.dir/kitemviews/private/kfileitemmodeldirlister.cpp.o
[ 14%] Building CXX object src/CMakeFiles/dolphinprivate.dir/kitemviews/private/kfileitemmodelfilter.cpp.o
[ 14%] Building CXX object src/CMakeFiles/dolphinprivate.dir/kitemviews/private/kitemlistheaderwidget.cpp.o
[ 15%] Building CXX object src/CMakeFiles/dolphinprivate.dir/kitemviews/private/kitemlistkeyboardsearchmanager.cpp.o
[ 15%] Building CXX object src/CMakeFiles/dolphinprivate.dir/kitemviews/private/kitemlistroleeditor.cpp.o
[ 15%] Building CXX object src/CMakeFiles/dolphinprivate.dir/kitemviews/private/kitemlistrubberband.cpp.o
[ 15%] Building CXX object src/CMakeFiles/dolphinprivate.dir/kitemviews/private/kitemlistselectiontoggle.cpp.o
[ 16%] Building CXX object src/CMakeFiles/dolphinprivate.dir/kitemviews/private/kitemlistsizehintresolver.cpp.o
[ 16%] Building CXX object src/CMakeFiles/dolphinprivate.dir/kitemviews/private/kitemlistsmoothscroller.cpp.o
[ 16%] Building CXX object src/CMakeFiles/dolphinprivate.dir/kitemviews/private/kitemlistviewanimation.cpp.o
[ 17%] Building CXX object src/CMakeFiles/dolphinprivate.dir/kitemviews/private/kitemlistviewlayouter.cpp.o
[ 17%] Building CXX object src/CMakeFiles/dolphinprivate.dir/kitemviews/private/kpixmapmodifier.cpp.o
[ 17%] Building CXX object src/CMakeFiles/dolphinprivate.dir/settings/additionalinfodialog.cpp.o
[ 18%] Building CXX object src/CMakeFiles/dolphinprivate.dir/settings/applyviewpropsjob.cpp.o
[ 18%] Building CXX object src/CMakeFiles/dolphinprivate.dir/settings/viewmodes/viewmodesettings.cpp.o
[ 18%] Building CXX object src/CMakeFiles/dolphinprivate.dir/settings/viewpropertiesdialog.cpp.o
[ 19%] Building CXX object src/CMakeFiles/dolphinprivate.dir/settings/viewpropsprogressinfo.cpp.o
[ 19%] Building CXX object src/CMakeFiles/dolphinprivate.dir/views/dolphinfileitemlistwidget.cpp.o
[ 19%] Building CXX object src/CMakeFiles/dolphinprivate.dir/views/dolphinitemlistview.cpp.o
[ 19%] Building CXX object src/CMakeFiles/dolphinprivate.dir/views/dolphinnewfilemenuobserver.cpp.o
[ 20%] Building CXX object src/CMakeFiles/dolphinprivate.dir/views/dolphinremoteencoding.cpp.o
[ 20%] Building CXX object src/CMakeFiles/dolphinprivate.dir/views/dolphinview.cpp.o
[ 20%] Building CXX object src/CMakeFiles/dolphinprivate.dir/views/dolphinviewactionhandler.cpp.o
[ 21%] Building CXX object src/CMakeFiles/dolphinprivate.dir/views/draganddrophelper.cpp.o
[ 21%] Building CXX object src/CMakeFiles/dolphinprivate.dir/views/renamedialog.cpp.o
[ 21%] Building CXX object src/CMakeFiles/dolphinprivate.dir/views/tooltips/dolphinfilemetadatawidget.cpp.o
[ 22%] Building CXX object src/CMakeFiles/dolphinprivate.dir/views/tooltips/tooltipmanager.cpp.o
[ 22%] Building CXX object src/CMakeFiles/dolphinprivate.dir/views/versioncontrol/updateitemstatesthread.cpp.o
[ 22%] Building CXX object src/CMakeFiles/dolphinprivate.dir/views/versioncontrol/versioncontrolobserver.cpp.o
[ 23%] Building CXX object src/CMakeFiles/dolphinprivate.dir/views/viewmodecontroller.cpp.o
[ 23%] Building CXX object src/CMakeFiles/dolphinprivate.dir/views/viewproperties.cpp.o
[ 23%] Building CXX object src/CMakeFiles/dolphinprivate.dir/views/zoomlevelinfo.cpp.o
[ 24%] Building CXX object src/CMakeFiles/dolphinprivate.dir/dolphinremoveaction.cpp.o
[ 24%] Building CXX object src/CMakeFiles/dolphinprivate.dir/middleclickactioneventfilter.cpp.o
[ 24%] Building CXX object src/CMakeFiles/dolphinprivate.dir/dolphinnewfilemenu.cpp.o
[ 24%] Building CXX object src/CMakeFiles/dolphinprivate.dir/dolphindebug.cpp.o
[ 25%] Building CXX object src/CMakeFiles/dolphinprivate.dir/kitemviews/private/kbaloorolesprovider.cpp.o
[ 25%] Building CXX object src/CMakeFiles/dolphinprivate.dir/dolphin_compactmodesettings.cpp.o
[ 25%] Building CXX object src/CMakeFiles/dolphinprivate.dir/dolphin_directoryviewpropertysettings.cpp.o
[ 26%] Building CXX object src/CMakeFiles/dolphinprivate.dir/dolphin_detailsmodesettings.cpp.o
[ 26%] Building CXX object src/CMakeFiles/dolphinprivate.dir/dolphin_iconsmodesettings.cpp.o
[ 26%] Building CXX object src/CMakeFiles/dolphinprivate.dir/dolphin_generalsettings.cpp.o
[ 27%] Building CXX object src/CMakeFiles/dolphinprivate.dir/dolphin_versioncontrolsettings.cpp.o
[ 27%] Building CXX object src/CMakeFiles/dolphinprivate.dir/dolphinprivate_autogen/mocs_compilation.cpp.o
[ 27%] Linking CXX shared library ../bin/libdolphinprivate.so
[ 27%] Built target dolphinprivate
Scanning dependencies of target dolphinstatic_autogen
[ 28%] Automatic MOC for target dolphinstatic
[ 28%] Built target dolphinstatic_autogen
[ 29%] Generating qrc_dolphin.cpp
[ 29%] Generating dolphin_folderspanelsettings.h, dolphin_folderspanelsettings.cpp
[ 29%] Generating dolphin_folderspanelsettings.moc
/home/shivang/oss/kde/dolphin/build/src/dolphin_folderspanelsettings.h:0: Note: No relevant classes found. No output generated.
[ 29%] Generating dolphin_informationpanelsettings.h, dolphin_informationpanelsettings.cpp
[ 30%] Generating dolphin_informationpanelsettings.moc
/home/shivang/oss/kde/dolphin/build/src/dolphin_informationpanelsettings.h:0: Note: No relevant classes found. No output generated.
[ 31%] Generating dolphin_placespanelsettings.h, dolphin_placespanelsettings.cpp
[ 31%] Generating dolphin_placespanelsettings.moc
/home/shivang/oss/kde/dolphin/build/src/dolphin_placespanelsettings.h:0: Note: No relevant classes found. No output generated.
[ 32%] Generating dolphin_searchsettings.h, dolphin_searchsettings.cpp
[ 32%] Generating dolphin_searchsettings.moc
/home/shivang/oss/kde/dolphin/build/src/dolphin_searchsettings.h:0: Note: No relevant classes found. No output generated.
Scanning dependencies of target dolphinstatic
[ 32%] Building CXX object src/CMakeFiles/dolphinstatic.dir/dolphindockwidget.cpp.o
[ 32%] Building CXX object src/CMakeFiles/dolphinstatic.dir/dolphinmainwindow.cpp.o
[ 33%] Building CXX object src/CMakeFiles/dolphinstatic.dir/dolphinviewcontainer.cpp.o
[ 33%] Building CXX object src/CMakeFiles/dolphinstatic.dir/dolphincontextmenu.cpp.o
[ 33%] Building CXX object src/CMakeFiles/dolphinstatic.dir/dolphintabbar.cpp.o
[ 34%] Building CXX object src/CMakeFiles/dolphinstatic.dir/dolphinplacesmodelsingleton.cpp.o
[ 34%] Building CXX object src/CMakeFiles/dolphinstatic.dir/dolphinrecenttabsmenu.cpp.o
[ 34%] Building CXX object src/CMakeFiles/dolphinstatic.dir/dolphintabpage.cpp.o
[ 34%] Building CXX object src/CMakeFiles/dolphinstatic.dir/dolphintabwidget.cpp.o
/home/shivang/oss/kde/dolphin/src/dolphintabwidget.cpp: In member function 'void DolphinTabWidget::readProperties(const KConfigGroup&)':
/home/shivang/oss/kde/dolphin/src/dolphintabwidget.cpp:107:47: warning: 'void DolphinTabPage::restoreStateV1(const QByteArray&)' is deprecated [-Wdeprecated-declarations]
             tabPageAt(i)->restoreStateV1(state);
                                               ^
In file included from /home/shivang/oss/kde/dolphin/src/dolphintabwidget.cpp:23:0:
/home/shivang/oss/kde/dolphin/src/dolphintabpage.h:130:28: note: declared here
     Q_DECL_DEPRECATED void restoreStateV1(const QByteArray& state);
                            ^~~~~~~~~~~~~~
[ 35%] Building CXX object src/CMakeFiles/dolphinstatic.dir/trash/dolphintrash.cpp.o
[ 35%] Building CXX object src/CMakeFiles/dolphinstatic.dir/filterbar/filterbar.cpp.o
[ 35%] Building CXX object src/CMakeFiles/dolphinstatic.dir/main.cpp.o
[ 36%] Building CXX object src/CMakeFiles/dolphinstatic.dir/panels/information/filemetadataconfigurationdialog.cpp.o
[ 36%] Building CXX object src/CMakeFiles/dolphinstatic.dir/panels/information/informationpanel.cpp.o
[ 36%] Building CXX object src/CMakeFiles/dolphinstatic.dir/panels/information/informationpanelcontent.cpp.o
/home/shivang/oss/kde/dolphin/src/panels/information/informationpanelcontent.cpp: In constructor 'InformationPanelContent::InformationPanelContent(QWidget*)':
/home/shivang/oss/kde/dolphin/src/panels/information/informationpanelcontent.cpp:120:23: error: 'class Baloo::FileMetaDataWidget' has no member named 'setDateFormat'
     m_metaDataWidget->setDateFormat(static_cast<Baloo::DateFormats>(InformationPanelSettings::dateFormat()));
                       ^~~~~~~~~~~~~
/home/shivang/oss/kde/dolphin/src/panels/information/informationpanelcontent.cpp:120:56: error: 'DateFormats' in namespace 'Baloo' does not name a type
     m_metaDataWidget->setDateFormat(static_cast<Baloo::DateFormats>(InformationPanelSettings::dateFormat()));
                                                        ^~~~~~~~~~~
/home/shivang/oss/kde/dolphin/src/panels/information/informationpanelcontent.cpp: In member function 'void InformationPanelContent::showItem(const KFileItem&)':
/home/shivang/oss/kde/dolphin/src/panels/information/informationpanelcontent.cpp:197:27: error: 'class Baloo::FileMetaDataWidget' has no member named 'setDateFormat'
         m_metaDataWidget->setDateFormat(static_cast<Baloo::DateFormats>(InformationPanelSettings::dateFormat()));
                           ^~~~~~~~~~~~~
/home/shivang/oss/kde/dolphin/src/panels/information/informationpanelcontent.cpp:197:60: error: 'DateFormats' in namespace 'Baloo' does not name a type
         m_metaDataWidget->setDateFormat(static_cast<Baloo::DateFormats>(InformationPanelSettings::dateFormat()));
                                                            ^~~~~~~~~~~
/home/shivang/oss/kde/dolphin/src/panels/information/informationpanelcontent.cpp: In member function 'void InformationPanelContent::configureSettings(const QList<QAction*>&)':
/home/shivang/oss/kde/dolphin/src/panels/information/informationpanelcontent.cpp:289:100: error: 'Baloo::DateFormats' has not been declared
     dateformatAction->setChecked(InformationPanelSettings::dateFormat() == static_cast<int>(Baloo::DateFormats::ShortFormat));
                                                                                                    ^~~~~~~~~~~
/home/shivang/oss/kde/dolphin/src/panels/information/informationpanelcontent.cpp:307:62: error: 'Baloo::DateFormats' has not been declared
         int dateFormat = static_cast<int>(isChecked ? Baloo::DateFormats::ShortFormat : Baloo::DateFormats::LongFormat);
                                                              ^~~~~~~~~~~
/home/shivang/oss/kde/dolphin/src/panels/information/informationpanelcontent.cpp:307:96: error: 'Baloo::DateFormats' has not been declared
         int dateFormat = static_cast<int>(isChecked ? Baloo::DateFormats::ShortFormat : Baloo::DateFormats::LongFormat);
                                                                                                ^~~~~~~~~~~
make[2]: *** [src/CMakeFiles/dolphinstatic.dir/build.make:358: src/CMakeFiles/dolphinstatic.dir/panels/information/informationpanelcontent.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:1225: src/CMakeFiles/dolphinstatic.dir/all] Error 2
make: *** [Makefile:141: all] Error 2
Comment 6 Christoph Feck 2018-05-11 18:38:56 UTC
You need master of baloo-widgets.git to build master of dolphin.git
Comment 7 Shivang Saxena 2018-05-11 18:50:04 UTC
Yes, building baloo-widgets from git solved the build issue for me. But shouldn't this be checked by cmake? Or is it assumed the developer will install all git versions of the dependencies of the kde product they are building?

Sorry, I am new to this, I did not see this step in (https://community.kde.org/Get_Involved/development).
Comment 8 Christoph Feck 2018-05-11 21:24:52 UTC
Right, the baloo-widget repository lacks proper version information that can be checked by applications. Patches to correct this welcome. Right now it isn't that much of an issue, though, because both baloo-widget and dolphin are released together, so their versions are assumed to match.
Comment 9 Shivang Saxena 2018-05-12 19:56:35 UTC
For end-users installing from their distro's package manager, I completely agree, since they are released together.

But for developers, we already have had two cases where developers (me and OP) try to build from source but receive a compile-time error with no indication that an outdated baloo-widgets is the culprit. I would love to try to add versioning checks but not sure where or how to start. If someone more experienced can pitch in that would be great!
Comment 10 Arfrever Frehtes Taifersar Arahesis 2018-05-13 20:29:23 UTC
Fixed in:
https://cgit.kde.org/dolphin.git/commit/?id=2912894d4f13907bb05be0a2a0d4e432668d9817