Bug 393396 - Animation: Add Hold Column moves to the wrong keyframe afterwards
Summary: Animation: Add Hold Column moves to the wrong keyframe afterwards
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Animation (other bugs)
Version First Reported In: git master (please specify the git hash!)
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-22 15:16 UTC by Scott Petrovic
Modified: 2018-05-18 18:56 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
red is where it is moving to (bad). Green is where it probably should have moved to (16.79 KB, image/png)
2018-04-22 15:18 UTC, Scott Petrovic
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Scott Petrovic 2018-04-22 15:16:55 UTC
In git master when you use the "Add Hold Column" it isn't working like I am expecting it to. It adds a hold frame in the correct spot, then the playhead moves for some reason to a position it isn't supposed to be. 

The problem is that I have this action assigned to a shortcut. If I press it multiple times, the hold column is correct once, then it is adding hold frames to the wrong location because of where the playhead was moved to.

With the image I am attaching, the green arrow is where the playhead was supposed to move to. The red arrow is where the playhead is actually moving to.

I was a bit disoriented when the playhead is moving by itself. I didn't give any action to tell it to move. I just wanted to add a frame at that position.
Comment 1 Scott Petrovic 2018-04-22 15:18:27 UTC
Created attachment 112166 [details]
red is where it is moving to (bad). Green is where it probably should have moved to
Comment 2 Scott Petrovic 2018-05-18 15:55:06 UTC
This is a video that maybe will make it a bit more clear.

https://i.imgur.com/f0omeJh.gif

This one is using the N hold frames, but it does the same thing. After it adds the hold frames, the playhead moves to a frame it shouldn't be on. It playhead probably shouldn't be moving at all after these operations
Comment 3 Halla Rempt 2018-05-18 18:56:05 UTC
Git commit c215d014341c9a9f1b1532202b4cf54c0f7d6a32 by Boudewijn Rempt.
Committed on 18/05/2018 at 18:49.
Pushed by rempt into branch 'master'.

Fix playhead positioning after adding/removing hold frames

M  +5    -3    plugins/dockers/animation/timeline_frames_model.cpp

https://commits.kde.org/krita/c215d014341c9a9f1b1532202b4cf54c0f7d6a32