Bug 393355 - polkit-kde-agent does not show any icon of the main program
Summary: polkit-kde-agent does not show any icon of the main program
Status: RESOLVED NOT A BUG
Alias: None
Product: policykit-kde-agent-1
Classification: Plasma
Component: polkit-kde-authentication-agent-1 (show other bugs)
Version: 5.12.4
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: Jaroslav Reznik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-20 20:58 UTC by Andrius Štikonas
Modified: 2018-04-21 18:32 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Screenshot.png (735.88 KB, image/png)
2018-04-20 20:58 UTC, Andrius Štikonas
Details
Screenshot showing correct overlay (54.66 KB, image/png)
2018-04-21 01:53 UTC, Stefan Brüns
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andrius Štikonas 2018-04-20 20:58:44 UTC
Created attachment 112146 [details]
Screenshot.png

I think it's supposed to be showed as a smaller icon overlayed on the bottom right corner of the main icon.
Comment 1 Stefan Brüns 2018-04-21 01:53:04 UTC
Created attachment 112148 [details]
Screenshot showing correct overlay


$> grep icon /usr/share/polkit-1/actions/org.freedesktop.UDisks2.policy 
  <icon_name>drive-removable-media</icon_name>
Comment 2 Andrius Štikonas 2018-04-21 06:07:12 UTC
Yes, this one (udisks2) icon works on my system.

But quite a few of KAuth helpers  helpers do not set the icon. So I guess this bug is indeed a lot of smaller bugs in individual applications  (ktexteditor, sddm).
Comment 3 Stefan Brüns 2018-04-21 13:51:25 UTC
These are not application icons, but icons related to privileged actions. These *may*  look the same, but are different.
Comment 4 Andrius Štikonas 2018-04-21 17:51:28 UTC
(In reply to Stefan Brüns from comment #3)
> These are not application icons, but icons related to privileged actions.
> These *may*  look the same, but are different.

Yeah, now I saw that too... Shall we close this bug report then?
Comment 5 Stefan Brüns 2018-04-21 17:55:46 UTC
polkit-kde-agent works as designed, i.e. iff the action specifies an icon according to the freedesktop icon spec, the icon is shown.
Comment 6 Andrius Štikonas 2018-04-21 18:32:03 UTC
By the way, what about the main window icon under Wayland? I'm not even sure how to fix this in this case.

Normally, you have to specifty desktop file with QCoreApplication::setDesktopFile which has Icon= parameter. I guess we can still show polkit-kde-agent icon without overlay as window icon?