Bug 393245 - Wrong day for Teachers day in Slovak holiday calendar
Summary: Wrong day for Teachers day in Slovak holiday calendar
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kholidays
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Manjaro Linux
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-18 09:42 UTC by Miroslav Ďurian
Modified: 2018-04-28 13:50 UTC (History)
2 users (show)

See Also:
Latest Commit: https://commits.kde.org/kholidays/9c8aa21205db76d9677855e760ee155bf35cc325
Version Fixed In: 5.46

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Miroslav Ďurian 2018-04-18 09:42:34 UTC 
Holiday for Slovakia (sk_sk) has wrong date for Teachers day.
It should be 28.March, not 28.April.
Comment 1 Nate Graham 2018-04-18 17:13:21 UTC 
This is a pretty simple fix. Here is the exact line of code that is wrong: https://cgit.kde.org/kholidays.git/tree/holidays/plan2/holiday_sk_sk#n55

Would you like to try your hand at submitting a patch? I am willing to help you, and we have excellent documentation:

- https://community.kde.org/Get_Involved/development
- https://community.kde.org/Infrastructure/Phabricator
Comment 2 Allen Winter 2018-04-28 13:50:43 UTC 
Git commit 9c8aa21205db76d9677855e760ee155bf35cc325 by Allen Winter.
Committed on 28/04/2018 at 13:39.
Pushed by winterz into branch 'master'.

holidays/plan2/holiday_sk_sk - Teacher's Day fix
FIXED-IN: 5.46

M  +1    -1    holidays/plan2/holiday_sk_sk

https://commits.kde.org/kholidays/9c8aa21205db76d9677855e760ee155bf35cc325