Bug 393164 - Built-in Ten Brushes dialog script has a typo
Summary: Built-in Ten Brushes dialog script has a typo
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Scripting (show other bugs)
Version: 4.0
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-15 10:42 UTC by Thomas Giles
Modified: 2018-04-16 10:13 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Fixed .py file (933 bytes, text/plain)
2018-04-15 10:42 UTC, Thomas Giles
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Giles 2018-04-15 10:42:02 UTC
Created attachment 112041 [details]
Fixed .py file

When clicking "Ok" on the Ten Brushes dialog, I get an error:

```
AttributeError
Python 3.6.2: python
Sun Apr 15 11:38:38 2018

A problem occurred in a Python script.  Here is the sequence of
function calls leading up to the error, in the order they occurred.

 C:\Program Files\Krita (x64)\share\krita\pykrita\tenbrushes\tenbrushesdialog.py in accept(self=<tenbrushes.tenbrushesdialog.TenBrushesDialog object>)
   21 
   22     def accept(self):
   23         self.uitenbrushes.tentbrushes.writeSettings()
   24 
   25         super(TenBrushesDialog, self).accept()
self = <tenbrushes.tenbrushesdialog.TenBrushesDialog object>
self.uitenbrushes = <tenbrushes.uitenbrushes.UITenBrushes object>
self.uitenbrushes.tentbrushes undefined
AttributeError: 'UITenBrushes' object has no attribute 'tentbrushes'
    __cause__ = None
    __class__ = <class 'AttributeError'>
    __context__ = None
    __delattr__ = <method-wrapper '__delattr__' of AttributeError object>
    __dict__ = {}
    __dir__ = <built-in method __dir__ of AttributeError object>
    __doc__ = 'Attribute not found.'
    __eq__ = <method-wrapper '__eq__' of AttributeError object>
    __format__ = <built-in method __format__ of AttributeError object>
    __ge__ = <method-wrapper '__ge__' of AttributeError object>
    __getattribute__ = <method-wrapper '__getattribute__' of AttributeError object>
    __gt__ = <method-wrapper '__gt__' of AttributeError object>
    __hash__ = <method-wrapper '__hash__' of AttributeError object>
    __init__ = <method-wrapper '__init__' of AttributeError object>
    __init_subclass__ = <built-in method __init_subclass__ of type object>
    __le__ = <method-wrapper '__le__' of AttributeError object>
    __lt__ = <method-wrapper '__lt__' of AttributeError object>
    __ne__ = <method-wrapper '__ne__' of AttributeError object>
    __new__ = <built-in method __new__ of type object>
    __reduce__ = <built-in method __reduce__ of AttributeError object>
    __reduce_ex__ = <built-in method __reduce_ex__ of AttributeError object>
    __repr__ = <method-wrapper '__repr__' of AttributeError object>
    __setattr__ = <method-wrapper '__setattr__' of AttributeError object>
    __setstate__ = <built-in method __setstate__ of AttributeError object>
    __sizeof__ = <built-in method __sizeof__ of AttributeError object>
    __str__ = <method-wrapper '__str__' of AttributeError object>
    __subclasshook__ = <built-in method __subclasshook__ of type object>
    __suppress_context__ = False
    __traceback__ = <traceback object>
    args = ("'UITenBrushes' object has no attribute 'tentbrushes'",)
    with_traceback = <built-in method with_traceback of AttributeError object>

The above is a description of an error in a Python program.  Here is
the original traceback:

Traceback (most recent call last):
  File "C:\Program Files\Krita (x64)\share\krita\pykrita\tenbrushes\tenbrushesdialog.py", line 23, in accept
    self.uitenbrushes.tentbrushes.writeSettings()
AttributeError: 'UITenBrushes' object has no attribute 'tentbrushes'
```

This is due to a simple typo. I fixed the typo, which solved the issue, but it may be worth fixing the master version for new installs. I have attached the fixed version of the file.
Comment 1 Dmitry Kazakov 2018-04-16 10:13:21 UTC
Hi, Thomas!

Thank you for your report! This bug has been fixes in the most recent update Krita 4.0.1, please update it and enjoy painting with the ten brushes plugin! :)

https://krita.org/en/download/krita-desktop/