Bug 393145 - Drag/drop (mv) of preselected item causes inline rename of next item
Summary: Drag/drop (mv) of preselected item causes inline rename of next item
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: view-engine: details mode (show other bugs)
Version: 18.04.3
Platform: Fedora RPMs Linux
: NOR normal
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-14 19:27 UTC by Georgios Varisteas
Modified: 2023-12-15 09:43 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Georgios Varisteas 2018-04-14 19:27:36 UTC
This happens always but needs to be replicated exactly.
I have only tested it with details view and inline rename enabled.

1. Open dolphin at any path that belongs to the active user
2. Select (just highlight) an item, file or folder, that has write permission (thus can be renamed)
3. Click the same item and drag it towards a panel or the address bar (I always drop it as a move operation but the bug happens  before that)
4. Notice that an inline rename has been initiated during the drag operation.
5. Drop the item so as to move it to another folder
6. Notice that the inline rename is still there even though the item was moved and the total items are reduced by one.

Here is the serious part of the bug:
The inline rename is now for the **next** item on the list. The pre-filled filename is that of the moved file. Thus if any action validates the rename operation (a click, enter, or anything else), a file (or folder, this applies to any item that is rename-able) is renamed by accident to the name of the moved file. The only option at that point is to press ESC.

A typical case for me that causes this error:
A folder with a long list of files in it. I'm looking for a certain file, so I just type the first few letters to automatically select it. The file is now highlighted. I click to move it and... the bug appears.
A work around I usually use is: once a file is selected, I cut via keyboard, then right click on the destination to paste.
Comment 1 Greg Lepore 2018-04-16 19:22:59 UTC
Confirmed on:

KDE Plasma Version 5.12.4
Frameworks Version 5.44.0
QT Version 5.10.0
Kernel Version 4.13.0-38-generic
OS Type 64-bit
Dolphin Version 17.12.3
Comment 2 Ali Mousavi Kherad 2018-05-07 12:24:34 UTC
I have the same issue on Dophin 18.04.0 ArchLinux

KDE Frameworks 5.45.0
Qt 5.10.1 (built against 5.10.1)
The xcb windowing system
Comment 3 John I. 2018-08-24 19:08:09 UTC
Same problem, but I encounter it differently. Like the original poster, I am also using details view and have inline rename enabled.

1. Open Dolphin, split the screen (F3).
2. Change the right panel to a directory different from the one in the left panel.
3. Left click on any file in right panel to open it, then close it again. (Without this step, no renaming takes place and there is no problem.)
4. Left click on the same file name that has just been closed in the right panel, keep mouse button pressed, drag it to the left panel and drop it there. Choose 'Move here' from the popup menu.
5. What happens next depends on the timing of the drop, or, when you release the left mouse button. In all cases, after you initiate the drag, the file being moved changes to inline rename mode in the right panel (bounding box becomes visible and name is highlighted). If you drop the file after that has happened, the file is moved normally and no renaming takes place.
6. If you drop the file before the filename in the right panel has gone into rename mode, the next file in the directory below it gets renamed with the moved file's name.
7. By the time the 'Move here' popup menu appears the problem has already happened. The popup is not part of the problem.

This is a very specific use case, but I think not uncommon: user opens file, sees what it is and decides to move it somewhere else. In most cases no renaming of other files will happen, but every once in a while unwanted renaming will occur. If this is not noticed at the time, the original of the renamed right panel file will later seem to have vanished (it is there, but under a different name and therefore not recognisable). A logical reaction when finding what appears to be a duplicate file that one knows has previously been moved somewhere else, would be to delete it. This is a problem, since one will actually be deleting a different file. The fact that it happens intermittently (depending on timing of file drop button release) means that it can persist for a long time without being noticed.

Fedora 28
KDE Plasma version 5.13.4
KDE Frameworks version 5.48.0
Qt version 5.10.1
Kernel version 4.17.14-202.fc28.x86_64
Dolphin version 18.04.3

I first noticed it about a month ago, following installation of a general KDE upgrade from the fedora repo. I do not know what version I had before.
Comment 4 Hakan Bayindir 2019-01-20 13:40:02 UTC
I'm experiencing the same problem on 18.08 on Debian Buster (testing). The problem is happening regardless of a copy and/or move. It's triggered at the moment the cursor leaves the window, and that leave is processed as a "slow-click" for renaming.