Bug 393108 - Tags not always visible when selecting multiple pictures in a group
Summary: Tags not always visible when selecting multiple pictures in a group
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Albums-ItemGroup (show other bugs)
Version: 6.0.0
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-13 15:30 UTC by MarcP
Modified: 2018-04-14 21:29 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.0.0


Attachments
Screen captures showing this behavior (927.91 KB, image/gif)
2018-04-13 15:30 UTC, MarcP
Details
bug.png (260.88 KB, image/png)
2018-04-13 18:42 UTC, Maik Qualmann
Details

Note You need to log in before you can comment on or make changes to this bug.
Description MarcP 2018-04-13 15:30:46 UTC
Created attachment 112006 [details]
Screen captures showing this behavior

Normally, when selecting two pictures with different tags, the non-common tags appear in the "Captions" panel with a grey box (and you can click it to apply those tags to the selection if you want).

But some times (not always), when two pictures are in a group, and tags differ, sometimes only the tags from the first (or second) picture are visible, instead of showing the common-tags with a tick and non-common tags with a gray box. It also seems to depend on the order in which the pictures are selected in a group.

But as I mentioned, the behavior is not always consistent. I have attached a gif showing this behavior.

I am using the last digikam 6.0 preview for windows 64bit, by the way.
Comment 1 MarcP 2018-04-13 15:34:40 UTC
I just noticed this behavior also happens when pictures in a group are "hidden". Only the tags from the picture "on top" of the group are shown.
Comment 2 Maik Qualmann 2018-04-13 18:42:44 UTC
Created attachment 112011 [details]
bug.png

Not a bug, is a feature. Deactivate the red marked button.

Maik
Comment 3 MarcP 2018-04-13 18:45:49 UTC
But that button just shows and hides unused tags. It's not what I'm trying to describe here.

On a nutshell, when selecting several pictures inside a group, the tags that will be displayed will depend on which picture has been selected first. (instead of showing tags present in all the selection, with those in common with a "tick" mark and the rest in a grey box)
Comment 4 Maik Qualmann 2018-04-13 19:01:21 UTC
Ok I understand. You mean the checkbox status, if a image without tags is selected first or after a image with tags. A image with no tags should have no influence on the checkbox status.

Maik
Comment 5 MarcP 2018-04-13 19:03:57 UTC
Yes, that! I should have added captions to the gif. If a picture has not tags and another has a tag, when selecting both, the tag should still be in the list, and with a gray square. But for some reason, this is not always the case for grouped images, where the image on top determines the tags that will be shown for the selection.
Comment 6 Maik Qualmann 2018-04-14 21:29:10 UTC
Git commit 0d274bed576ffebfb8dee62b8c02dc7a0aa50bda by Maik Qualmann.
Committed on 14/04/2018 at 21:27.
Pushed by mqualmann into branch 'master'.

fix tag checkbox state if item has not tags
FIXED-IN: 6.0.0

M  +2    -1    NEWS
M  +21   -15   core/libs/imageproperties/disjointmetadata.cpp
M  +1    -1    core/libs/imageproperties/disjointmetadata.h

https://commits.kde.org/digikam/0d274bed576ffebfb8dee62b8c02dc7a0aa50bda