Bug 393106 - When I specify a path, it still uses baloo and looks everywhere for files
Summary: When I specify a path, it still uses baloo and looks everywhere for files
Status: RESOLVED FIXED
Alias: None
Product: Elisa
Classification: Applications
Component: baloo (show other bugs)
Version: 0.1
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Matthieu Gallien
URL:
Keywords:
: 399624 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-04-13 14:10 UTC by John
Modified: 2019-03-25 20:40 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description John 2018-04-13 14:10:25 UTC
It adds everything with sound to elisa an not only my specified path.
Comment 1 Matthieu Gallien 2018-04-14 07:11:35 UTC
Thanks for your report.
The configuration dialog is only for the Elisa music indexer. There is not yet a way to configure the Baloo integration.

If I understand your need, you would like to use Baloo support but only for some paths ?
Comment 2 John 2018-04-14 10:45:22 UTC
I want do add a folder for example /home/xxx/music and in elisa should only show up the m4a, aac, mp3 ... files from this folder and not from the whole system.

And I also would be very happy if it would be possible to list for Track, Album and Album-Artist. If there is no Album-Artist use as fallback the Artist Tag.
Comment 3 Matthieu Gallien 2018-06-25 20:00:25 UTC
I have created the following task https://phabricator.kde.org/T9082 . It is a good way to start contributing to the c++ part of Elisa. It is currently flagged as a junior job.
Comment 4 Matthieu Gallien 2018-10-11 09:40:50 UTC
*** Bug 399624 has been marked as a duplicate of this bug. ***
Comment 5 Matthieu Gallien 2019-03-10 09:44:06 UTC
I have implemented proper filtering in the Baloo indexer such that settings apply whether baloo or plain old files indexers are used.

https://phabricator.kde.org/D19650

Could you please test and report ?
Comment 6 Matthieu Gallien 2019-03-25 20:40:49 UTC
Git commit 79054e47bb532eec4b3fbc872a7a1c5e32910456 by Matthieu Gallien.
Committed on 25/03/2019 at 20:40.
Pushed by mgallien into branch 'master'.

Simplify and improve music indexers management

Summary:
start baloo first and if it is not available, start local file indexer

remove management of track discovery sources

simplify management of tracks by removing management of which source has
discovered a track

should allow users to easily switch from Baloo to local file system as
tracks source

improve management of tracks sources such that only baloo or local file
system scanning is enabled

no longer emit a signal when Elisa cannot watch a file for changes

refactor the way we check for Baloo availability

filter tracks by the configured paths when getting all tracks from Baloo

use the same list of paths than plain file system scanning

remove double checking for baloo configuration: not needed

Baloo configuration is now checked before going into
LocalBalooFileListing: no need to do it a second time

add support for qt logging category and use it for file indexers

improve management of indexers state and user reporting

convert LocalBalooFileListing to only use categorized debug logs

hopefully fix the display of busy indexers notifications

when configuration change, display proper busy notification to the user

indexing is no longer finished until tracks have been fully removed

Test Plan:
Only one indexer is active (baloo or plain old file indexer).
Traces should help diagnose what happen

Reviewers: ngraham

Tags: #elisa

Differential Revision: https://phabricator.kde.org/D19650

M  +10   -10   autotests/alltracksproxymodeltest.cpp
M  +73   -266  autotests/databaseinterfacetest.cpp
M  +31   -31   autotests/datamodeltest.cpp
M  +15   -125  autotests/localfilelistingtest.cpp
M  +3    -3    autotests/manageheaderbartest.cpp
M  +3    -3    autotests/managemediaplayercontroltest.cpp
M  +47   -47   autotests/mediaplaylisttest.cpp
M  +6    -6    autotests/trackslistenertest.cpp
M  +36   -0    src/CMakeLists.txt
M  +10   -3    src/abstractfile/abstractfilelistener.cpp
M  +3    -1    src/abstractfile/abstractfilelistener.h
M  +57   -27   src/abstractfile/abstractfilelisting.cpp
M  +19   -10   src/abstractfile/abstractfilelisting.h
M  +21   -19   src/audiowrapper_libvlc.cpp
A  +117  -0    src/baloo/baloodetector.cpp     [License: LGPL (v3+)]
A  +67   -0    src/baloo/baloodetector.h     [License: LGPL (v3+)]
M  +69   -82   src/baloo/localbaloofilelisting.cpp
M  +0    -6    src/baloo/localbaloofilelisting.h
M  +1008 -616  src/databaseinterface.cpp
M  +39   -10   src/databaseinterface.h
M  +0    -11   src/elisa_core.kcfg
M  +1    -1    src/elisaimport.cpp
M  +0    -12   src/file/filelistener.cpp
M  +0    -15   src/file/filelistener.h
M  +10   -22   src/file/localfilelisting.cpp
M  +0    -15   src/file/localfilelisting.h
M  +1    -1    src/localFileConfiguration/localfileconfiguration.cpp
M  +48   -8    src/musicaudiotrack.cpp
M  +10   -0    src/musicaudiotrack.h
M  +173  -104  src/musiclistenersmanager.cpp
M  +48   -8    src/musiclistenersmanager.h
M  +11   -15   src/qml/ElisaMainWindow.qml
M  +28   -11   src/qml/TrackImportNotification.qml

https://commits.kde.org/elisa/79054e47bb532eec4b3fbc872a7a1c5e32910456