Bug 393103 - QMessageBox Question icon has changed
Summary: QMessageBox Question icon has changed
Status: RESOLVED FIXED
Alias: None
Product: Breeze
Classification: Plasma
Component: Icons (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: visual-design
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-13 13:40 UTC by Jonathan Riddell
Modified: 2019-11-11 12:07 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
showing QMessageBox Question with new icon and kdialog with old icon (287.27 KB, image/png)
2018-04-13 13:40 UTC, Jonathan Riddell
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Riddell 2018-04-13 13:40:48 UTC
Created attachment 112002 [details]
showing QMessageBox Question with new icon and kdialog with old icon

The QMessageBox Question icon has changed in lastest Git master breeze icons.  This is a multi layered issue and it's unclear quite what's going on.

There was a new dialog-question icon added for Kirigami which is a smaller size (22).  This is the new icon that is being used, it's line art while the old one is coloured purple.  The attached screenshot shows it.

One qustion is should this icon as displayed on a QMessageBox use the line art version or the solid version.  VDG will have some breeze guidelines on the style of icon to be used in this case.

Another question is why is QMessagebox Question using that 22 icon, QStyle plugin doesn't specify a size but defaults to 32px, there are no 32px icons in that category.  The old icon is 64px.

Another question is why KDialog --yesno uses the old style icon.  They should both be using the same icon.

Attached screenshot shows both

Curiouser and curiouser
Comment 1 David Edmundson 2018-04-18 11:14:48 UTC
Icons are deliberately different (lineart) when they're set to be smaller
The icon loading part is working fine.
Comment 2 Harald Sitter 2018-04-18 11:49:25 UTC
quick dump from IRC

[13:45] <sitter> Sho_, notmart: from a the casual investigation I've done I think we can solve this from a code POV by figuring out why QMB requests s a smaller size than kdialog and align the two (I think we need a qstyle hint in plasma-integration for that)

[13:46] <sitter> as for the icon itself, Riddell, I think the theme config itself is wrong
[13:46] <sitter> status/22 sets
[13:46] <sitter> MinSize=22
[13:46] <sitter> MaxSize=32
[13:46] <sitter> status/64 sets
[13:46] <sitter> MinSize=22
[13:46] <sitter> MaxSize=256
[13:47] <sitter> so the two overlap between 22 and 32px
[13:48] <sitter> which from a casual glance is not the case for any of the other contexts, supposedly status/22 should scale 22-24 and status/64 should scale 32-256
Comment 3 Nate Graham 2019-10-30 23:48:42 UTC
This was fixed a while back.
Comment 4 Christoph Feck 2019-11-11 12:07:39 UTC
Changing status according to comment #3.