Bug 393048 - Log out dialogue - bad visibility of selected option
Summary: Log out dialogue - bad visibility of selected option
Alias: None
Product: plasmashell
Classification: Plasma
Component: general (show other bugs)
Version: 5.12.4
Platform: unspecified Linux
: NOR normal
Target Milestone: 1.0
Assignee: David Edmundson
Keywords: accessibility, usability
Depends on:
Reported: 2018-04-12 16:09 UTC by wazhai
Modified: 2019-03-08 00:47 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.16.0

Dialogue in question with default theme (9.60 KB, image/jpeg)
2018-04-12 16:09 UTC, wazhai

Note You need to log in before you can comment on or make changes to this bug.
Description wazhai 2018-04-12 16:09:58 UTC
Created attachment 111975 [details]
Dialogue in question with default theme

The currently selected option in the log out dialogue is highlighted in white, while the other options are grey, at least in most configurations and default themes, which is not a great difference in contrast. This leads to bad visibility of which option is selected in case of a low quality screen, low brightness level, bad light conditions or a visual impairment of the user.

This screen not only acts as a confirmation screen, but can also be configured to be triggered e.g. with the power button or another shortcut. This visually unclear highlighting effect becomes problematic when the user wants to use the keyboard to select and confirm the desired action because it can be difficult to see which option is currently selected.

The screen should have a much more clear indicator about which option is selected. Ideally it should not only be a change of colour like currently, but instead have an additional indicator such as a clearly visible rectangular selector with a distinct colour.
Comment 1 Filip Fila 2019-03-07 22:56:21 UTC
Git commit 99dd92635f27e6a64efe2ac6d803dcf8a3608752 by Filip Fila.
Committed on 07/03/2019 at 22:56.
Pushed by filipf into branch 'master'.

[Lock, Login, and Logout screen] Adjust visual feedback of action buttons

Unlike in the logout screen, our action buttons in the SDDM theme currently offer no visual feedback when interacted with. This patch adds a minimal yet effective amount of opacity shifting, as well as a transparent circle behind the button. The same circle is added to logout screen, where it remains always visible to better indicate the chosen option.

Test Plan:



Reviewers: rooty, ngraham, #vdg, #plasma

Reviewed By: rooty, ngraham, #vdg

Subscribers: davidedmundson, plasma-devel

Tags: #plasma

Maniphest Tasks: T10325

Differential Revision: https://phabricator.kde.org/D19479

M  +26   -0    lookandfeel/contents/components/ActionButton.qml
M  +2    -0    lookandfeel/contents/logout/LogoutButton.qml