Bug 393010 - Krita 4.0.1 fails to build on armv7l
Summary: Krita 4.0.1 fails to build on armv7l
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: General (show other bugs)
Version: 4.0.1
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-11 14:05 UTC by Wolfgang Bauer
Modified: 2018-05-08 07:18 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Wolfgang Bauer 2018-04-11 14:05:20 UTC
In file included from /home/abuild/rpmbuild/BUILD/krita-4.0.1/libs/pigment/compositeops/KoOptimizedCompositeOpFactoryPerArch.h:24:0,
                 from /home/abuild/rpmbuild/BUILD/krita-4.0.1/libs/pigment/compositeops/KoOptimizedCompositeOpFactory.cpp:20:
/home/abuild/rpmbuild/BUILD/krita-4.0.1/libs/pigment/compositeops/KoVcMultiArchBuildSupport.h:23:10: fatal error: config-vc.h: No such file or directory
 #include "config-vc.h"
          ^~~~~~~~~~~~~
compilation terminated.


This didn't happen with 4.0.0.

IMO, this change causes it:
https://cgit.kde.org/krita.git/commit/?id=bc400ff2bd6d0effea75b976a61a6f09634750cd
The config-vc.h file creation should probably stay outside the if()/endif()...
Comment 1 Halla Rempt 2018-04-11 14:06:39 UTC
Did you try that change? If so, we can simply push it.
Comment 2 Wolfgang Bauer 2018-04-11 14:16:06 UTC
(In reply to Boudewijn Rempt from comment #1)
> Did you try that change? If so, we can simply push it.

I don't understand, that change is already in 4.0.1, it causes the failure AFAICT.

Or do you mean I should try to move the line below the endif()?
Haven't done that yet, but will.
Comment 3 Halla Rempt 2018-04-11 15:02:44 UTC
Yes, I mean that you should try the change moving the line. I cannot test with arm.
Comment 4 Wolfgang Bauer 2018-04-11 15:18:01 UTC
Confirmed.

This patch gets rid of the error:
diff --git a/CMakeLists.txt b/CMakeLists.txt
index bef818bc0f..f8658a11d1 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -630,8 +630,8 @@ if (NOT ${CMAKE_SYSTEM_PROCESSOR} MATCHES "arm")
             PURPOSE "Required by the Krita for vectorization")
         macro_bool_to_01(Vc_FOUND HAVE_VC)
     endif()
-    configure_file(config-vc.h.cmake ${CMAKE_CURRENT_BINARY_DIR}/config-vc.h )
 endif()
+configure_file(config-vc.h.cmake ${CMAKE_CURRENT_BINARY_DIR}/config-vc.h )
 
 if(HAVE_VC)
     message(STATUS "Vc found!")

The build still fails, but that's a different story, something related to OpenGL... (that happened before)
Comment 5 Halla Rempt 2018-04-11 17:27:03 UTC
Git commit d3eb595b444d5b198189404448e93121d7796d17 by Boudewijn Rempt.
Committed on 11/04/2018 at 17:26.
Pushed by rempt into branch 'master'.

Fix build on ARM (partly)
(cherry picked from commit 39e28e703aa8144c403c1ee53afc47c0121908c1)

M  +1    -1    CMakeLists.txt

https://commits.kde.org/krita/d3eb595b444d5b198189404448e93121d7796d17
Comment 6 Halla Rempt 2018-04-11 17:27:15 UTC
Thanks. I've pushed that change.
Comment 7 Wolfgang Bauer 2018-04-11 18:02:19 UTC
Thanks.

FYI:
The other build failure I mentioned (related to OpenGL) may be related to how Qt is built on openSUSE AFAIK.
Our ARM guys are aware of the issue though, I'll let them handle it.

I just noticed this new problem when I updated krita today, and thought it was a good idea to get it fixed. ;-)

And IMHO, it just seems logical to have config-vc.h created in any case, as that defines HAVE_VC for the rest of the source.
Comment 8 Halla Rempt 2018-04-11 18:10:36 UTC
Yes, definitely.
Comment 9 Halla Rempt 2018-05-02 11:54:42 UTC
Git commit b832b5f508c6f2378e47732f7615bd13fa41a48d by Boudewijn Rempt.
Committed on 02/05/2018 at 11:54.
Pushed by rempt into branch 'krita/4.0'.

Fix build on ARM (partly)
(cherry picked from commit 39e28e703aa8144c403c1ee53afc47c0121908c1)
(cherry picked from commit 55e1d8deaf98721ed3fdaf72e4a6f942ea5b93a7)

M  +1    -1    CMakeLists.txt

https://commits.kde.org/krita/b832b5f508c6f2378e47732f7615bd13fa41a48d
Comment 10 Halla Rempt 2018-05-08 07:18:39 UTC
Git commit 39e28e703aa8144c403c1ee53afc47c0121908c1 by Boudewijn Rempt.
Committed on 11/04/2018 at 17:25.
Pushed by rempt into branch 'rempt/update-frameworks'.

Fix build on ARM (partly)

M  +1    -1    CMakeLists.txt

https://commits.kde.org/krita/39e28e703aa8144c403c1ee53afc47c0121908c1