Bug 392885 - Tab loading spinner not always replaced with website's icon
Summary: Tab loading spinner not always replaced with website's icon
Status: RESOLVED FIXED
Alias: None
Product: Falkon
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: David Rosca
URL: https://smarkets.com/
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-08 17:28 UTC by Richard Ullger
Modified: 2018-04-11 16:36 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 3.0.1


Attachments
Tab spinner with tab context menu (35.17 KB, image/png)
2018-04-09 10:42 UTC, Richard Ullger
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Richard Ullger 2018-04-08 17:28:30 UTC
The spinner displayed on a tab while a page is loading isn't always getting replaced with the websites icon once the page has finished loading.

While a page is loading the reload page icon gets replaced with a stop icon. Once the page has loaded, the stop icon gets replaced with the reload page icon but the tab still shows the spinner.

I can reproduce this with the steps below...

1. Load the above url (https://smarkets.com/). This is a betting exchange. The website icon is displayed on the tab.
2. Click on the Smarkets logo in the top left of the page to load the website's homepage. The tab loading spinner is never replaced. This can also be reproduced by clicking on one of the events.

This is reproducible while navigating this and other websites.

Arch Linux kde_unstable repo
qt5-webengine 5.11.0beta2-2
falkon 3.0.0 rebuilt for 5.11.0beta2-2
   patch https://bugs.kde.org/attachment.cgi?id=111901&action=edit applied

The issue is also present with the current Arch versions...
extra/qt5-webengine 5.10.1-1
falkon 3.0.0-1

when creating this bug report, the version list only contained unspecified.
Comment 1 David Rosca 2018-04-09 09:16:58 UTC
Can't reproduce (load spinner disappears), but I can reproduce issue related to this - in right click it always show "Stop" action which should only be visible when page is loading.
Comment 2 Richard Ullger 2018-04-09 10:42:25 UTC
Created attachment 111919 [details]
Tab spinner with tab context menu

The context menu shows the option to reload the tab while the load spinner is still visible.
Comment 3 David Rosca 2018-04-09 10:44:29 UTC
Sorry for not being clear, but I meant right click context menu in website, not on the tabbar.
Comment 4 Richard Ullger 2018-04-09 11:08:13 UTC
I only get the 'Stop' option in the page context menu where the tab contains a load spinner. If the tab has been refreshed with the website's icon, I see the 'reload' option in the page context menu.

In the tabbar context menu I see a 'Stop' option while the page is actually still loading. When the page has loaded I see a 'Reload' option even if the tab is still showing the load spinner.

I get a similar result at https://www.betfair.com but in this case the tab load spinner is never replaced with the website's icon.
Comment 5 The_assassin 2018-04-09 12:06:44 UTC
@Richard Ullger 

The "load spinner" problem is a Qt bug: https://bugreports.qt.io/browse/QTBUG-65223.

There is a workaround in Falkon source, but it's currently adjusted only for Qt 5.10.*
Comment 6 David Rosca 2018-04-09 14:03:27 UTC
> The "load spinner" problem is a Qt bug: https://bugreports.qt.io/browse/QTBUG-65223.

Yes, but I was under impression that it was fixed in 5.11. At least with Qt 5.11 beta it looked fine.

Can you please confirm that applying that workaround also for Qt 5.11 fixes the issue?
Comment 7 The_assassin 2018-04-09 14:25:29 UTC
>Can you please confirm that applying that workaround also for Qt 5.11 fixes the issue?

Sorry, but currently i dont have compiled Qt 5.11 to try with.
I just thought you are with 5.10 as well as i noticed the bug is not marked as fixed yet, so that why a was sure there is the problem...

@Richard Ullger, i hope you can help here! You may use this patch: https://src.fedoraproject.org/cgit/rpms/falkon.git/plain/falkon-3.0.0-qtbug-65223-workaround.patch
Comment 8 Richard Ullger 2018-04-09 17:58:57 UTC
@private2.6.3 Falkon built against qt5 5.11.0beta3 which is now the version in the kde_unstable Arch repo with your patch applied fixes the issue.

Many thanks.
Comment 9 David Rosca 2018-04-11 16:36:02 UTC
Git commit 17d45d718cb2e3912c9494491232ab9cdf9b5a9c by David Rosca.
Committed on 11/04/2018 at 16:32.
Pushed by drosca into branch 'Falkon/3.0'.

WebPage: Use load finished workaround unconditionally

It seems to be broken, again, with QtWebEngine 5.11.
FIXED-IN: 3.0.1

M  +6    -8    src/lib/webengine/webpage.cpp

https://commits.kde.org/falkon/17d45d718cb2e3912c9494491232ab9cdf9b5a9c