Bug 392853 - Ring phone doesen't actually ring phone
Summary: Ring phone doesen't actually ring phone
Status: RESOLVED FIXED
Alias: None
Product: kdeconnect
Classification: Applications
Component: common (show other bugs)
Version: 1.8
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Albert Vaca Cintora
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-08 03:18 UTC by Zakhar
Modified: 2018-04-09 17:01 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Zakhar 2018-04-08 03:18:37 UTC
Whilst using KDE connect I tried out the "Ring my phone" function and for some reason my phone (brand new unlocked phone) does not make ANY audible tones. All that happens is the "Found" notification popping up.
Comment 1 Matthijs Tijink 2018-04-08 10:19:19 UTC
Hmm weird. Can you specify your KDE Connect version (on Android)?

Could you specify some of your settings?
 - Alarm volume (and try if changing it helps)
 - Alarm ringtone
Comment 2 Zakhar 2018-04-08 22:12:20 UTC
Alarm volume = max
alarm ringtone = default

phone is Android 7.0, kdeconnect-1.2.1-r2 on pc
Comment 3 Matthijs Tijink 2018-04-09 17:01:04 UTC
Git commit 2cd7d4b7a99aa0073e1a29627b5b10628fa840fd by Matthijs Tijink.
Committed on 09/04/2018 at 17:00.
Pushed by mtijink into branch 'master'.

Fix default Find My Phone ringtone

Summary:
Previously, if the user hadn't set a ringtone, the code raised an exception (because an empty string isn't an uri). Thus, no sound was played.

This fixes it.

Test Plan: Without having set a ringtone, it works. Otherwise, it works too.

Reviewers: #kde_connect, albertvaka

Reviewed By: #kde_connect, albertvaka

Subscribers: nicolasfella, sredman, #kde_connect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D12070

M  +9    -2    src/org/kde/kdeconnect/Plugins/FindMyPhonePlugin/FindMyPhoneActivity.java

https://commits.kde.org/kdeconnect-android/2cd7d4b7a99aa0073e1a29627b5b10628fa840fd