Bug 392830 - Different icons for "Switch User" in lock screen versus login screen
Summary: Different icons for "Switch User" in lock screen versus login screen
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Theme - Breeze (show other bugs)
Version: master
Platform: Kubuntu Linux
: NOR normal
Target Milestone: 1.0
Assignee: visual-design
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-07 15:50 UTC by Scott Harvey
Modified: 2018-04-08 21:22 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Unlock screen icon (96.44 KB, image/jpeg)
2018-04-07 15:50 UTC, Scott Harvey
Details
Login screen icon (62.89 KB, image/jpeg)
2018-04-07 15:51 UTC, Scott Harvey
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Scott Harvey 2018-04-07 15:50:38 UTC
Created attachment 111888 [details]
Unlock screen icon

The icons to change users are inconsistent between the normal session login screen and the unlock screen. The titles are also inconsistent. Shouldn't they be the same?

Personally, I prefer the "avatar with arrow" version from the lock screen, as opposed to the magnifying glass on the login screen. A magnifying glass icon is most often used for a search function; it's got no relationship to changing users.

(Sorry for the phone photos... best I could do.)
Comment 1 Scott Harvey 2018-04-07 15:51:25 UTC
Created attachment 111889 [details]
Login screen icon
Comment 2 Scott Harvey 2018-04-07 15:54:51 UTC
I can work on making changes, if any are agreed upon.
Comment 3 Nate Graham 2018-04-07 23:41:15 UTC
Technically they are different functions, but I agree with you that the screen locker icon is the better icon, and appropriate to the "log in as other user" function on the lock screen.

Looks like the SDDM breeze theme uses the "system-search" icon, while the kscreenlocker breeze theme uses "system-switch-user". This change would need to be made in plasma-workspace, in the SDDM breeze theme (plasma-workspace/sddm-theme/Main.qml)
Comment 4 Nate Graham 2018-04-08 21:22:17 UTC
Git commit 7d19c5059b1041d85e2b8299fffbaf81c23c0723 by Nathaniel Graham, on behalf of Scott Harvey.
Committed on 08/04/2018 at 21:22.
Pushed by ngraham into branch 'master'.

Change "different user" icon on login screen

Summary:
Replace "different user" icon on SDDM login screen to match icon used on
unlock screen. Original icon was `system-search`, now changed to `system-switch-user`.

Test Plan:
- Recompile `plasma-workspace`
- Log out of current session
- Check that `Different User` icon is now a figure with an arrow

Reviewers: ngraham, #vdg, #plasma, davidedmundson

Reviewed By: ngraham, #vdg, #plasma, davidedmundson

Subscribers: abetts, sebas, davidedmundson, #vdg, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D12036

M  +1    -1    sddm-theme/Main.qml

https://commits.kde.org/plasma-workspace/7d19c5059b1041d85e2b8299fffbaf81c23c0723