Bug 392782 - Now Playing should use the actual album art in place of a humongous icon
Summary: Now Playing should use the actual album art in place of a humongous icon
Status: RESOLVED FIXED
Alias: None
Product: Elisa
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Matthieu Gallien
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-05 22:12 UTC by Nate Graham
Modified: 2018-04-17 18:03 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Tiny album art and humongous icon (98.75 KB, image/png)
2018-04-05 22:12 UTC, Nate Graham
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2018-04-05 22:12:50 UTC
Created attachment 111864 [details]
Tiny album art and humongous icon

Elisa nightly Flatpak build from kdeapps repo on Kubuntu 17.10

The attached screenshot says it all. Instead of showing a tiny album art image and a gigantic icon, display the album art in that same place instead.
Comment 1 Matthieu Gallien 2018-04-09 09:44:23 UTC
Thanks for your report.
I will have a look at it. One problem I foresee is that the cover should put not be like to the currently playing track. What is exactly your point of view ?
Comment 2 Matthieu Gallien 2018-04-09 09:48:27 UTC
Sorry for my bad comment. I should not use my phone.

Thanks for your report. I will have a look at it.

One problem I foresee is that the cover could be linked to the currently playing track. The other possibility is to use the first cover even if it is strange.

What is exactly your point of view ?
Comment 3 Alexander Stippich 2018-04-09 18:17:11 UTC
Imho neither option is good. First cover doesn't make any sense. Currently playing album would just duplicate the header bar.
I added the icon because I wanted to provide some recognition for the user with view selector on the left and the different views. If the icon is considered too ugly, I would opt to just remove it again.
Comment 4 Nate Graham 2018-04-10 17:51:53 UTC
(In reply to Alexander Stippich from comment #3)
> Imho neither option is good. First cover doesn't make any sense.

That's true, yeah.

> Currently playing album would just duplicate the header bar.

Hmm, that's also true.

> I added the icon because I wanted to provide some recognition for the user
> with view selector on the left and the different views. If the icon is
> considered too ugly, I would opt to just remove it again.

At least with the Breeze icon set, I think it is rather ugly at that size--but more importantly, it's not necessary. It doesn't communicate any information about anything. My vote would be to remove it.
Comment 5 Matthieu Gallien 2018-04-10 20:31:39 UTC
(In reply to Nate Graham from comment #4)
> (In reply to Alexander Stippich from comment #3)
> > Imho neither option is good. First cover doesn't make any sense.
> 
> That's true, yeah.
> 
> > Currently playing album would just duplicate the header bar.
> 
> Hmm, that's also true.
> 
> > I added the icon because I wanted to provide some recognition for the user
> > with view selector on the left and the different views. If the icon is
> > considered too ugly, I would opt to just remove it again.
> 
> At least with the Breeze icon set, I think it is rather ugly at that
> size--but more importantly, it's not necessary. It doesn't communicate any
> information about anything. My vote would be to remove it.

I had ask Alex to add it because other views have already big icons. I was always unsure about it? Alex, can you remove it ?
Comment 6 Alexander Stippich 2018-04-12 17:06:05 UTC
Sure, will do
Comment 7 Alexander Stippich 2018-04-17 18:03:25 UTC
Somehow that wasn't automatically closed, fixed by

https://phabricator.kde.org/R255:f6df58210fe25b30569f9c92e4f5d08ec06a443d