Bug 392714 - Change Krita text tool's font size from a droplist to input box with units
Summary: Change Krita text tool's font size from a droplist to input box with units
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Tool/Text (show other bugs)
Version: nightly build (please specify the git hash!)
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-04 12:54 UTC by Tyson Tan
Modified: 2018-04-09 08:59 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
GIMP's font size control for reference. (2.39 KB, image/png)
2018-04-04 12:54 UTC, Tyson Tan
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tyson Tan 2018-04-04 12:54:34 UTC
Created attachment 111817 [details]
GIMP's font size control for reference.

krita-4.1.0-pre-alpha-39cc9f9-x86_64.appimage

Krita's text tool uses a droplist to control font size. However the values are hardcoded with increasingly bigger intervals. These preset values are not sufficient. In most cases it is impossible to get an ideal font size with this current setup. 

As a workaround for now, we can use transformation tool on Text objects to do the fine-tuning. However, this is probably not a new user would think of. Most people would like to get it right in the editor because in that way a single font size can be easily used across all text blocks.

I suggest we:
1) Replace the droplist with an input box with +/- buttons.
2) Add units as a droplist. 
3) Allow point values like 12.5 pt for better fine-tunning.
Comment 1 Halla Rempt 2018-04-04 13:15:33 UTC
Git commit 3a09d0664ecdfefe9fd431c7da2fbf513acb2f35 by Boudewijn Rempt.
Committed on 04/04/2018 at 13:15.
Pushed by rempt into branch 'master'.

Use the FontSizeAction from the old text tool in the svg text tool

M  +1    -0    plugins/tools/svgtexttool/CMakeLists.txt
A  +155  -0    plugins/tools/svgtexttool/FontSizeAction.cpp     [License: LGPL (v2)]
A  +72   -0    plugins/tools/svgtexttool/FontSizeAction.h     [License: LGPL (v2+)]
M  +8    -14   plugins/tools/svgtexttool/SvgTextEditor.cpp
M  +1    -1    plugins/tools/svgtexttool/SvgTextEditor.h

https://commits.kde.org/krita/3a09d0664ecdfefe9fd431c7da2fbf513acb2f35
Comment 2 Tyson Tan 2018-04-04 13:56:01 UTC
Thank you, Boud!
Comment 3 Halla Rempt 2018-04-09 08:59:23 UTC
Git commit 4492c25170ba50906c806ebc5a4022ce195157c1 by Boudewijn Rempt.
Committed on 09/04/2018 at 08:58.
Pushed by rempt into branch 'krita/4.0'.

Use the FontSizeAction from the old text tool in the svg text tool
(cherry picked from commit 3a09d0664ecdfefe9fd431c7da2fbf513acb2f35)

M  +1    -0    plugins/tools/svgtexttool/CMakeLists.txt
A  +155  -0    plugins/tools/svgtexttool/FontSizeAction.cpp     [License: LGPL (v2)]
A  +72   -0    plugins/tools/svgtexttool/FontSizeAction.h     [License: LGPL (v2+)]
M  +8    -14   plugins/tools/svgtexttool/SvgTextEditor.cpp
M  +1    -1    plugins/tools/svgtexttool/SvgTextEditor.h

https://commits.kde.org/krita/4492c25170ba50906c806ebc5a4022ce195157c1