Bug 392683 - Rotating text and selecting the perspective option crashes krita
Summary: Rotating text and selecting the perspective option crashes krita
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Usability (show other bugs)
Version: 4.0.1
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Dmitry Kazakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-03 17:53 UTC by Antti Savolainen
Modified: 2018-05-08 11:29 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Savolainen 2018-04-03 17:53:24 UTC
Overview:

    Krita crashes when the perspective tool is selected after transforming text and selecting it again. Also happens on all the other tool options.

Steps to Reproduce: 

    1) Create a text

    2) Use the transform tool on the text and press enter to apply

    3) Reselect the shape

    4) Select the 'Perspective' tool option

Actual Results: 

    The application crashed.

Expected Results:

    Krita should keep working

Build Date & Platform:

    krita 4.1.0-pre-alpha

Additional Information: Any other useful information. 

    https://webmshare.com/MyoDL Recorded video of said crash
    
    Terminal output at the moment of the crash:
    ASSERT (krita): "!m_currentArgs.continuedTransform()" in file /build/krita-testing-Gb4vEh/krita-testing-4.0.0/plugins/tools/tool_transform2/kis_tool_transform.cc, line 1108
Comment 1 Antti Savolainen 2018-04-03 17:55:01 UTC
Stacktrace of coredumpctl -r gdb

Stack trace of thread 4443:
                #0  0x00007f5ce9b3a0bb __GI_raise (libc.so.6)
                #1  0x00007f5ce9b3bf5d __GI_abort (libc.so.6)
                #2  0x00007f5cea517107 _ZNK14QMessageLogger5fatalEPKcz (libQt5Core.so.5)
                #3  0x00007f5cebdcffb9 n/a (libkritaglobal.so.17)
                #4  0x00007f5cb0c14e08 n/a (kritatooltransform.so)
                #5  0x00007f5cb0c40bcd n/a (kritatooltransform.so)
                #6  0x00007f5cea7388e5 _ZN11QMetaObject8activateEP7QObjectiiPPv (libQt5Core.so.5)
                #7  0x00007f5cb0c182d8 n/a (kritatooltransform.so)
                #8  0x00007f5cb0c4068e n/a (kritatooltransform.so)
                #9  0x00007f5cea7388e5 _ZN11QMetaObject8activateEP7QObjectiiPPv (libQt5Core.so.5)
                #10 0x00007f5ceb640572 _ZN15QAbstractButton7clickedEb (libQt5Widgets.so.5)
                #11 0x00007f5ceb64078a n/a (libQt5Widgets.so.5)
                #12 0x00007f5ceb641b6a n/a (libQt5Widgets.so.5)
                #13 0x00007f5ceb641d54 _ZN15QAbstractButton17mouseReleaseEventEP11QMouseEvent (libQt5Widgets.so.5)
                #14 0x00007f5ceb62108a _ZN11QToolButton17mouseReleaseEventEP11QMouseEvent (libQt5Widgets.so.5)
                #15 0x00007f5ceb4c4dc8 _ZN7QWidget5eventEP6QEvent (libQt5Widgets.so.5)
                #16 0x00007f5ceb621124 _ZN11QToolButton5eventEP6QEvent (libQt5Widgets.so.5)
                #17 0x00007f5ceb48446c _ZN19QApplicationPrivate13notify_helperEP7QObjectP6QEvent (libQt5Widgets.so.5)
                #18 0x00007f5ceb48c28f _ZN12QApplication6notifyEP7QObjectP6QEvent (libQt5Widgets.so.5)
                #19 0x00007f5cecb54847 _ZN14KisApplication6notifyEP7QObjectP6QEvent (libkritaui.so.17)
                #20 0x00007f5cea709de8 _ZN16QCoreApplication15notifyInternal2EP7QObjectP6QEvent (libQt5Core.so.5)
                #21 0x00007f5ceb48b262 _ZN19QApplicationPrivate14sendMouseEventEP7QWidgetP11QMouseEventS1_S1_PS1_R8QPointerIS0_Eb (libQt5Widgets.so.5)
                #22 0x00007f5ceb4df94b n/a (libQt5Widgets.so.5)
                #23 0x00007f5ceb4e1fba n/a (libQt5Widgets.so.5)
                #24 0x00007f5ceb48446c _ZN19QApplicationPrivate13notify_helperEP7QObjectP6QEvent (libQt5Widgets.so.5)
                #25 0x00007f5ceb48bd34 _ZN12QApplication6notifyEP7QObjectP6QEvent (libQt5Widgets.so.5)
                #26 0x00007f5cecb54847 _ZN14KisApplication6notifyEP7QObjectP6QEvent (libkritaui.so.17)
                #27 0x00007f5cea709de8 _ZN16QCoreApplication15notifyInternal2EP7QObjectP6QEvent (libQt5Core.so.5)
                #28 0x00007f5ceacc8f43 _ZN22QGuiApplicationPrivate17processMouseEventEPN29QWindowSystemInterfacePrivate10MouseEventE (libQt5Gui.so.5)
                #29 0x00007f5ceaccaa25 _ZN22QGuiApplicationPrivate24processWindowSystemEventEPN29QWindowSystemInterfacePrivate17WindowSystemEventE (libQt5Gui.so.5)
                #30 0x00007f5ceaca2cab _ZN22QWindowSystemInterface22sendWindowSystemEventsE6QFlagsIN10QEventLoop17ProcessEventsFlagEE (libQt5Gui.so.5)
                #31 0x00007f5cd7f1f5a0 n/a (libQt5XcbQpa.so.5)
                #32 0x00007f5ce2242fb7 g_main_context_dispatch (libglib-2.0.so.0)
                #33 0x00007f5ce22431f0 n/a (libglib-2.0.so.0)
                #34 0x00007f5ce224327c g_main_context_iteration (libglib-2.0.so.0)
                #35 0x00007f5cea76247f _ZN20QEventDispatcherGlib13processEventsE6QFlagsIN10QEventLoop17ProcessEventsFlagEE (libQt5Core.so.5)
                #36 0x00007f5cea707e3a _ZN10QEventLoop4execE6QFlagsINS_17ProcessEventsFlagEE (libQt5Core.so.5)
                #37 0x00007f5cea710da4 _ZN16QCoreApplication4execEv (libQt5Core.so.5)
                #38 0x0000561909a7bc1e main (krita)
                #39 0x00007f5ce9b241c1 __libc_start_main (libc.so.6)
                #40 0x0000561909a7c62a _start (krita)
                
                Stack trace of thread 4444:
                #0  0x00007f5ce9c0b951 __GI___poll (libc.so.6)
                #1  0x00007f5ce7fb8747 n/a (libxcb.so.1)
                #2  0x00007f5ce7fba53a xcb_wait_for_event (libxcb.so.1)
                #3  0x00007f5cd7ebcf09 n/a (libQt5XcbQpa.so.5)
                #4  0x00007f5cea52c29d n/a (libQt5Core.so.5)
                #5  0x00007f5ce39347fc start_thread (libpthread.so.0)
                #6  0x00007f5ce9c17b5f __clone (libc.so.6)
                
                Stack trace of thread 4445:
                #0  0x00007f5ce9c0b951 __GI___poll (libc.so.6)
                #1  0x00007f5ce2243169 n/a (libglib-2.0.so.0)
                #2  0x00007f5ce224327c g_main_context_iteration (libglib-2.0.so.0)
                #3  0x00007f5ce22432c1 n/a (libglib-2.0.so.0)
                #4  0x00007f5ce226a645 n/a (libglib-2.0.so.0)
                #5  0x00007f5ce39347fc start_thread (libpthread.so.0)
                #6  0x00007f5ce9c17b5f __clone (libc.so.6)
                
                Stack trace of thread 4446:
                #0  0x00007f5ce9c0b951 __GI___poll (libc.so.6)
                #1  0x00007f5ce2243169 n/a (libglib-2.0.so.0)
                #2  0x00007f5ce2243502 g_main_loop_run (libglib-2.0.so.0)
                #3  0x00007f5ccda0eb26 n/a (libgio-2.0.so.0)
                #4  0x00007f5ce226a645 n/a (libglib-2.0.so.0)
                #5  0x00007f5ce39347fc start_thread (libpthread.so.0)
                #6  0x00007f5ce9c17b5f __clone (libc.so.6)
                
                Stack trace of thread 4447:
                #0  0x00007f5ce9c0b951 __GI___poll (libc.so.6)
                #1  0x00007f5ce2243169 n/a (libglib-2.0.so.0)
                #2  0x00007f5ce224327c g_main_context_iteration (libglib-2.0.so.0)
                #3  0x00007f5cea76247f _ZN20QEventDispatcherGlib13processEventsE6QFlagsIN10QEventLoop17ProcessEventsFlagEE (libQt5Core.so.5)
                #4  0x00007f5cea707e3a _ZN10QEventLoop4execE6QFlagsINS_17ProcessEventsFlagEE (libQt5Core.so.5)
                #5  0x00007f5cea5273ca _ZN7QThread4execEv (libQt5Core.so.5)
                #6  0x00007f5ce3b61e45 n/a (libQt5DBus.so.5)
                #7  0x00007f5cea52c29d n/a (libQt5Core.so.5)
                #8  0x00007f5ce39347fc start_thread (libpthread.so.0)
                #9  0x00007f5ce9c17b5f __clone (libc.so.6)
                
                Stack trace of thread 4452:
                #0  0x00007f5ce393b072 futex_wait_cancelable (libpthread.so.0)
                #1  0x00007f5cea52d6cb _ZN14QWaitCondition4waitEP6QMutexm (libQt5Core.so.5)
                #2  0x00007f5cea525f83 _ZN10QSemaphore10tryAcquireEii (libQt5Core.so.5)
                #3  0x00007f5ce7862b6a _ZN18KisTileDataSwapper3runEv (libkritaimage.so.17)
                #4  0x00007f5cea52c29d n/a (libQt5Core.so.5)
                #5  0x00007f5ce39347fc start_thread (libpthread.so.0)
                #6  0x00007f5ce9c17b5f __clone (libc.so.6)
                
                Stack trace of thread 4456:
                #0  0x00007f5ce9c0b951 __GI___poll (libc.so.6)
                #1  0x00007f5ce2243169 n/a (libglib-2.0.so.0)
                #2  0x00007f5ce224327c g_main_context_iteration (libglib-2.0.so.0)
                #3  0x00007f5cea76247f _ZN20QEventDispatcherGlib13processEventsE6QFlagsIN10QEventLoop17ProcessEventsFlagEE (libQt5Core.so.5)
                #4  0x00007f5cea707e3a _ZN10QEventLoop4execE6QFlagsINS_17ProcessEventsFlagEE (libQt5Core.so.5)
                #5  0x00007f5cea5273ca _ZN7QThread4execEv (libQt5Core.so.5)
                #6  0x00007f5cac97bf45 n/a (libQt5Qml.so.5)
                #7  0x00007f5cea52c29d n/a (libQt5Core.so.5)
                #8  0x00007f5ce39347fc start_thread (libpthread.so.0)
                #9  0x00007f5ce9c17b5f __clone (libc.so.6)
                
                Stack trace of thread 4457:
                #0  0x00007f5ce9c0b951 __GI___poll (libc.so.6)
                #1  0x00007f5ce2243169 n/a (libglib-2.0.so.0)
                #2  0x00007f5ce224327c g_main_context_iteration (libglib-2.0.so.0)
                #3  0x00007f5cea76247f _ZN20QEventDispatcherGlib13processEventsE6QFlagsIN10QEventLoop17ProcessEventsFlagEE (libQt5Core.so.5)
                #4  0x00007f5cea707e3a _ZN10QEventLoop4execE6QFlagsINS_17ProcessEventsFlagEE (libQt5Core.so.5)
                #5  0x00007f5cea5273ca _ZN7QThread4execEv (libQt5Core.so.5)
                #6  0x00007f5cac185846 n/a (libQt5Quick.so.5)
                #7  0x00007f5cea52c29d n/a (libQt5Core.so.5)
                #8  0x00007f5ce39347fc start_thread (libpthread.so.0)
                #9  0x00007f5ce9c17b5f __clone (libc.so.6)
Comment 2 Scott Petrovic 2018-04-03 18:02:18 UTC
This crash existed in an older 4.0 build that I have...but I cannot get this crash in the latest build from master on my Ubuntu 17.10 box. 

There have been some crashes fixed recently in the text tool. Could you try to test the nightly build tomorrow and see if you still get this crash?
Comment 3 Antti Savolainen 2018-04-03 18:15:24 UTC
The 2 crashes that I reported previously have been fixed in this build that I have (krita-testing from the Krita Lime PPA). The PPA doesn't have anything newer.
Comment 4 Halla Rempt 2018-04-03 18:16:37 UTC
Well, there's an assert, so that gives a point from which to investigate, even though the backtrace is useless because there are no debug symbols. Which distribution is this, and is this with an appimage, or home-built binaries, or distribution binaries?
Comment 5 Antti Savolainen 2018-04-03 18:23:26 UTC
It's Xubuntu, and the binaries are krita-testing from the Krita Lime PPA https://launchpad.net/~kritalime/+archive/ubuntu/ppa
Comment 6 Dmitry Kazakov 2018-04-06 08:40:10 UTC
Git commit 36d2430da6899b6d31e176b2cd5c3cda25a37ae8 by Dmitry Kazakov.
Committed on 06/04/2018 at 08:39.
Pushed by dkazakov into branch 'master'.

Fix an assert in continued mode of Transform Tool

The transformation arguments should be reset when the tool
refuses to start transformation on some kinds of layers
(e.g. vector layers). Otherwise, the args still keep the pointer
to the saved continued transformation, which might cause some
unexpected behavior.

M  +7    -0    plugins/tools/tool_transform2/kis_tool_transform.cc

https://commits.kde.org/krita/36d2430da6899b6d31e176b2cd5c3cda25a37ae8
Comment 7 Dmitry Kazakov 2018-04-07 13:46:03 UTC
Git commit 9ac35c8a57f3a4f02003bf1616fbea0c6bfee442 by Dmitry Kazakov.
Committed on 07/04/2018 at 13:28.
Pushed by dkazakov into branch 'krita/4.0'.

Fix an assert in continued mode of Transform Tool

The transformation arguments should be reset when the tool
refuses to start transformation on some kinds of layers
(e.g. vector layers). Otherwise, the args still keep the pointer
to the saved continued transformation, which might cause some
unexpected behavior.

M  +7    -0    plugins/tools/tool_transform2/kis_tool_transform.cc

https://commits.kde.org/krita/9ac35c8a57f3a4f02003bf1616fbea0c6bfee442