Bug 392664 - Use the dialog from baloo-widgets for tag editing
Summary: Use the dialog from baloo-widgets for tag editing
Status: CONFIRMED
Alias: None
Product: gwenview
Classification: Applications
Component: general (other bugs)
Version First Reported In: unspecified
Platform: openSUSE Linux
: NOR wishlist
Target Milestone: ---
Assignee: Gwenview Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-03 05:00 UTC by Michael Heidelbach
Modified: 2018-10-16 19:12 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Heidelbach 2018-04-03 05:00:03 UTC
Use the dialog from baloo-widgets (or something very similar) for tag editing. It will surprise me (as a user) less.
Comment 1 null 2018-04-03 15:35:42 UTC
Good idea in general, but it's not so simple:
- Gwenview has Previous/Next buttons to jump to another image (the history dropdown should be fixed to make them more useful, I guess…)
- Gwenview allows to add multiple tags without having to reopen the dialog

Nevertheless, Dolphin's dialog (which I assume is from baloo-widgets?) also has some nice features:
- Easy way to select and apply existing tags
- Good support for nested tags (type "/")

I'd imagine going forward like this would be best (because I'm very much in favour of unifying the experience everywhere):
- Add adding of multiple tags to Baloo (e.g. instead of "Save/Cancel" use "Add/Close", with "Add" not closing the dialog)
- Port Gwenview to Baloo's improved widget, add back navigation buttons (or find a better way to serve their use case)
Comment 2 Nate Graham 2018-04-03 15:38:33 UTC
+1, sounds like a plan. Definitely in favor of using common widgets here so they don't develop separately and each app can benefit from improvements made to the widget itself.