Bug 392510 - BBC service provider: can't get weather data since 03/2018
Summary: BBC service provider: can't get weather data since 03/2018
Status: RESOLVED FIXED
Alias: None
Product: kdeplasma-addons
Classification: Plasma
Component: Weather (show other bugs)
Version: 5.12.4
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Friedrich W. H. Kossebau
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-30 07:00 UTC by Philippe ROUBACH
Modified: 2018-03-31 12:25 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.12.5


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe ROUBACH 2018-03-30 07:00:36 UTC
opensuse 42.3
kde apps 17.12.3
kde framework 5.44
plasma 5.12.4

since update to plasma 5.12.4

wheather widget can't get data from bbcukmet

i get a message saying "time to get data is out"

if i try to change weather source to for example noaa then source is not changed
then
i can't make a test with another source
Comment 1 Friedrich W. H. Kossebau 2018-03-30 13:33:49 UTC
Thanks for the report. I have to confirm that apparently this week the RSS feed from BBC weather service seems to have changed
So it's just a coincidence with the update to Plasma 5.12.4 and not related, as the code pulling the data from the BBC web servers did not change in that upgrade, it also fails e.g. with Plasma 5.12.3.

Sadly the RSS feed urls used are hardcoded in the sources, so there is no config file which just would need to be edited.

I am currently trying some first patches and got things working again, seem the format of the RSS feed itself has not been changed. So hopefully I will get a first patch done tonight, and would also notice distributions to pick that up as patch.

> if i try to change weather source to for example noaa then source is not
> changed
> then
> i can't make a test with another source

What do you mean exactly with "change weather source", what actions have you done in the config UI?
Comment 2 Philippe ROUBACH 2018-03-30 13:37:38 UTC
> What do you mean exactly with "change weather source", what actions have you 
> done in the config UI?

in the setting ui i deselect bbcukmet and select noaa
Comment 3 Friedrich W. H. Kossebau 2018-03-30 13:45:36 UTC
(In reply to Philippe ROUBACH from comment #2)
> > What do you mean exactly with "change weather source", what actions have you 
> > done in the config UI?
> 
> in the setting ui i deselect bbcukmet and select noaa

I see. Seems the current UI is slightly confusing also for you then.
This selection of the weather service provider controls only which service providers will be queried when searching for the location string that has been entered in the text field.
So just changing the provider selection in that popup does not change anything else currently selected, it will only be used on the next location/station searching.

The whole location config UI needs a rework, too confusing for everybody :)
Comment 4 Philippe ROUBACH 2018-03-30 13:57:50 UTC
> So just changing the provider selection in that popup does not change anything 
> else currently selected, it will only be used on the next location/station 
> searching.

ok i changed weather provider to "wetter" and now i get again weather :)
Comment 5 Philippe ROUBACH 2018-03-30 13:59:29 UTC
also in settings > appearance 

"show temperature in compact mode" is in grey
Comment 6 Friedrich W. H. Kossebau 2018-03-30 14:04:17 UTC
(In reply to Philippe ROUBACH from comment #5)
> also in settings > appearance 
> 
> "show temperature in compact mode" is in grey

You are using the weather applet in the system tray, right?

In that case it is not possible to also show the temperature, as the applet has to be square, and there is no code yet to e.g. do an overlay of the temperature on the weather state icon. That's why the setting is disabled in that case. Though would need a related information to tell why. Another case where setting needs more improvement. Hopefully getting to that later this year.
Comment 7 Philippe ROUBACH 2018-03-30 14:05:30 UTC
ok thanks
Comment 8 Friedrich W. H. Kossebau 2018-03-30 15:24:11 UTC
Patch up for review at https://phabricator.kde.org/D11808
Comment 9 Friedrich W. H. Kossebau 2018-03-31 11:49:11 UTC
Git commit 558a29efc4c9f055799d23ee6c75464e24489e5a by Friedrich W. H. Kossebau.
Committed on 31/03/2018 at 11:48.
Pushed by kossebau into branch 'Plasma/5.12'.

[weather dataengine] Fix BBC provider to adapt to change RSS feed

Summary:
The urls of the BBC weather feeds seem to have changed, resulting in the
dataengine to use no longer existing urls.

I could not find the change documented somewhere and also do not know about
a contact person with BBC, so done based on examples on website, trial &
error.
There are some data issues visible in the new data feeds, so chance is the
feeds might see more rework and might break things again. But without any
contract or formal agreement we can just play catch-up.

Test Plan:
Existing configured weather applets using a location from a BBC weather
service work again.
Newly configured weather applets using a BBC weather service also work.

Reviewers: #plasma, jriddell, cfeck

Reviewed By: cfeck

Subscribers: cfeck, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D11808

M  +29   -18   dataengines/weather/ions/bbcukmet/ion_bbcukmet.cpp
M  +2    -2    dataengines/weather/ions/bbcukmet/ion_bbcukmet.h

https://commits.kde.org/plasma-workspace/558a29efc4c9f055799d23ee6c75464e24489e5a