Bug 392468 - [New Syntax] No Perl 6 syntax highlighting
Summary: [New Syntax] No Perl 6 syntax highlighting
Status: RESOLVED FIXED
Alias: None
Product: frameworks-syntax-highlighting
Classification: Frameworks and Libraries
Component: syntax (show other bugs)
Version: 5.44.0
Platform: Ubuntu Linux
: NOR wishlist
Target Milestone: ---
Assignee: KWrite Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-28 23:19 UTC by Daniel Green
Modified: 2019-09-24 08:52 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.63
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Green 2018-03-28 23:19:56 UTC
Perl 6 scripts are not syntax highlighted. They typically have an extension of .pl6, .p6, or .pm6.
Comment 1 Dominik Haumann 2018-05-29 21:00:53 UTC
Git commit cd9068f802bc3e5e5211ad1c0c765afc765986fe by Dominik Haumann.
Committed on 29/05/2018 at 20:59.
Pushed by dhaumann into branch 'master'.

Perl6: Add support for extensions .pl6, .p6, or .pm6
FIXED-IN: 5.47

M  +1    -1    data/syntax/perl.xml

https://commits.kde.org/syntax-highlighting/cd9068f802bc3e5e5211ad1c0c765afc765986fe
Comment 2 Daniel Green 2018-06-03 20:18:48 UTC
(In reply to Dominik Haumann from comment #1)
> Git commit cd9068f802bc3e5e5211ad1c0c765afc765986fe by Dominik Haumann.
> Committed on 29/05/2018 at 20:59.
> Pushed by dhaumann into branch 'master'.
> 
> Perl6: Add support for extensions .pl6, .p6, or .pm6
> FIXED-IN: 5.47
> 
> M  +1    -1    data/syntax/perl.xml
> 
> https://commits.kde.org/syntax-highlighting/
> cd9068f802bc3e5e5211ad1c0c765afc765986fe

FYI, Perl 6 (https://en.wikipedia.org/wiki/Perl_6) is a new, separate language from Perl 5. Using the Perl 5 highlighter for Perl 6 produces incorrect results.   Most (maybe all) of the other tools doing Perl 6 syntax highlighting have a separate file/ruleset for it (e.g., https://github.com/vim/vim/blob/master/runtime/syntax/perl6.vim). I'm not sure if it's considered bad form to change a ticket status away from RESOLVED, so I won't make that change, but it's what I'd suggest.
Comment 3 Dominik Haumann 2018-06-03 20:39:01 UTC
Then we need a Perl 6 guru who can write such a highlighting. I am not a guru...
Comment 4 Dominik Haumann 2019-08-28 18:50:13 UTC
Just tried to get some help here: https://www.reddit.com/r/perl/comments/cwp0nr/help_perl_6_highlighting_in_kate/?
Comment 5 Jonathan Poelen 2019-09-10 01:17:49 UTC
I started last week with pod6 and comments. It took a long time, it will not be finished before 1 month.
Comment 6 Jonathan Poelen 2019-09-23 22:13:05 UTC
Git commit 5e0343812c221f6bc402cb8d706870d58778b407 by Jonathan Poelen.
Committed on 23/09/2019 at 22:28.
Pushed by jpoelen into branch 'master'.

Add syntax definition for Perl6

Summary: BUG: 392468

Reviewers: #framework_syntax_highlighting, dhaumann, cullmann

Reviewed By: #framework_syntax_highlighting, cullmann

Subscribers: kwrite-devel, kde-frameworks-devel

Tags: #kate, #frameworks

Differential Revision: https://phabricator.kde.org/D24176

A  +651  -0    autotests/folding/highlight.pl6.fold
A  +658  -0    autotests/html/highlight.pl6.html
A  +651  -0    autotests/input/highlight.pl6
A  +651  -0    autotests/reference/highlight.pl6.ref
M  +1    -1    data/syntax/perl.xml
A  +1785 -0    data/syntax/perl6.xml

https://commits.kde.org/syntax-highlighting/5e0343812c221f6bc402cb8d706870d58778b407
Comment 7 Christoph Cullmann 2019-09-24 08:52:28 UTC
Thanks again Jonathan for all that work!