Bug 392455 - ktp-text-ui does not display content with Qt 5.11
Summary: ktp-text-ui does not display content with Qt 5.11
Status: RESOLVED FIXED
Alias: None
Product: telepathy
Classification: Frameworks and Libraries
Component: text-ui (show other bugs)
Version: git-latest
Platform: Other Linux
: NOR normal
Target Milestone: Future
Assignee: Telepathy Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-28 14:25 UTC by Eugene Shalygin
Modified: 2018-04-11 23:57 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eugene Shalygin 2018-03-28 14:25:48 UTC
Contents is not displayed and KIOExec error is shown instead. Seems like the problem is rejecting data:// URLs which are used by QWebEnginePage::setHtml(). The following patch makes it work.

diff --git a/lib/adium-theme-view.cpp b/lib/adium-theme-view.cpp
index 3b37285..3819788 100644
--- a/lib/adium-theme-view.cpp
+++ b/lib/adium-theme-view.cpp
@@ -68,6 +68,8 @@ bool AdiumThemePage::acceptNavigationRequest(const QUrl &url, QWebEnginePage::Na
         Q_EMIT nextConversation();
     } else if (url.fragment() == QLatin1String("x-prevConversation")) {
         Q_EMIT prevConversation();
+    } else if (url.scheme() == QLatin1String("data")) {
+        return true;
     } else {
         QDesktopServices::openUrl(url);
     }
Comment 1 David Edmundson 2018-03-28 15:02:42 UTC
Cool thanks.

If you have commit access, go ahead and ship it.
Otherwise I'll do it
Comment 2 Eugene Shalygin 2018-03-28 15:05:22 UTC
I don't have commit rights; please commit the change for me.
Comment 3 David Edmundson 2018-04-11 23:57:46 UTC
Merged, thanks