Bug 392391 - Missing icon(s) for Kirigami's new Inline Messages: dialog-positive (new) and lineart variants for dialog-warning and dialog-error
Summary: Missing icon(s) for Kirigami's new Inline Messages: dialog-positive (new) and...
Status: RESOLVED FIXED
Alias: None
Product: Breeze
Classification: Plasma
Component: Icons (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: visual-design
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-27 06:50 UTC by Eike Hein
Modified: 2018-04-10 17:58 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Kirigami's new Inline Messages component with duplicated dialog-information icon for Positive type messages (676.41 KB, image/png)
2018-03-27 06:51 UTC, Eike Hein
Details
KWidgetAddon's old KMessageWidget reference screenshot showing the checkmark used for its Positive type messages (16.14 KB, image/png)
2018-03-27 06:52 UTC, Eike Hein
Details
Missing lineart icons in Inline Messages when using Material style (354.56 KB, image/png)
2018-03-27 06:53 UTC, Eike Hein
Details
screenshot showing new icon (287.27 KB, image/png)
2018-04-10 14:59 UTC, Jonathan Riddell
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Eike Hein 2018-03-27 06:50:58 UTC
Kirigami is soon adding a new component called InlineMessage. I will attach a screenshot that makes it clear what they are.

Inline Messages come in four types and each has a default icon:
* Information -> dialog-information
* Positive -> missing
* Warning -> dialog-warning
* Error -> dialog-error

KMessageWidget (the older QWidget component for inline messages) used a checkmark icon for its Positive type. I will attach a screenshot of KMessageWidget for reference as well.

I would like Breeze to have a green dialog icon called "dialog-positive" with a checkmark.

Additionally, there is a problem with the icons for the Material/mobile appearance of Kirigami. If built for mobile, the Kirigami gallery extracts Breeze icons to ship with the app, but it seems to prefer the lineart versions. The dialog-warning and dialog-error icons currently don't seem to have such lineart versions, so they are not extracted and missing. I will attach a third screenshot showing this. The new dialog-positive icon would also need such a lineart version.
Comment 1 Eike Hein 2018-03-27 06:51:39 UTC
Created attachment 111668 [details]
Kirigami's new Inline Messages component with duplicated dialog-information icon for Positive type messages
Comment 2 Eike Hein 2018-03-27 06:52:22 UTC
Created attachment 111669 [details]
KWidgetAddon's old KMessageWidget reference screenshot showing the checkmark used for its Positive type messages
Comment 3 Eike Hein 2018-03-27 06:53:20 UTC
Created attachment 111670 [details]
Missing lineart icons in Inline Messages when using Material style

(Note: The general appearance of Inline Messages in this screenshot is an older development revision.)
Comment 4 andreas 2018-03-27 11:16:53 UTC
Git commit 9479c5872eeeb5f138897973376d48c2cb64a469 by andreas kainz.
Committed on 27/03/2018 at 11:21.
Pushed by andreask into branch 'master'.

BUG 392391 Missing icons for inline Messages

A  +13   -0    icons-dark/status/22/dialog-error.svg
R  +2    -2    icons-dark/status/22/dialog-password.svg [from: icons/status/24/dialog-information.svg - 052% similarity]
A  +13   -0    icons-dark/status/22/dialog-positive.svg
A  +13   -0    icons-dark/status/22/dialog-question.svg
A  +1    -0    icons-dark/status/64/dialog-positive.svg
A  +13   -0    icons/status/22/dialog-error.svg
M  +4    -4    icons/status/22/dialog-information.svg
R  +0    -0    icons/status/22/dialog-password.svg [from: icons/status/24/dialog-password.svg - 100% similarity]
A  +13   -0    icons/status/22/dialog-positive.svg
A  +13   -0    icons/status/22/dialog-question.svg
A  +1    -0    icons/status/64/dialog-positive.svg

https://commits.kde.org/breeze-icons/9479c5872eeeb5f138897973376d48c2cb64a469
Comment 5 Jonathan Riddell 2018-04-10 14:59:19 UTC
Created attachment 111940 [details]
screenshot showing new icon
Comment 6 Jonathan Riddell 2018-04-10 15:03:22 UTC
interestingly this changes the icons used by QMessageBox when set to Question, see 
https://bugs.kde.org/attachment.cgi?id=111940 which also shows kdialog not changing. mysterious.

The code that creates that partition question dialog box doesn't specify size
       messageBox = QtGui.QMessageBox(QtGui.QMessageBox.Question, title, msg,
                                       QtGui.QMessageBox.NoButton, self.ui)