Bug 392330 - "Open File" dialog: "Open File Manager" (file context menu) should select the file in Dolphin
Summary: "Open File" dialog: "Open File Manager" (file context menu) should select the...
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kio
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: 5.44.0
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: David Faure
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-25 19:19 UTC by Gregor Mi
Modified: 2018-03-26 22:26 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
"Open File Manager" context menu item (90.08 KB, image/png)
2018-03-25 19:20 UTC, Gregor Mi
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gregor Mi 2018-03-25 19:19:56 UTC
When I click the "Open File Manager" context menu item (see attached screenshot), Dolphin opens the containing folder. But no file is selected. It would be nice if the correct file would be selected.

This is a similar report: https://bugs.kde.org/show_bug.cgi?id=377510
Comment 1 Gregor Mi 2018-03-25 19:20:42 UTC
Created attachment 111643 [details]
"Open File Manager" context menu item
Comment 2 Nate Graham 2018-03-25 22:36:02 UTC
Looks like this is using custom code instead of KIO::highlightInFileManager(). That'll fix the issue as well as make the string use common terminology.
Comment 3 Nate Graham 2018-03-26 04:09:37 UTC
Here, have patch!

https://phabricator.kde.org/D11705
Comment 4 Nate Graham 2018-03-26 22:26:49 UTC
Git commit 05fe10da0034127b25c1e828c348af4035451d84 by Nathaniel Graham.
Committed on 26/03/2018 at 22:26.
Pushed by ngraham into branch 'master'.

Highlight selected items when showing parent folder from the open/save dialog

Summary:
For the open/save dialogs' {nav Open File Manager} context menu item, this patch adopts `KIO::highlightInFileManager()` and modernizes the name to match current convention ("Open Containing Folder").

Test Plan:
Deploy change and invoke the open dialog from Kate, then...
- Right-click on one or more items and select {nav Open Containing Folder}. See that items are highlighted in the window that opens.
- Right-click on the background (i.e. select nothing) and select {nav Open Containing Folder}. See that current folder is highlighted in the window that opens.

Reviewers: #frameworks, broulik

Reviewed By: broulik

Subscribers: broulik

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D11705

M  +8    -2    src/filewidgets/kdiroperator.cpp

https://commits.kde.org/kio/05fe10da0034127b25c1e828c348af4035451d84