Bug 392320 - Build fails without ECM, even when GUI is disabled
Summary: Build fails without ECM, even when GUI is disabled
Status: RESOLVED FIXED
Alias: None
Product: Heaptrack
Classification: Applications
Component: general (other bugs)
Version First Reported In: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Milian Wolff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-25 17:26 UTC by Zeno Endemann
Modified: 2018-03-26 08:08 UTC (History)
0 users

See Also:
Latest Commit: https://commits.kde.org/heaptrack/79cd7c8614ddfb91e92f3dcbb6acfb3d8f272253
Version Fixed/Implemented In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Zeno Endemann 2018-03-25 17:26:11 UTC 
The top level CMake file only does "find_package(ECM..." when UI building is enabled, but sub level CMake files do "include(ECMEnableSanitizers)" unconditionally.

Especially for cross compiling it would be nice to be able to build heaptrack (without the GUI) without ECM, as that is usually not in the toolchain.
Comment 1 Milian Wolff 2018-03-26 08:08:00 UTC 
Git commit 79cd7c8614ddfb91e92f3dcbb6acfb3d8f272253 by Milian Wolff.
Committed on 26/03/2018 at 08:07.
Pushed by mwolff into branch 'master'.

Fix compile when extra-cmake-modules aren't available

M  +3    -1    3rdparty/CMakeLists.txt
M  +3    -1    src/analyze/CMakeLists.txt
M  +3    -1    src/interpret/CMakeLists.txt
M  +4    -1    tests/auto/CMakeLists.txt

https://commits.kde.org/heaptrack/79cd7c8614ddfb91e92f3dcbb6acfb3d8f272253