Bug 392245 - Build fails with gstreamer 1.14
Summary: Build fails with gstreamer 1.14
Status: RESOLVED FIXED
Alias: None
Product: kamoso
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Aleix Pol
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-23 20:06 UTC by Antonio Rojas
Modified: 2018-04-04 13:43 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Antonio Rojas 2018-03-23 20:06:27 UTC
kamoso 18.03.80 doesn't build against gstreamer 1.14, build ok with 1.12.x

In file included from /usr/lib/glib-2.0/include/glibconfig.h:9:0,
                 from /usr/include/glib-2.0/glib/gtypes.h:32,
                 from /usr/include/glib-2.0/glib/galloca.h:32,
                 from /usr/include/glib-2.0/glib.h:30,
                 from /usr/include/gstreamer-1.0/gst/gst.h:27,
                 from /build/kamoso/src/kamoso-18.03.80/src/elements/gstqtvideosink/gstqtvideosinkplugin.h:20,
                 from /build/kamoso/src/kamoso-18.03.80/src/elements/gstqtvideosink/gstqtvideosinkplugin.cpp:18:
<command-line>:0:24: error: expected initializer before ‘-’ token
/usr/include/glib-2.0/glib/gmacros.h:229:62: note: in definition of macro ‘G_PASTE_ARGS’
 #define G_PASTE_ARGS(identifier1,identifier2) identifier1 ## identifier2
                                                              ^~~~~~~~~~~
/usr/include/gstreamer-1.0/gst/gstplugin.h:257:41: note: in expansion of macro ‘G_PASTE’
 GST_PLUGIN_EXPORT const GstPluginDesc * G_PASTE(gst_plugin_, G_PASTE(name, _get_desc)) (void); \
                                         ^~~~~~~
/usr/include/glib-2.0/glib/gmacros.h:230:47: note: in expansion of macro ‘G_PASTE_ARGS’
 #define G_PASTE(identifier1,identifier2)      G_PASTE_ARGS (identifier1, identifier2)
                                               ^~~~~~~~~~~~
/usr/include/gstreamer-1.0/gst/gstplugin.h:257:62: note: in expansion of macro ‘G_PASTE’
 GST_PLUGIN_EXPORT const GstPluginDesc * G_PASTE(gst_plugin_, G_PASTE(name, _get_desc)) (void); \
                                                              ^~~~~~~
/build/kamoso/src/kamoso-18.03.80/src/elements/gstqtvideosink/gstqtvideosinkplugin.cpp:41:1: note: in expansion of macro ‘GST_PLUGIN_DEFINE’
 GST_PLUGIN_DEFINE (
 ^~~~~~~~~~~~~~~~~
/build/kamoso/src/kamoso-18.03.80/src/elements/gstqtvideosink/gstqtvideosinkplugin.cpp:44:5: note: in expansion of macro ‘QTVIDEOSINK_NAME’
     QTVIDEOSINK_NAME,
     ^~~~~~~~~~~~~~~~
<command-line>:0:24: error: expected initializer before ‘-’ token
/usr/include/glib-2.0/glib/gmacros.h:229:62: note: in definition of macro ‘G_PASTE_ARGS’
 #define G_PASTE_ARGS(identifier1,identifier2) identifier1 ## identifier2
                                                              ^~~~~~~~~~~
/usr/include/gstreamer-1.0/gst/gstplugin.h:258:24: note: in expansion of macro ‘G_PASTE’
 GST_PLUGIN_EXPORT void G_PASTE(gst_plugin_, G_PASTE(name, _register)) (void); \
                        ^~~~~~~
/usr/include/glib-2.0/glib/gmacros.h:230:47: note: in expansion of macro ‘G_PASTE_ARGS’
 #define G_PASTE(identifier1,identifier2)      G_PASTE_ARGS (identifier1, identifier2)
                                               ^~~~~~~~~~~~
/usr/include/gstreamer-1.0/gst/gstplugin.h:258:45: note: in expansion of macro ‘G_PASTE’
 GST_PLUGIN_EXPORT void G_PASTE(gst_plugin_, G_PASTE(name, _register)) (void); \
                                             ^~~~~~~
/build/kamoso/src/kamoso-18.03.80/src/elements/gstqtvideosink/gstqtvideosinkplugin.cpp:41:1: note: in expansion of macro ‘GST_PLUGIN_DEFINE’
 GST_PLUGIN_DEFINE (
 ^~~~~~~~~~~~~~~~~
/build/kamoso/src/kamoso-18.03.80/src/elements/gstqtvideosink/gstqtvideosinkplugin.cpp:44:5: note: in expansion of macro ‘QTVIDEOSINK_NAME’
     QTVIDEOSINK_NAME,
     ^~~~~~~~~~~~~~~~
[ 60%] Generating qrc_resources.cpp
<command-line>:0:24: error: expected initializer before ‘-’ token
/usr/include/glib-2.0/glib/gmacros.h:229:62: note: in definition of macro ‘G_PASTE_ARGS’
 #define G_PASTE_ARGS(identifier1,identifier2) identifier1 ## identifier2
                                                              ^~~~~~~~~~~
/usr/include/gstreamer-1.0/gst/gstplugin.h:276:1: note: in expansion of macro ‘G_PASTE’
 G_PASTE(gst_plugin_, G_PASTE(name, _get_desc)) (void) \
 ^~~~~~~
/usr/include/glib-2.0/glib/gmacros.h:230:47: note: in expansion of macro ‘G_PASTE_ARGS’
 #define G_PASTE(identifier1,identifier2)      G_PASTE_ARGS (identifier1, identifier2)
                                               ^~~~~~~~~~~~
/usr/include/gstreamer-1.0/gst/gstplugin.h:276:22: note: in expansion of macro ‘G_PASTE’
 G_PASTE(gst_plugin_, G_PASTE(name, _get_desc)) (void) \
                      ^~~~~~~
/build/kamoso/src/kamoso-18.03.80/src/elements/gstqtvideosink/gstqtvideosinkplugin.cpp:41:1: note: in expansion of macro ‘GST_PLUGIN_DEFINE’
 GST_PLUGIN_DEFINE (
 ^~~~~~~~~~~~~~~~~
/build/kamoso/src/kamoso-18.03.80/src/elements/gstqtvideosink/gstqtvideosinkplugin.cpp:44:5: note: in expansion of macro ‘QTVIDEOSINK_NAME’
     QTVIDEOSINK_NAME,
     ^~~~~~~~~~~~~~~~
<command-line>:0:24: error: expected initializer before ‘-’ token
/usr/include/glib-2.0/glib/gmacros.h:229:62: note: in definition of macro ‘G_PASTE_ARGS’
 #define G_PASTE_ARGS(identifier1,identifier2) identifier1 ## identifier2
                                                              ^~~~~~~~~~~
/usr/include/gstreamer-1.0/gst/gstplugin.h:282:1: note: in expansion of macro ‘G_PASTE’
 G_PASTE(gst_plugin_, G_PASTE(name, _register)) (void) \
 ^~~~~~~
/usr/include/glib-2.0/glib/gmacros.h:230:47: note: in expansion of macro ‘G_PASTE_ARGS’
 #define G_PASTE(identifier1,identifier2)      G_PASTE_ARGS (identifier1, identifier2)
                                               ^~~~~~~~~~~~
/usr/include/gstreamer-1.0/gst/gstplugin.h:282:22: note: in expansion of macro ‘G_PASTE’
 G_PASTE(gst_plugin_, G_PASTE(name, _register)) (void) \
                      ^~~~~~~
/build/kamoso/src/kamoso-18.03.80/src/elements/gstqtvideosink/gstqtvideosinkplugin.cpp:41:1: note: in expansion of macro ‘GST_PLUGIN_DEFINE’
 GST_PLUGIN_DEFINE (
 ^~~~~~~~~~~~~~~~~
/build/kamoso/src/kamoso-18.03.80/src/elements/gstqtvideosink/gstqtvideosinkplugin.cpp:44:5: note: in expansion of macro ‘QTVIDEOSINK_NAME’
     QTVIDEOSINK_NAME,
     ^~~~~~~~~~~~~~~~
make[2]: *** [src/elements/gstqtvideosink/CMakeFiles/gstkamoso-qt5videosink.dir/build.make:143: src/elements/gstqtvideosink/CMakeFiles/gstkamoso-qt5videosink.dir/gstqtvideosinkplugin.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
Comment 1 Rex Dieter 2018-03-23 21:55:25 UTC
confirming, seeing same here on my fedora box
Comment 2 Aleix Pol 2018-03-26 14:01:31 UTC
I can reproduce as well. Have no idea why that is, investigating.
Comment 3 Aleix Pol 2018-03-26 15:28:08 UTC
Git commit 4667891fc1f28c6d7d427d86e434dc5ead7f8408 by Aleix Pol.
Committed on 26/03/2018 at 15:27.
Pushed by apol into branch 'master'.

Fix build against gst 1.14

M  +1    -1    src/elements/CMakeLists.txt

https://commits.kde.org/kamoso/4667891fc1f28c6d7d427d86e434dc5ead7f8408
Comment 4 Antonio Rojas 2018-03-26 17:59:55 UTC
can this go in 18.04 too, please?
Comment 5 Aleix Pol 2018-03-26 18:02:45 UTC
Git commit c2bc84b747467899f41dfa9d36fdac5b906f98c0 by Aleix Pol.
Committed on 26/03/2018 at 18:02.
Pushed by apol into branch 'Applications/18.04'.

Fix build against gst 1.14

M  +1    -1    src/elements/CMakeLists.txt

https://commits.kde.org/kamoso/c2bc84b747467899f41dfa9d36fdac5b906f98c0
Comment 6 Rex Dieter 2018-03-31 16:51:40 UTC
18.04 branch still fails to build for me against gst-1.14, at end of cmake call:

...
-- Configuring incomplete, errors occurred!
See also "/builddir/build/BUILD/kamoso-18.03.80/x86_64-redhat-linux-gnu/CMakeFiles/CMakeOutput.log".
CMake Error: The following variables are used in this project, but they are set to NOTFOUND.
Please set them or make sure they are set and tested correctly in the CMake files:
GSTREAMER_VIDEO_LIBRARY
    linked by target "gstkamosoqt5videosink" in directory /builddir/build/BUILD/kamoso-18.03.80/src/elements/gstqtvideosink
    linked by target "qtvideosink_autotest" in directory /builddir/build/BUILD/kamoso-18.03.80/src/elements/gstqtvideosink

Full log (temporary):
https://kojipkgs.fedoraproject.org//work/tasks/6279/26086279/build.log
Comment 7 Aleix Pol 2018-04-04 10:38:43 UTC
FIND_LIBRARY(GSTREAMER_VIDEO_LIBRARY NAMES gstvideo-${GSTREAMER_API_VERSION}
   PATHS
   ${PKG_GSTREAMER_LIBRARY_DIRS}
   )

This one isn't succeeding, make sure you have your dependencies set straight.
Also please report another bug, you are seeing a different issue as Antonio from ArchLinux was.
Comment 8 Rex Dieter 2018-04-04 13:43:41 UTC
ok, see bug #392720