Bug 392197 - Krunner needs two up/down key presses to move list selection
Summary: Krunner needs two up/down key presses to move list selection
Status: RESOLVED FIXED
Alias: None
Product: krunner
Classification: Plasma
Component: general (show other bugs)
Version: 5.12.3
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Kai Uwe Broulik
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2018-03-22 21:13 UTC by Nikolaos Kakouros
Modified: 2018-03-23 14:19 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolaos Kakouros 2018-03-22 21:13:47 UTC
Steps to reproduce:

1. Open krunner
2. Type anything that produces at least two results
3. Press down

Expected result:
The second item should be highlighter

Actual result:
The first item remains highlighted

The current behavior is a bit counter-intuitive and, personally, I cannot imagine a use case that it satisfies. I think it would be a nice papercut bug!
Comment 1 David Edmundson 2018-03-23 01:14:09 UTC
The first entry is fake selected even though focus is on the text field. Pressing down focusses the view, and only after that do up/down move the current index.

> I cannot imagine a use case that it satisfies

keyboard selections of actions on the first result.

Not to say this isn't an issue, but doing the "obvious" fix would probably break it
Comment 2 Nate Graham 2018-03-23 13:40:17 UTC
Here's a patch: https://phabricator.kde.org/D11611

This patch doesn't break keyboard selection of the "Open containing folder" action for the first result, it only changes it a bit (details in the patch).
Comment 3 Nate Graham 2018-03-23 14:19:39 UTC
Git commit b8ffa755ed2df6bf6a47b9268e7da93355a4d856 by Nathaniel Graham.
Committed on 23/03/2018 at 14:19.
Pushed by ngraham into branch 'Plasma/5.12'.

Move to KRunner's second results item with a single keypress

Summary:
Currently, to navigate the list of results after typing a search term, you need to press the down arrow twice: first to focus the result list, and a second time to actually change the selection. This patch fixes that by changing the selection during the focus oprtation.

Test Plan:
Deployed change, killed, restarted, and activated KRunner, typed a search term:
- The down arrow key now moves to the second item
- Clicked on the text field; up arrow now moves to the previous item in the results list

Activating the {nav Open Containing Folder} button for the first result via the keyboard changes slightly with this patch:
- Currently, it's {nav down arrow > tab key}
- With this patch, it's {nav tab key three times} or {nav down arrow > shift + tab}

Seems like an acceptable change to me to better support the common case of just wanting to easily navigate to the results list items.

Reviewers: #plasma, broulik, mart

Reviewed By: #plasma, broulik, mart

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D11611

M  +4    -2    lookandfeel/contents/runcommand/RunCommand.qml

https://commits.kde.org/plasma-workspace/b8ffa755ed2df6bf6a47b9268e7da93355a4d856