Bug 392022 - Position of a face tag appears on top of bottom of the list, instead of being sorted alphabetically
Summary: Position of a face tag appears on top of bottom of the list, instead of being...
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Faces-Workflow (show other bugs)
Version: 5.9.0
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-18 20:35 UTC by MarcP
Modified: 2019-02-03 21:16 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.1.0
Sentry Crash Report:


Attachments
the current order of person names in the person selection pane (4.84 KB, image/png)
2019-02-02 17:14 UTC, stefan.mueller.83
Details
the current order of suggested person names editing the suggest name in the confirm person name workflow (3.67 KB, image/png)
2019-02-02 17:15 UTC, stefan.mueller.83
Details

Note You need to log in before you can comment on or make changes to this bug.
Description MarcP 2018-03-18 20:35:09 UTC
I am not sure if this is a bug or it is done on purpose.

Sometimes when working with face tags, that specific tag on the People panel will appear on the top or on the bottom of the People list, instead on its corresponding alphabetical position. 

I am not 100% sure if the same behavior appears with regular tags, but it is possible.
Comment 1 MarcP 2018-03-18 23:48:14 UTC
I've been able to reproduce it in the Tag panel too.

Steps: 

1) Search for a tag in the search box below.
2) Select that tag.
3) Delete the search text.

That tag will appear now on top of the list, even if you select other tags.
Comment 2 Maik Qualmann 2018-03-19 07:11:32 UTC
Yes, this behavior is so desired by the users and was specially integrate for digiKam-5.x again. This list will also appear as a popup on manual face tagging. The wish was that the last used tags appear at the top for faster selection.

Maik
Comment 3 MarcP 2018-03-19 10:25:16 UTC
Ok, then it's fine. I think it would more intuitive to return the full list of tags with the last tag used being pre-selected, but in any case, it's not a big deal.
Comment 4 stefan.mueller.83 2019-01-27 19:46:22 UTC
> The wish was that the last used tags appear at the top for faster selection.
Would it possible to split those list in last selected ones (maybe with three items, preferably adjustable in the options menu) and all items. Thus, the normal list (all items) remains consistent. 
For easier discrimination, the first list shall be formatted e.g. italic.
Comment 5 Maik Qualmann 2019-01-28 07:15:03 UTC
We're talking about the face tags list in the popup that pops up when I start typing a name? I ask something provocative, what can improve their wish? The last used appear at top, why should they be duplicated or in italics? I do not see how it should accelerate the input somehow.

Maik
Comment 6 caulier.gilles 2019-01-28 07:29:03 UTC
I agree with Maik here. 
If you have a better workflow with face management, please provide a proff of concept using mockup.
Thanks in advance
Comment 7 stefan.mueller.83 2019-01-28 08:28:47 UTC
@IWBR, can you attach screenshot of 'your' issue.
I'll try to do it next weekend.
Comment 8 stefan.mueller.83 2019-02-02 17:14:27 UTC
Created attachment 117789 [details]
the current order of person names in the person selection pane
Comment 9 stefan.mueller.83 2019-02-02 17:15:14 UTC
Created attachment 117790 [details]
the current order of suggested person names editing the suggest name in the confirm person name workflow
Comment 10 stefan.mueller.83 2019-02-02 17:20:37 UTC
I added the two list I came across in regard to faces as an attachment.
It looks like there is any sort in the confirm or edit person name workflow list. It lists the last used faces, doesn't it?
I admit that it can ease the workflow if the last selected is on top but it doesn't have to be like necessarily. 
In addition, it could be useful in other selection workflows as well. 

How about to split it and add a separator, so it shows e.g. the last 3 selected in the last selected list above or below the normal list.
Comment 11 MarcP 2019-02-03 01:11:46 UTC
Sorry, I didn't read the previous messages until now. I particularly don't think it's a big deal, so the current behavior works for me. It is true that is not completely intuitive, as I thought the way it puts the last selected tag on top of the list was a bug, so I reported it. There's some ambiguity at least.

What Stefan suggested is also good idea. Adding a separator between the Recently used tags, and the main list of tags would eliminate that ambiguity. It could show the last three or four tags that were used, for easier access to those tags or people.
Comment 12 MarcP 2019-02-03 01:17:08 UTC
By the way, I just tried to reproduce this behavior, and it doesn't happen anymore when replicating the steps from comment #1. I'm using digikam-6.0.0-beta3-20181228T114626 appimage (yes, I will update it...)
Comment 13 Maik Qualmann 2019-02-03 20:46:25 UTC
Git commit 1507318d9e727ca226c8f805507feecfbea6e948 by Maik Qualmann.
Committed on 03/02/2019 at 20:45.
Pushed by mqualmann into branch 'development/dplugins'.

sort item list and use different icon for last used tags
FIXED-IN: 6.1.0

M  +3    -3    core/libs/database/tags/tagscache.cpp
M  +14   -0    core/libs/tags/engine/taggingactionfactory.cpp
M  +3    -0    core/libs/tags/engine/taggingactionfactory.h
M  +5    -0    core/libs/tags/engine/tagscompleter.cpp

https://commits.kde.org/digikam/1507318d9e727ca226c8f805507feecfbea6e948
Comment 14 stefan.mueller.83 2019-02-03 20:52:26 UTC
wow that was quick but what means: 
> sort item list and use a different icon for last used tags
separated lists or single list each with different icons?
There might be others blaming that the last ones used are hard to find as the list is too long.
Comment 15 Maik Qualmann 2019-02-03 21:16:08 UTC
The last used are not sorted and always at the beginning of the list, in the end it would be pointless. Theoretically, a maximum of 10 last used items are possible, practically there are already after 2 entered letters usually only about 2-3 items.

Maik